From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8509FA034E; Fri, 4 Mar 2022 17:19:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 575FA427D2; Fri, 4 Mar 2022 17:19:41 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 60062427CA for ; Fri, 4 Mar 2022 17:19:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646410780; x=1677946780; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=PUMEDS9dkOjT4rGkf+HCDZa5KUj0wgx/ze/sNieMhVI=; b=VHSB/7OdkuG3NBE9BNGGeGSbBSxZcqKekIZT1NsuS/sg59rivOxfZrZC B6lr5PdPzVKfjU2hvHRY2mr22Kx6WxnmfPX/eepdEC4Sgyc2gB95mfVkg 7oBXKQTA+A2ML19wJ20GKmI/irU8SPv/tMZIYH2V1Y30vA9XBVkdyX+4r nMdc2jppi2ZaGoMvO+e7kDmSCxQv1eyej7Ik54JBVnFBsip54ZMBoRZ0h RBnXNHgOp0fG6pF3E6fPbK4VyXP0vC8YmlSv9ogWISNg8BjT0XjfeqKQv 7CjNGXegP0tlJHO7Xm+/x6oG7mq3keg6prCmMnrB+SiVhY/I/UFic/LsD w==; X-IronPort-AV: E=McAfee;i="6200,9189,10276"; a="253736428" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="253736428" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 08:19:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="536325738" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 04 Mar 2022 08:19:17 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 08:19:16 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 08:19:16 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 4 Mar 2022 08:19:16 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 4 Mar 2022 08:19:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JqOLcjzKuURyuGbr/ztV+w9dx9kNqcPQq6N+he0rtLNKohcMcCLF976gFAtyrWmPqzjoRL2SLBvoTgAHvInIsqkJvZXlU8QTZGVigNruhoGkcNS6bqnEF70zW/hKXBzm3ijFq8dypEwzdrCzthQeWZslY1SqluVsQ0msPATKMRelZWb+2xPSuU5E5lgaARuB5drempZcxGaWWt3efAQfhAlzy9TKuMb0IzatxBkfeF3KOw7mtNVgblQJMLOU3EXdv4HfL9wtefaNhwLgOCNz4RFfgb7XPDGV6+TYG6JdEeinv0BOMxlCcABGfJ+vwh9GwvONyGUZTAOwWaKnBTPl1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ro1sD87pp6dHYAlbQTQ4psMlfbCTTzLgRBzbQfUVIY=; b=aVHq8J9SypGp3VfTw1WX0P3MgGnhSBGTMIplymKXH9SIXMxtqDByExDvkY6fJjwG71JYKslQ6opGyCJANiTFTJlshM12pGoYoiIwW22HxGlew9CCi8nZdgds3qH4hJJ9pvb7BLiLb+RJ3CiUfb7DJzGo5R8TiiHupd2oLwO04Ofv8WvwrESGogWkRNuvd8OF0hLPigtkQCp5laT6WXcFRocmJqK6AG3u8wo0dccUeZspYNu5uiIskgy6WbKBOxIQ4oSY1BPh3pniP0K6F76qwkCtBwE/ixMeGchYI+EyUQuG4qFfaL1DUPRjv74W+iYSGpkTTx1d2waoTNSDScyADA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SJ0PR11MB4958.namprd11.prod.outlook.com (2603:10b6:a03:2ae::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.16; Fri, 4 Mar 2022 16:19:04 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 16:19:04 +0000 Message-ID: <2b3f014b-af62-db9b-95cc-5dfda689b6ae@intel.com> Date: Fri, 4 Mar 2022 16:18:57 +0000 Content-Language: en-US To: , , , , , CC: References: <20220304023701.499961-1-wenxuanx.wu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v2] app/testpmd : fix testpmd quit error X-User: ferruhy In-Reply-To: <20220304023701.499961-1-wenxuanx.wu@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P193CA0006.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a0ceb01-347a-43c0-a419-08d9fdfab316 X-MS-TrafficTypeDiagnostic: SJ0PR11MB4958:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YBgc7/YJMo8mmLA3lpI0qheibrp6P9nvt461UyagG7ItbVb2zMKikUmvNF9fPe4dmBDejtvkjB/CHgHjdfPNGBcdAe+HPtPp8vx7j+vkACyOCg3hcwxm6EJ0jBddcdMdeinmLQOVKCAjraocAXqKHLu3J/VwLwDgzYjB9EauVUiiQgjhJkY80YMnnxUde71R2B6bmqSUkc2oGHDQE8XGqAPEwluG/TbKXQ+jaa3XRIm9n0s3tQ19vbUB1zaL9YE3m2Wci4ZZXalxzjWggBwax+YRZ6nEGQ3OJXN7HNPLXpIVg5UViCV75h3DbnobJWjy3U44leMKhgAKZG7jZM+AYISxxR5gEgEr88JZnWGfim60XIHKrD4QDK+7Vbs8jAo22hNkkUfgaveOVF3b3DpnYS84UFduq6O6w4F9iFe9Z/WwYiISIF1eixBJ+tYukAnhdLQpzxX4wT0LmIVrbMH3OJVcM73PWn4ChBfwLscngroaPZexfJZ9h5wW6dS09ux20r7hRvEUGfMHtWwMr3GF7wofDk72dk13XRgZRY5H9i/+dQXqNHqNtGLnUdgzZEt7NbTvprZrLAYpF8+Aw3pSdrSbnpYmy/B3x9rXesbvMwLox3CVylcP0Ks1v66BsuF2R3L2Yz63BG3fHs4rQHk1rmiY+xsLPHndZ6p06HqcUMsxmj0R32Vng9BQmQ7yU6gSgtEbq7QDgFv6TMiq/VNMtg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(6486002)(31686004)(5660300002)(83380400001)(2906002)(2616005)(44832011)(26005)(6636002)(38100700002)(186003)(8936002)(6512007)(82960400001)(31696002)(8676002)(508600001)(53546011)(66556008)(66476007)(6506007)(66946007)(86362001)(4326008)(6666004)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnVlWVVTOUdvdm5IU21GWHhWQVpTbmtna3NKUUZ2QlNjLzFJdERPSlZiQjRt?= =?utf-8?B?WURYa0JwN0ROekxPcjNCaHN4dGFVbFZrTndzRTkxcXdwTStFZmVYOTBiMU1r?= =?utf-8?B?UXFaU2EzYU1KU0NiaVQ3TEZpVUdHdGlFSjNwZkk3S3pHUXZmWm1Nb1dlRVpE?= =?utf-8?B?Z0NoUStQSE8rVkM4QTF1cHRveXcwbE01NFRrcXpLZkhZZG5vU1Z0ajlhUkNl?= =?utf-8?B?eGFmcDBuT2F6Nnk2cVdEUkNGMHdGeit4OHMrZUpoREVMNVlUNlcrRHFaZFYw?= =?utf-8?B?T2RqQ1RuSEtnYUh0MEhUNG93d1JUWlJKVmMrRkkxTGVHVjlZRCtyVGlTcnJV?= =?utf-8?B?U2tGRW41eHlBNkswYS9KS0JJZmJCdW1qcVBlekd4TW1HQm12cUlvVmdzWWNm?= =?utf-8?B?SEZpTm9SNEExeGlJQ3ptdmZUbWRzbGg1Qlo5L1c2c1RtZnRmZHJVVHhXdWU2?= =?utf-8?B?bEhtYmhaY3ZaQXNqVkRYVXlUdWhVT3U0K3FrbzJBQ3pZZmxEL0hIb1dMYkto?= =?utf-8?B?N2FsN05IeG9MT1NWMUxZUDZMcTQzS2d4YURsZlBaaGVxenF1ejVaRU44WndX?= =?utf-8?B?RGx3clhRUGR3dmdnYTJJYlBLL25vaTJEYWZrZ051MmNGRTlsTEVVb1dwdXc3?= =?utf-8?B?eis3WWppZWR4OGp4Z2QrbFNZTXJkdTJ0NzBZdmpDay9ZQ2YwaFJMR3hySU0w?= =?utf-8?B?Wi9PQ3BUR0dXbW51Tzkrd2xLQ1VTRU9zYkk1UlpBSURhalRwaVpOVTl5YjM2?= =?utf-8?B?YjRiLy9LTmgwZ1JoUlVjOUhzcDloOS82VHh4aVhWV0dvSEhVMlpmdWJDUEdH?= =?utf-8?B?cjFjamZRT1BaSG5aeTFBYVhkOHd3UEM3c2JWSXhRbzRvanFROXlLZjNVRkhG?= =?utf-8?B?eGFnSUsyTktFYVpRRHRrajg2M2tOQmduSFU2WHV3R0pTT1FqaUhRNnJmRWZt?= =?utf-8?B?YzJ0TTFRQ0crS0pnWE1oZHE5TVB0QTBYNUtIcHNCVXhoZndzSEtlUENRL0d5?= =?utf-8?B?eCtCemxIU0Z1M2QrSXovODBHRnBndTNVQVJPU3ZiemJVQndUZ0hMTE5vZC9L?= =?utf-8?B?NkJkWUNtTDdSNjNQTHdTT2tIRXd0TW9ScVRubG9rVlF2dWl6eG13OTEwek9H?= =?utf-8?B?YnF5bkd2MENnU3E5bmhTU3BLVExtc2Nac1dtZk42ZUZ3V1dqLzdKKzhIeDYw?= =?utf-8?B?R0ZYSUR6d1RybGF2UEpRYW9sWi9uNG1JNGh1VUhMaklmQ2VQNE5maE5WT0lv?= =?utf-8?B?dlJYZVJONjhodUxrQ3NrZUtzeWZWUVcxS0poQ2t1UlZMSm5IYW51VmpYaGJX?= =?utf-8?B?Z1ZpRG5HKzBuSTFMRXdHeFN1MDdEejdNTUhDM0Jib1ZEYTd2TFRWNkdJbVdC?= =?utf-8?B?c2YveGpsdkZ0bmdpOTlsbjNuTzVhbGdXenV6cnRRYVM4UE41alRtRk9NdGg2?= =?utf-8?B?RWROTWhNMkpkL1hSTDFuWWs3NUxmNHQ5RTlLM3B5aG9rNTlqWFE2KzRKL25I?= =?utf-8?B?Y1h1dkI3ZEtpQ2FUSkllMWEzbU9XTDA5OElQNWNXdWVGS3NBTVExY0xIQWFY?= =?utf-8?B?WE5tdzAxRFJ0bzJGMUQwVDBnMFZRWFpYVkQyZEUzbFZSQWRFNkxrTTJqdWFE?= =?utf-8?B?Ym9GcHJqQitqZDYxZWVsd1lieHgvdEdKS3JOOWlrN1k5M3dmNW9rcVN5MWhU?= =?utf-8?B?cDJIcDVjRkR3ME9qa3Z1MkN1RmFvWFh4RFFEczJBaFpNcnp6Zkd1NHdHZ0N2?= =?utf-8?B?aFo1Wm9MekdzYk1rQ3NuL0lPR0dlQ0hWcDcwandFQm83SDJ6ZUxxV2ttVDJN?= =?utf-8?B?Z0NwMWU4c3FkWEMzU2xoNHFKekNuU0NtempLdlVyY3lST2pua1dHT0FIQjUx?= =?utf-8?B?QncrV09NYWl6U3lRNDN1bjNKTTVNV2FWajdkSTJKMzFCcjhudTRpVUlOV09h?= =?utf-8?B?SWExK3pGdmk5SFlLa25GQXFPQWM4NTFPTzNvcStob1VrZnlMcTUyRkZHbHJZ?= =?utf-8?B?c040WGFWSU9yVzhBRFdhN2YxbkxMVTY4MjVOZkw1eUZCcXJTVTAxU1JEUW9o?= =?utf-8?B?NFQwSERsaVJaMHBPdXFNWUJMWWNacDFtTEFPZGdLbDFGS29iWGNYbUhpTGxO?= =?utf-8?B?R3g2NHQvSFlidDNzUG1pV1BhL0NaTTRTcnh5c2kxdVNGZmtnNWFDZnlOV1JL?= =?utf-8?Q?KOBz+7YnKfaJB+5PdVV4L3k=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9a0ceb01-347a-43c0-a419-08d9fdfab316 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 16:19:04.0704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cM8DWwrZKhaEwhG0OeQYTxUJjpuKeiqAPQKB7kAzCG9e9lcKdNZUVjr/4OVelsr7If2OwL5W9g5MbLSZJhLDJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4958 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/4/2022 2:37 AM, wenxuanx.wu@intel.com wrote: > From: wenxuan wu > > When testpmd use func get_eth_dev_info() while related resource > had been released. > Is 'eth_dev_info_get_print_err()' fails at this stage? What resource is released, the 'slave_port' itself? And there may be another logic wrong, it shouldn't try to detect if a released port is bonding port or not. > Change the logic of func port_is_bonding_slave, this func > eth_dev_info_get_print_err while pf is released would result > in this error. Use ports instead to avoid this bug. > This relies to application level stored value to decide about port, not sure if this is reliable. > Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev array") > Cc: stable@dpdk.org > > Signed-off-by: wenxuan wu > --- > app/test-pmd/testpmd.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index e1da961311..37038c9183 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3824,19 +3824,9 @@ void clear_port_slave_flag(portid_t slave_pid) > uint8_t port_is_bonding_slave(portid_t slave_pid) > { > struct rte_port *port; > - struct rte_eth_dev_info dev_info; > - int ret; > > port = &ports[slave_pid]; > - ret = eth_dev_info_get_print_err(slave_pid, &dev_info); > - if (ret != 0) { > - TESTPMD_LOG(ERR, > - "Failed to get device info for port id %d," > - "cannot determine if the port is a bonded slave", > - slave_pid); > - return 0; > - } > - if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) > + if ((*port->dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) > return 1; > return 0; > }