DPDK patches and discussions
 help / color / mirror / Atom feed
From: Declan Doherty <declan.doherty@intel.com>
To: RongQiang Xie <xie.rongqiang@zte.com.cn>, jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd:add bond type description
Date: Fri, 30 Jun 2017 14:47:52 +0100	[thread overview]
Message-ID: <2b44c5ee-b1ae-7f47-0c07-a0375f27584a@intel.com> (raw)
In-Reply-To: <201706300158.v5U1wmLt087572@mse01.zte.com.cn>

On 30/06/2017 2:52 AM, RongQiang Xie wrote:
> In function  cmd_show_bonding_config_parsed() use number
> represent the bond type,in order more detailed,add bond
> type description otherwise we may confused about the number
> type.
> And also,The primary port just use in mode active backup
> and tlb,so,when the mode is the active backup or tlb we
> show the primary port info.
>
> Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>
> ---
>  app/test-pmd/cmdline.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 4eac498..1ae5fc0 100755
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4455,6 +4455,7 @@ static void cmd_show_bonding_config_parsed(void *parsed_result,
>  		printf("\tActive Slaves: []\n");
>
>  	}
> +	
>  	if (bonding_mode == BONDING_MODE_ACTIVE_BACKUP ||
>  		bonding_mode == BONDING_MODE_TLB) {
>  		primary_id = rte_eth_bond_primary_get(port_id);
>

Hey, I think you are missing some of your intended changes in this 
patch? I'm only seeing a white space addition. Also the body of your 
email seems to be merged with the emails subject line.

Thanks
Declan

  reply	other threads:[~2017-06-30 13:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  1:52 RongQiang Xie
2017-06-30 13:47 ` Declan Doherty [this message]
2017-06-30 13:52   ` Declan Doherty
2017-06-30  2:33 RongQiang Xie
2017-06-30  7:35 RongQiang Xie
2017-06-30  7:56 RongQiang Xie
2017-06-30 15:39 ` Declan Doherty
2017-07-02 18:11   ` Thomas Monjalon
2017-08-24 10:55 Rongqiang XIE
2017-08-25  2:49 Rongqiang XIE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b44c5ee-b1ae-7f47-0c07-a0375f27584a@intel.com \
    --to=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=xie.rongqiang@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).