From: "lihuisong (C)" <lihuisong@huawei.com>
To: Chas Williams <3chas3@gmail.com>, <dev@dpdk.org>
Cc: <ferruh.yigit@xilinx.com>, <andrew.rybchenko@oktetlabs.ru>,
<huangdaode@huawei.com>
Subject: Re: [PATCH V2] net/bonding: add link speeds configuration
Date: Fri, 16 Sep 2022 10:09:30 +0800 [thread overview]
Message-ID: <2bd0d951-bed6-e092-54e9-9c3a34a05321@huawei.com> (raw)
In-Reply-To: <7aa62c59-fa86-1d20-31eb-e55e5fa60ec3@gmail.com>
在 2022/9/15 21:43, Chas Williams 写道:
> On 9/15/22 09:14, Huisong Li wrote:
>> This patch adds link speeds configuration.
>>
>> ---
>> -v2: resend due to CI compiling failure.
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
>> b/drivers/net/bonding/rte_eth_bond_pmd.c
>> index 3191158ca7..0c1dbc3ff6 100644
>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> @@ -1717,6 +1717,8 @@ slave_configure(struct rte_eth_dev
>> *bonded_eth_dev,
>> slave_eth_dev->data->dev_conf.rxmode.mtu =
>> bonded_eth_dev->data->dev_conf.rxmode.mtu;
>> + slave_eth_dev->data->dev_conf.link_speeds =
>> + bonded_eth_dev->data->dev_conf.link_speeds;
>> slave_eth_dev->data->dev_conf.txmode.offloads |=
>> bonded_eth_dev->data->dev_conf.txmode.offloads;
>
>
> Where did bonded_eth_dev->data->dev_conf.link_speeds come from? This
> is rather messy since you might need to worry about intersection of
> speed_capa from the set of members in the bond group.
Hi chas,
Thanks for your review.
bonded_eth_dev->data->dev_conf.link_speeds come from user. I don't think
we need to complicate it.
Not all PMDs report 'speed_capa'. But the slave device knows if the
specified speed is supported.
So I think that it is better to leave to the slave device to determine
whether the speed is configured successfully.
> .
next prev parent reply other threads:[~2022-09-16 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 3:19 [PATCH] " Huisong Li
2022-09-15 13:14 ` [PATCH V2] " Huisong Li
2022-09-15 13:43 ` Chas Williams
2022-09-16 2:09 ` lihuisong (C) [this message]
2022-09-16 15:07 ` Chas Williams
2022-09-22 1:15 ` lihuisong (C)
2022-09-22 1:33 ` [PATCH V3] " Huisong Li
2022-09-25 10:35 ` Chas Williams
2022-10-17 8:22 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd0d951-bed6-e092-54e9-9c3a34a05321@huawei.com \
--to=lihuisong@huawei.com \
--cc=3chas3@gmail.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=huangdaode@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).