From: Kevin Traynor <ktraynor@redhat.com>
To: Harry van Haaren <harry.van.haaren@intel.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com, bruce.richardson@intel.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30
Date: Wed, 6 Feb 2019 16:16:55 +0000 [thread overview]
Message-ID: <2bd6c7bf-dab5-1e6b-6add-74247dc16690@redhat.com> (raw)
In-Reply-To: <20190117171744.63455-1-harry.van.haaren@intel.com>
On 01/17/2019 05:17 PM, Harry van Haaren wrote:
> This commit reworks the checks for binutils 2.30 and how
> the flags to disable AVX512F are passed to the compiler.
>
> Previously the #define for including AVX512 code was set,
> while the -mno-avx512f argument was given to the compiler.
> This would cause gcc to correctly refuse to emit AVX512
> instructions, but the rte_memcpy code that includes AVX512
> optimizations was being added to the build.
>
> The check for binutils check is now moved to x86 as it is
> irrelevant for other architectures, and the -mno-avx512f
> flag is passed to a march_opts array in meson. As the
> -mno-avx512 flag is added earlier in the build, the code
> in rte_memcpy is no longer attempted to be compiled.
>
> This commit also adds a message print in the meson configure
> stage to alert the user of the workaround being employed.
>
> Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support")
>
The patch this fixes is queued for 18.11 stable, so I presume this
should go there as well. I will send it as part of the normal queued
email anyway, so please let me know if there's a reason not to backport.
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
prev parent reply other threads:[~2019-02-06 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 17:17 Harry van Haaren
2019-01-17 17:23 ` Ferruh Yigit
2019-01-17 18:23 ` Thomas Monjalon
2019-01-17 17:56 ` Thomas Monjalon
2019-01-17 18:19 ` Van Haaren, Harry
2019-02-06 16:16 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd6c7bf-dab5-1e6b-6add-74247dc16690@redhat.com \
--to=ktraynor@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).