From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1872E5699 for ; Wed, 6 Feb 2019 17:16:59 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1693D80F98; Wed, 6 Feb 2019 16:16:58 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.33.36.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E43984E9; Wed, 6 Feb 2019 16:16:56 +0000 (UTC) To: Harry van Haaren , dev@dpdk.org Cc: ferruh.yigit@intel.com, bruce.richardson@intel.com, thomas@monjalon.net References: <20190117171744.63455-1-harry.van.haaren@intel.com> From: Kevin Traynor Organization: Red Hat Message-ID: <2bd6c7bf-dab5-1e6b-6add-74247dc16690@redhat.com> Date: Wed, 6 Feb 2019 16:16:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20190117171744.63455-1-harry.van.haaren@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 06 Feb 2019 16:16:58 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 16:16:59 -0000 On 01/17/2019 05:17 PM, Harry van Haaren wrote: > This commit reworks the checks for binutils 2.30 and how > the flags to disable AVX512F are passed to the compiler. > > Previously the #define for including AVX512 code was set, > while the -mno-avx512f argument was given to the compiler. > This would cause gcc to correctly refuse to emit AVX512 > instructions, but the rte_memcpy code that includes AVX512 > optimizations was being added to the build. > > The check for binutils check is now moved to x86 as it is > irrelevant for other architectures, and the -mno-avx512f > flag is passed to a march_opts array in meson. As the > -mno-avx512 flag is added earlier in the build, the code > in rte_memcpy is no longer attempted to be compiled. > > This commit also adds a message print in the meson configure > stage to alert the user of the workaround being employed. > > Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support") > The patch this fixes is queued for 18.11 stable, so I presume this should go there as well. I will send it as part of the normal queued email anyway, so please let me know if there's a reason not to backport. > Signed-off-by: Harry van Haaren > > ---