From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5AE1A0524; Thu, 30 Jan 2020 21:00:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C0C31C032; Thu, 30 Jan 2020 21:00:25 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 48A041C030 for ; Thu, 30 Jan 2020 21:00:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580414423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=W/fJkvQ6Cx4o4sKkb2ypforfpYTrO8diic0lon+t5WA=; b=dI8EshVRYJt/wJcRZvllkHY897jEnwC+XSHz0cKz2Zj6a95FiJO8belHvQVP5wubzlwwxn iLIjwIzNEPjxv6b9CchkKbSourcV3DhQ6ty/tobP1H6VBR83TIuEI7kmCgGgKszbv39P8q jM2IYXFhOwsORQfIk9NuuTGLIkgmVRo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-Dudn-W6MNjOjxyRkK1QmbQ-1; Thu, 30 Jan 2020 15:00:18 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97480186925E; Thu, 30 Jan 2020 20:00:17 +0000 (UTC) Received: from [10.36.112.51] (ovpn-112-51.ams2.redhat.com [10.36.112.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D6CFA60FC1; Thu, 30 Jan 2020 20:00:15 +0000 (UTC) To: Matan Azrad , dev@dpdk.org, Viacheslav Ovsiienko References: <1579539790-3882-1-git-send-email-matan@mellanox.com> <1580292549-27439-1-git-send-email-matan@mellanox.com> <1580292549-27439-7-git-send-email-matan@mellanox.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <2bdf2495-6d48-9d03-aa6a-a8a40507a020@redhat.com> Date: Thu, 30 Jan 2020 21:00:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1580292549-27439-7-git-send-email-matan@mellanox.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: Dudn-W6MNjOjxyRkK1QmbQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 06/13] vdpa/mlx5: prepare virtio queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/20 11:09 AM, Matan Azrad wrote: > The HW virtq object represents an emulated context for a VIRTIO_NET > virtqueue which was created and managed by a VIRTIO_NET driver as > defined in VIRTIO Specification. >=20 > Add support to prepare and release all the basic HW resources needed > the user virtqs emulation according to the rte_vhost configurations. >=20 > This patch prepares the basic configurations needed by DevX commands to > create a virtq. >=20 > Add new file mlx5_vdpa_virtq.c to manage virtq operations. >=20 > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > drivers/vdpa/mlx5/Makefile | 1 + > drivers/vdpa/mlx5/meson.build | 1 + > drivers/vdpa/mlx5/mlx5_vdpa.c | 1 + > drivers/vdpa/mlx5/mlx5_vdpa.h | 36 ++++++ > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 212 ++++++++++++++++++++++++++++++= ++++++ > 5 files changed, 251 insertions(+) > create mode 100644 drivers/vdpa/mlx5/mlx5_vdpa_virtq.c >=20 > diff --git a/drivers/vdpa/mlx5/Makefile b/drivers/vdpa/mlx5/Makefile > index 7f13756..353e262 100644 > --- a/drivers/vdpa/mlx5/Makefile > +++ b/drivers/vdpa/mlx5/Makefile > @@ -10,6 +10,7 @@ LIB =3D librte_pmd_mlx5_vdpa.a > SRCS-$(CONFIG_RTE_LIBRTE_MLX5_VDPA_PMD) +=3D mlx5_vdpa.c > SRCS-$(CONFIG_RTE_LIBRTE_MLX5_VDPA_PMD) +=3D mlx5_vdpa_mem.c > SRCS-$(CONFIG_RTE_LIBRTE_MLX5_VDPA_PMD) +=3D mlx5_vdpa_event.c > +SRCS-$(CONFIG_RTE_LIBRTE_MLX5_VDPA_PMD) +=3D mlx5_vdpa_virtq.c > =20 > # Basic CFLAGS. > CFLAGS +=3D -O3 > diff --git a/drivers/vdpa/mlx5/meson.build b/drivers/vdpa/mlx5/meson.buil= d > index c609f7c..e017f95 100644 > --- a/drivers/vdpa/mlx5/meson.build > +++ b/drivers/vdpa/mlx5/meson.build > @@ -14,6 +14,7 @@ sources =3D files( > =09'mlx5_vdpa.c', > =09'mlx5_vdpa_mem.c', > =09'mlx5_vdpa_event.c', > +=09'mlx5_vdpa_virtq.c', > ) > cflags_options =3D [ > =09'-std=3Dc11', > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.= c > index c67f93d..4d30b35 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa.c > +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c > @@ -229,6 +229,7 @@ > =09=09goto error; > =09} > =09SLIST_INIT(&priv->mr_list); > +=09SLIST_INIT(&priv->virtq_list); > =09pthread_mutex_lock(&priv_list_lock); > =09TAILQ_INSERT_TAIL(&priv_list, priv, next); > =09pthread_mutex_unlock(&priv_list_lock); > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.= h > index 30030b7..a7e2185 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa.h > +++ b/drivers/vdpa/mlx5/mlx5_vdpa.h > @@ -53,6 +53,19 @@ struct mlx5_vdpa_query_mr { > =09int is_indirect; > }; > =20 > +struct mlx5_vdpa_virtq { > +=09SLIST_ENTRY(mlx5_vdpa_virtq) next; > +=09uint16_t index; > +=09uint16_t vq_size; > +=09struct mlx5_devx_obj *virtq; > +=09struct mlx5_vdpa_event_qp eqp; > +=09struct { > +=09=09struct mlx5dv_devx_umem *obj; > +=09=09void *buf; > +=09=09uint32_t size; > +=09} umems[3]; > +}; > + > struct mlx5_vdpa_priv { > =09TAILQ_ENTRY(mlx5_vdpa_priv) next; > =09int id; /* vDPA device id. */ > @@ -69,6 +82,10 @@ struct mlx5_vdpa_priv { > =09struct mlx5dv_devx_event_channel *eventc; > =09struct mlx5dv_devx_uar *uar; > =09struct rte_intr_handle intr_handle; > +=09struct mlx5_devx_obj *td; > +=09struct mlx5_devx_obj *tis; > +=09uint16_t nr_virtqs; > +=09SLIST_HEAD(virtq_list, mlx5_vdpa_virtq) virtq_list; > =09SLIST_HEAD(mr_list, mlx5_vdpa_query_mr) mr_list; > }; > =20 > @@ -146,4 +163,23 @@ int mlx5_vdpa_event_qp_create(struct mlx5_vdpa_priv = *priv, uint16_t desc_n, > */ > void mlx5_vdpa_cqe_event_unset(struct mlx5_vdpa_priv *priv); > =20 > +/** > + * Release a virtq and all its related resources. > + * > + * @param[in] priv > + * The vdpa driver private structure. > + */ > +void mlx5_vdpa_virtqs_release(struct mlx5_vdpa_priv *priv); > + > +/** > + * Create all the HW virtqs resources and all their related resources. > + * > + * @param[in] priv > + * The vdpa driver private structure. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set= . > + */ > +int mlx5_vdpa_virtqs_prepare(struct mlx5_vdpa_priv *priv); > + > #endif /* RTE_PMD_MLX5_VDPA_H_ */ > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5= _vdpa_virtq.c > new file mode 100644 > index 0000000..781bccf > --- /dev/null > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c > @@ -0,0 +1,212 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2019 Mellanox Technologies, Ltd > + */ > +#include > + > +#include > +#include > + > +#include > + > +#include "mlx5_vdpa_utils.h" > +#include "mlx5_vdpa.h" > + > + > +static int > +mlx5_vdpa_virtq_unset(struct mlx5_vdpa_virtq *virtq) > +{ > +=09int i; > + > +=09if (virtq->virtq) { > +=09=09claim_zero(mlx5_devx_cmd_destroy(virtq->virtq)); > +=09=09virtq->virtq =3D NULL; > +=09} > +=09for (i =3D 0; i < 3; ++i) { > +=09=09if (virtq->umems[i].obj) > +=09=09=09claim_zero(mlx5_glue->devx_umem_dereg > +=09=09=09=09=09=09=09 (virtq->umems[i].obj)); > +=09=09if (virtq->umems[i].buf) > +=09=09=09rte_free(virtq->umems[i].buf); > +=09} > +=09memset(&virtq->umems, 0, sizeof(virtq->umems)); > +=09if (virtq->eqp.fw_qp) > +=09=09mlx5_vdpa_event_qp_destroy(&virtq->eqp); > +=09return 0; > +} > + > +void > +mlx5_vdpa_virtqs_release(struct mlx5_vdpa_priv *priv) > +{ > +=09struct mlx5_vdpa_virtq *entry; > +=09struct mlx5_vdpa_virtq *next; > + > +=09entry =3D SLIST_FIRST(&priv->virtq_list); > +=09while (entry) { > +=09=09next =3D SLIST_NEXT(entry, next); > +=09=09mlx5_vdpa_virtq_unset(entry); > +=09=09SLIST_REMOVE(&priv->virtq_list, entry, mlx5_vdpa_virtq, next); > +=09=09rte_free(entry); > +=09=09entry =3D next; > +=09} > +=09SLIST_INIT(&priv->virtq_list); > +=09if (priv->tis) { > +=09=09claim_zero(mlx5_devx_cmd_destroy(priv->tis)); > +=09=09priv->tis =3D NULL; > +=09} > +=09if (priv->td) { > +=09=09claim_zero(mlx5_devx_cmd_destroy(priv->td)); > +=09=09priv->td =3D NULL; > +=09} > +} > + > +static uint64_t > +mlx5_vdpa_hva_to_gpa(struct rte_vhost_memory *mem, uint64_t hva) > +{ > +=09struct rte_vhost_mem_region *reg; > +=09uint32_t i; > +=09uint64_t gpa =3D 0; > + > +=09for (i =3D 0; i < mem->nregions; i++) { > +=09=09reg =3D &mem->regions[i]; > +=09=09if (hva >=3D reg->host_user_addr && > +=09=09 hva < reg->host_user_addr + reg->size) { > +=09=09=09gpa =3D hva - reg->host_user_addr + reg->guest_phys_addr; > +=09=09=09break; > +=09=09} > +=09} > +=09return gpa; > +} I think you may need a third parameter for the size to map. Otherwise, you would be vulnerable to CVE-2018-1059. > + > +static int > +mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, > +=09=09 struct mlx5_vdpa_virtq *virtq, int index) > +{ > +=09struct rte_vhost_vring vq; > +=09struct mlx5_devx_virtq_attr attr =3D {0}; > +=09uint64_t gpa; > +=09int ret; > +=09int i; > +=09uint16_t last_avail_idx; > +=09uint16_t last_used_idx; > + > +=09ret =3D rte_vhost_get_vhost_vring(priv->vid, index, &vq); > +=09if (ret) > +=09=09return -1; > +=09virtq->index =3D index; > +=09virtq->vq_size =3D vq.size; > +=09/* > +=09 * No need event QPs creation when the guest in poll mode or when the > +=09 * capability allows it. > +=09 */ > +=09attr.event_mode =3D vq.callfd !=3D -1 || !(priv->caps.event_mode & (1= << > +=09=09=09=09=09 MLX5_VIRTQ_EVENT_MODE_NO_MSIX)) ? > +=09=09=09=09=09=09 MLX5_VIRTQ_EVENT_MODE_QP : > +=09=09=09=09=09=09 MLX5_VIRTQ_EVENT_MODE_NO_MSIX; > +=09if (attr.event_mode =3D=3D MLX5_VIRTQ_EVENT_MODE_QP) { > +=09=09ret =3D mlx5_vdpa_event_qp_create(priv, vq.size, vq.callfd, > +=09=09=09=09=09=09&virtq->eqp); > +=09=09if (ret) { > +=09=09=09DRV_LOG(ERR, "Failed to create event QPs for virtq %d.", > +=09=09=09=09index); > +=09=09=09return -1; > +=09=09} > +=09=09attr.qp_id =3D virtq->eqp.fw_qp->id; > +=09} else { > +=09=09DRV_LOG(INFO, "Virtq %d is, for sure, working by poll mode, no" > +=09=09=09" need event QPs and event mechanism.", index); > +=09} > +=09/* Setup 3 UMEMs for each virtq. */ > +=09for (i =3D 0; i < 3; ++i) { > +=09=09virtq->umems[i].size =3D priv->caps.umems[i].a * vq.size + > +=09=09=09=09=09=09=09 priv->caps.umems[i].b; > +=09=09virtq->umems[i].buf =3D rte_zmalloc(__func__, > +=09=09=09=09=09=09 virtq->umems[i].size, 4096); > +=09=09if (!virtq->umems[i].buf) { > +=09=09=09DRV_LOG(ERR, "Cannot allocate umem %d memory for virtq" > +=09=09=09=09" %u.", i, index); > +=09=09=09goto error; > +=09=09} > +=09=09virtq->umems[i].obj =3D mlx5_glue->devx_umem_reg(priv->ctx, > +=09=09=09=09=09=09=09virtq->umems[i].buf, > +=09=09=09=09=09=09=09virtq->umems[i].size, > +=09=09=09=09=09=09=09IBV_ACCESS_LOCAL_WRITE); > +=09=09if (!virtq->umems[i].obj) { > +=09=09=09DRV_LOG(ERR, "Failed to register umem %d for virtq %u.", > +=09=09=09=09i, index); > +=09=09=09goto error; > +=09=09} > +=09=09attr.umems[i].id =3D virtq->umems[i].obj->umem_id; > +=09=09attr.umems[i].offset =3D 0; > +=09=09attr.umems[i].size =3D virtq->umems[i].size; > +=09} > +=09gpa =3D mlx5_vdpa_hva_to_gpa(priv->vmem, (uint64_t)(uintptr_t)vq.desc= ); > +=09if (!gpa) { > +=09=09DRV_LOG(ERR, "Fail to get GPA for descriptor ring."); > +=09=09goto error; > +=09} > +=09attr.desc_addr =3D gpa; > +=09gpa =3D mlx5_vdpa_hva_to_gpa(priv->vmem, (uint64_t)(uintptr_t)vq.used= ); > +=09if (!gpa) { > +=09=09DRV_LOG(ERR, "Fail to get GPA for used ring."); > +=09=09goto error; > +=09} > +=09attr.used_addr =3D gpa; > +=09gpa =3D mlx5_vdpa_hva_to_gpa(priv->vmem, (uint64_t)(uintptr_t)vq.avai= l); > +=09if (!gpa) { > +=09=09DRV_LOG(ERR, "Fail to get GPA for available ring."); > +=09=09goto error; > +=09} > +=09attr.available_addr =3D gpa; > +=09rte_vhost_get_vring_base(priv->vid, index, &last_avail_idx, > +=09=09=09=09 &last_used_idx); > +=09DRV_LOG(INFO, "vid %d: Init last_avail_idx=3D%d, last_used_idx=3D%d f= or " > +=09=09"virtq %d.", priv->vid, last_avail_idx, last_used_idx, index); > +=09attr.hw_available_index =3D last_avail_idx; > +=09attr.hw_used_index =3D last_used_idx; > +=09attr.q_size =3D vq.size; > +=09attr.mkey =3D priv->gpa_mkey_index; > +=09attr.tis_id =3D priv->tis->id; > +=09attr.queue_index =3D index; > +=09virtq->virtq =3D mlx5_devx_cmd_create_virtq(priv->ctx, &attr); > +=09if (!virtq->virtq) > +=09=09goto error; > +=09return 0; > +error: > +=09mlx5_vdpa_virtq_unset(virtq); > +=09return -1; > +} > + > +int > +mlx5_vdpa_virtqs_prepare(struct mlx5_vdpa_priv *priv) > +{ > +=09struct mlx5_devx_tis_attr tis_attr =3D {0}; > +=09struct mlx5_vdpa_virtq *virtq; > +=09uint32_t i; > +=09uint16_t nr_vring =3D rte_vhost_get_vring_num(priv->vid); > + > +=09priv->td =3D mlx5_devx_cmd_create_td(priv->ctx); > +=09if (!priv->td) { > +=09=09DRV_LOG(ERR, "Failed to create transport domain."); > +=09=09return -rte_errno; > +=09} > +=09tis_attr.transport_domain =3D priv->td->id; > +=09priv->tis =3D mlx5_devx_cmd_create_tis(priv->ctx, &tis_attr); > +=09if (!priv->tis) { > +=09=09DRV_LOG(ERR, "Failed to create TIS."); > +=09=09goto error; > +=09} > +=09for (i =3D 0; i < nr_vring; i++) { > +=09=09virtq =3D rte_zmalloc(__func__, sizeof(*virtq), 0); > +=09=09if (!virtq || mlx5_vdpa_virtq_setup(priv, virtq, i)) { > +=09=09=09if (virtq) > +=09=09=09=09rte_free(virtq); > +=09=09=09goto error; > +=09=09} > +=09=09SLIST_INSERT_HEAD(&priv->virtq_list, virtq, next); > +=09} > +=09priv->nr_virtqs =3D nr_vring; > +=09return 0; > +error: > +=09mlx5_vdpa_virtqs_release(priv); > +=09return -1; > +} >=20