From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CCFAA04C1; Thu, 21 Nov 2019 13:09:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 982432BB1; Thu, 21 Nov 2019 13:09:24 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5744523D; Thu, 21 Nov 2019 13:09:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 04:09:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="205052237" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.92]) ([10.237.220.92]) by fmsmga008.fm.intel.com with ESMTP; 21 Nov 2019 04:09:18 -0800 To: Ferruh Yigit , Maxime Coquelin , Tiwei Bie , dev@dpdk.org, zhihong.wang@intel.com, David Marchand Cc: stable@dpdk.org References: <20191119071224.25816-1-tiwei.bie@intel.com> <67a72d5e-7682-d8f5-42ad-2f533521c1c2@intel.com> From: "Burakov, Anatoly" Message-ID: <2beaa964-0f55-ad6f-1bd7-64c16f310192@intel.com> Date: Thu, 21 Nov 2019 12:09:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <67a72d5e-7682-d8f5-42ad-2f533521c1c2@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21-Nov-19 8:58 AM, Ferruh Yigit wrote: > On 11/21/2019 12:55 AM, Maxime Coquelin wrote: >> >> >> On 11/19/19 8:12 AM, Tiwei Bie wrote: >>> The "addr" param has been used since the event callbacks are enabled >>> for external memory. So the "__rte_unused" should be dropped. >>> >>> Besides, slightly refine the coding style by consistently assuming >>> tabs are 8 characters. >>> >>> Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Tiwei Bie >>> --- >>> drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c >>> index a4400e772..ea016e85d 100644 >>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c >>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c >>> @@ -315,9 +315,9 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev) >>> >>> static void >>> virtio_user_mem_event_cb(enum rte_mem_event type __rte_unused, >>> - const void *addr __rte_unused, >>> - size_t len __rte_unused, >>> - void *arg) >>> + const void *addr, >>> + size_t len __rte_unused, >>> + void *arg) >>> { >>> struct virtio_user_dev *dev = arg; >>> struct rte_memseg_list *msl; >>> >> >> Reviewed-by: Maxime Coquelin >> >> David or Ferruh, could you pick it directly? >> I don't plan to prepare a branch as I have this single patch for next >> -rc. > > I can get it, but can you please confirm that it is safe to go to rc4, since > already missed rc3? > Also can you please give your review/ack if you already reviewed. > I don't think there's anything unsafe about removing __rte_unused parameter :) The code itself hasn't changed. -- Thanks, Anatoly