From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E78E3A052A; Tue, 2 Feb 2021 14:07:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77E2A2402B5; Tue, 2 Feb 2021 14:07:05 +0100 (CET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id EF6752402AE for ; Tue, 2 Feb 2021 14:07:03 +0100 (CET) Received: by mail-wm1-f46.google.com with SMTP id f16so2385938wmq.5 for ; Tue, 02 Feb 2021 05:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=23wUCCnzFxxy8+nXQHNDnCGncuZLmtlNg3XEM8jXkBY=; b=vnygpFKdJWLpfX4yfEbIJZ3+5b5nFQlO/9v6PycXRh6oZf5B1Pj8ucC1pZkfKK6Dh1 mi0bvUtHC5wzBgxktZDQjYmW7SgcdYCGf2K5elDyt5dOO+2OJUkuD02v68zx9CuZyi6n wfmmFF2v+D5n11pjkJHjYCOk8bDCuqE8gy6j76Z3z9DGK4ltDFf08C4ZlGFBBetHSJBX i9ZpyOKK+RCLHp8yvMNIi6obSOIxAqpjN0zsDicbayPByTdcY/vMHRMllVrSdxgVlXVG r8woT6WTdf2NC4jLmhIQjT4yvht0Ua1zbM9886a26SkxN0Hybv/PUV5I0Ae2gVLvFJOq 2CKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=23wUCCnzFxxy8+nXQHNDnCGncuZLmtlNg3XEM8jXkBY=; b=bNld1Kw5CTb+0ijVvhpfJIwBnK/fDrqkqR7IE4s7oQ+99lpXefAhrfn4BhIYqQkx0O IlhbK5rWyC24r7tOmumep40ERVfzqmRJJo7AYoMI4PNg2iL+Ot/l1m386xhzz0b0hGKD Amb+E43IfdVZIj4VYgh1QMucwccG0z7IsKcaGo/mMoDcket1Knn1Xnvvdi0OX1cUU/q0 M4okMF2zEmbASN1hvkv5GzOFdv557olX2hy0G+wLvFbJ5hUdnYtIly1bVf9ygrtIRgbR kgnmUoo3ujyjpAhki/X13JkjFOIr1TR3bFfZicJXez2zkOt+yp74ennJHsafG0XQsFPa 2B1A== X-Gm-Message-State: AOAM531gZBKUxq/h4jpga/NhTa0bhBCiQ5lLFyTpfPlN6MAB+x1yL1l6 LiG4kOsBZh2yWATKycMHNWgTooxvssMNhwSn X-Google-Smtp-Source: ABdhPJwSjXkNGc+XT0e2Ljiz09xPsYIKG93sYm8NiC9aCf2bZqsM6Hesx5b7+CaE/6+RK7MZXSaOhg== X-Received: by 2002:a1c:a9ce:: with SMTP id s197mr3664849wme.146.1612271223192; Tue, 02 Feb 2021 05:07:03 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id f17sm33698719wrv.0.2021.02.02.05.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 05:07:02 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Tal Shnaiderman , "dmitry.kozliuk@gmail.com" , "pallavi.kadam@intel.com" , NBU-Contact-Thomas Monjalon Cc: "dev@dpdk.org" References: <20210125170821.11306-1-nick.connolly@mayadata.io> <20210128170435.4304-1-nick.connolly@mayadata.io> Message-ID: <2beeaebb-c4cd-543d-729a-3aea7c14fd47@mayadata.io> Date: Tue, 2 Feb 2021 13:07:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v3] bus/pci: nvme on Windows requires class id and bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tal, >> + /* Convert 4-digit class IDs to 6-digit format */ >> + if (strspn(cp + 4, "0123456789abcdefABCDEF") == 4) > Maybe we can move this format string to a define in the header, something like RTE_PCI_DRV_CLASSID_FMT? > I'll send out a v4 with a definition at the top of pci.c Regards, Nick