DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Michal Krawczyk <mk@semihalf.com>
Cc: dev@dpdk.org, gtzalik@amazon.com, igorch@amazon.com
Subject: Re: [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support
Date: Tue, 22 Sep 2020 13:24:32 +0100
Message-ID: <2bfe634d-e9bd-4e2b-4b73-ebc4c751938f@intel.com> (raw)
In-Reply-To: <20200917100202.52455f14@hermes.lan>

On 9/17/2020 6:02 PM, Stephen Hemminger wrote:
> On Thu, 17 Sep 2020 07:30:15 +0200
> Michal Krawczyk <mk@semihalf.com> wrote:
> 
>> Hi,
>>
>> this patchset contains upgrade of the of the HAL, which, beside some fixes, also
>> adds possibility for reading ENI metrics from the device.
>>
>> Those are further exposed to the DPDK applicaiton using xstats.
>>
>> As it's an extra call to the admin queue during a PMD runtime, for multithread
>> safet the locks had to be added around those functions.
>>
>> Michal Krawczyk (20):
>>    net/ena/base: use min/max macros with type conversion
>>    net/ena/base: specify operations of rte_delay
>>    net/ena/base: support 'resource busy' admin status
>>    net/ena/base: exponential delay in polling functions
>>    net/ena/base: fix release of wait event
>>    net/ena/base: remove MMIOWB_NOT_DEFINED ifdef
>>    net/ena/base: rework setup of accelerated LLQ mode
>>    net/ena/base: add ENI stats
>>    net/ena/base: split RSS function and hash getters
>>    net/ena/base: do not use hardcoded RSS key buffer size
>>    net/ena/base: check for RSS key configuration support
>>    net/ena/base: minor style adjustments
>>    net/ena/base: add missing unlikely
>>    net/ena/base: store admin stats as u64
>>    net/ena/base: add check for meta desc being NULL
>>    net/ena/base: convert values to u32 before shifting
>>    net/ena/base: simplify loop copying Rx descs
>>    net/ena/base: update generation date and commit
>>    net/ena: lock dynamic usages of the admin queue
>>    net/ena: expose ENI stats as additional xstats
>>
>>   drivers/net/ena/base/ena_com.c                | 137 ++++++++++++------
>>   drivers/net/ena/base/ena_com.h                |  57 ++++++--
>>   .../net/ena/base/ena_defs/ena_admin_defs.h    |  56 ++++++-
>>   .../net/ena/base/ena_defs/ena_eth_io_defs.h   |   3 +-
>>   drivers/net/ena/base/ena_defs/ena_gen_info.h  |   5 +-
>>   drivers/net/ena/base/ena_defs/ena_regs_defs.h |   3 +-
>>   drivers/net/ena/base/ena_eth_com.c            |  34 +++--
>>   drivers/net/ena/base/ena_eth_com.h            |   2 +-
>>   drivers/net/ena/base/ena_plat_dpdk.h          |  19 ++-
>>   drivers/net/ena/ena_ethdev.c                  |  86 ++++++++++-
>>   drivers/net/ena/ena_ethdev.h                  |  34 +++++
>>   11 files changed, 344 insertions(+), 92 deletions(-)
>>
> 
> Looks good
> 
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
> 

Series applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2020-09-22 12:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  5:30 Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 01/20] net/ena/base: use min/max macros with type conversion Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 02/20] net/ena/base: specify operations of rte_delay Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 03/20] net/ena/base: support 'resource busy' admin status Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 04/20] net/ena/base: exponential delay in polling functions Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 05/20] net/ena/base: fix release of wait event Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 06/20] net/ena/base: remove MMIOWB_NOT_DEFINED ifdef Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 07/20] net/ena/base: rework setup of accelerated LLQ mode Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 08/20] net/ena/base: add ENI stats Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 09/20] net/ena/base: split RSS function and hash getters Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 10/20] net/ena/base: do not use hardcoded RSS key buffer size Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 11/20] net/ena/base: check for RSS key configuration support Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 12/20] net/ena/base: minor style adjustments Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 13/20] net/ena/base: add missing unlikely Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 14/20] net/ena/base: store admin stats as u64 Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 15/20] net/ena/base: add check for meta desc being NULL Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 16/20] net/ena/base: convert values to u32 before shifting Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 17/20] net/ena/base: simplify loop copying Rx descs Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 18/20] net/ena/base: update generation date and commit Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 19/20] net/ena: lock dynamic usages of the admin queue Michal Krawczyk
2020-09-17  5:30 ` [dpdk-dev] [PATCH 20/20] net/ena: expose ENI stats as additional xstats Michal Krawczyk
2020-09-17 17:02 ` [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support Stephen Hemminger
2020-09-22 12:24   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bfe634d-e9bd-4e2b-4b73-ebc4c751938f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mk@semihalf.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git