From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/thunderx: check data offset alignment requirement
Date: Mon, 6 Mar 2017 11:00:01 +0530 [thread overview]
Message-ID: <2c0a5f47-3015-cdee-8519-1f602fa0240a@nxp.com> (raw)
In-Reply-To: <1488631615-5452-1-git-send-email-jerin.jacob@caviumnetworks.com>
On 3/4/2017 6:16 PM, Jerin Jacob wrote:
> nicvf HW expects the DMA address of the packet data to be
> aligned with cache line size.
>
> Packet data offset is a function of struct mbuf size,
> mbuf private size and headroom. mbuf private size can
> be changed from the application in pool creation, this
> check detects HW alignment requirement constraint in pmd
> start function.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/net/thunderx/nicvf_ethdev.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
> index 1060319..ad7b5d6 100644
> --- a/drivers/net/thunderx/nicvf_ethdev.c
> +++ b/drivers/net/thunderx/nicvf_ethdev.c
> @@ -1410,7 +1410,7 @@ static int
> nicvf_vf_start(struct rte_eth_dev *dev, struct nicvf *nic, uint32_t rbdrsz)
> {
> int ret;
> - uint16_t qidx;
> + uint16_t qidx, data_off;
> uint32_t total_rxq_desc, nb_rbdr_desc, exp_buffs;
> uint64_t mbuf_phys_off = 0;
> struct nicvf_rxq *rxq;
> @@ -1451,10 +1451,17 @@ nicvf_vf_start(struct rte_eth_dev *dev, struct nicvf *nic, uint32_t rbdrsz)
> nic->vf_id, qidx, rxq->pool->name);
> return -ENOMEM;
> }
> - rxq->mbuf_phys_off -= nicvf_mbuff_meta_length(mbuf);
> - rxq->mbuf_phys_off -= RTE_PKTMBUF_HEADROOM;
> + data_off = nicvf_mbuff_meta_length(mbuf);
> + data_off += RTE_PKTMBUF_HEADROOM;
> rte_pktmbuf_free(mbuf);
>
> + if (data_off % RTE_CACHE_LINE_SIZE) {
> + PMD_INIT_LOG(ERR, "unaligned data_offset=%d delta=%d\n",
> + data_off, data_off % RTE_CACHE_LINE_SIZE);
Do you also want to log about the particular pool having this issue?
rxq->pool->name
> + return -EINVAL;
> + }
> + rxq->mbuf_phys_off -= data_off;
> +
> if (mbuf_phys_off == 0)
> mbuf_phys_off = rxq->mbuf_phys_off;
> if (mbuf_phys_off != rxq->mbuf_phys_off) {
>
otherwise, you may add:
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
next prev parent reply other threads:[~2017-03-06 5:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 12:46 Jerin Jacob
2017-03-06 5:30 ` Hemant Agrawal [this message]
2017-03-06 5:32 ` Jerin Jacob
2017-03-13 8:02 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2017-03-14 15:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0a5f47-3015-cdee-8519-1f602fa0240a@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).