From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E568A32A2 for <public@inbox.dpdk.org>; Thu, 24 Oct 2019 13:36:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B75801E559; Thu, 24 Oct 2019 13:36:54 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A2B4A1E550 for <dev@dpdk.org>; Thu, 24 Oct 2019 13:36:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 04:36:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,224,1569308400"; d="scan'208";a="228480880" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga002.fm.intel.com with ESMTP; 24 Oct 2019 04:36:43 -0700 To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Jerin Jacob <jerinjacobk@gmail.com> Cc: dpdk-dev <dev@dpdk.org>, "Akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "anoobj@marvell.com" <anoobj@marvell.com>, "pathreya@marvell.com" <pathreya@marvell.com>, "pkapoor@marvell.com" <pkapoor@marvell.com>, "jerinj@marvell.com" <jerinj@marvell.com>, nd <nd@arm.com> References: <20191012073421.44748-1-jerinj@marvell.com> <VE1PR08MB5149EDA5C5FD3A513B815BEC98680@VE1PR08MB5149.eurprd08.prod.outlook.com> <CALBAE1P5XUyLn-1gDqLsgjFSLVCpgwtO7BM9ZZUCxPMBicAqhw@mail.gmail.com> <VE1PR08MB5149C627B65CB87202BCF29C986B0@VE1PR08MB5149.eurprd08.prod.outlook.com> <CALBAE1Nh2eA907MZgorsD9XnNqC4BEcimE0mXKD_CcWkWD_RHA@mail.gmail.com> <VE1PR08MB51494DDCF1B293A0E2760E64986B0@VE1PR08MB5149.eurprd08.prod.outlook.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <2c19b2aa-413f-329d-f1f8-a2e5396256c9@intel.com> Date: Thu, 24 Oct 2019 12:36:42 +0100 MIME-Version: 1.0 In-Reply-To: <VE1PR08MB51494DDCF1B293A0E2760E64986B0@VE1PR08MB5149.eurprd08.prod.outlook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 10/23/2019 7:17 PM, Honnappa Nagarahalli wrote: >>>> From: Jerin Jacob <jerinj@marvell.com> >>>> >>>> Update the armv8 crypto PMD maintainership. >>>> >>>> https://github.com/caviumnetworks/armv8_crypto external crypto the >>>> library will not be maintained and probably removed soon therefor >>>> updating the PMD documentation to reflect the same. >>>> >>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com> >>>> --- >>>> >>>> This patch is based on the discussion of the following thread >>>> http://mails.dpdk.org/archives/dev/2019-October/146005.html >>>> >>>> In summary, >>>> # ARMv8 crypto PMD depends on an external library owned by Marvell, >>>> specifically crafted to the DPDK performance use case. >>>> # There is no upstream path to this library and it will not be >>>> maintained due to that fact that it >>>> a) Creates fragmentation of the SW >>>> b) Contribution policy concerning external Github Repos >>>> c) None other than Marvell can contribute to this library and this >>>> makes difficult for other stakeholder to use it. >>>> >>>> # As the maintainer, I would like to make forward progress by >>>> providing the following options. None of the options are converging >>>> as the result I would like to step down from the maintainership of >>>> the incomplete PMD as I don't see any options for collaboration, >>>> improvement in the library nor follows the open source philosophy in the >> way it is structured out now. >>>> >>>> option 1) Move external library(BSD-3 license) to dpdk.org so that >>>> every armv8 vendors can contribute, improve and avoid SW >>>> fragmentation and therefore better quality. >>> I do not see any issues with this approach. This patch should be changed to >> reflect this option? >>> >>> >>> >>> >>> >>> In past, there was a concern with this approach about maintaining the >> assembly code in dpdk.org. Is this concern still valid? >>> >>> >>> >>> >>>> >>>> option 2) If option 1 is not possible, remove the incomplete PMD >>>> from dpdk.org and maintain the existing PMD as the external one by each >> vendor. >>>> This won't change much in the existing situation as this PMD is not >>>> standalone and anyway depended on an external code base. >>> IMHO, DPDK defines an interface to integrate an external crypto library. This >> might be under use by applications. Removing the PMD will break those >> applications. >>> >>> >>> >>> DPDK does not define any such interface. It was pushed to external library for >> the reason mentioned above. >>> >>> [Honnappa] So, what should an application which has its own crypto library >> do when the PMD is removed? >>> >>> >>> >>> If no one is ready to host the actual code, how is even possible to have >> floating PMD which can not even build by community. >>> >>> [Honnappa] I am trying to understand your comment. Are you saying without >> the actual crypto library how do we build/test the PMD? >> >> Yes. >> >>> Is it ok to introduce a stub library which is used if >> ‘ARMV8_CRYPTO_LIB_PATH’ is not set. Such stub should not be subjected to >> export license issues. >> >> It won't be even functional. Right? and we really don't know, do we really have >> an export license issue or not? > Agree, stub is to just ensure that the PMD to lib interface is functional. > The export license issue need to be explored. Does this need to go to LF legal? Hi Honnappa, et al, Intel has a serious concern that including crypto code may cause restrictions on Intel contributions, this is under investigation. Also another major concern that, this may limit some consumers/users to access to the dpdk and/or use it. > >> >> Having said that, I have no issues if we choose to go with stub model provided >> this document patch is accepted. > Stub should be the last option, only if we run out of other options as it will preserve only the PMD in DPDK. > IMO, we still have not reached a conclusion. I think following questions need to be answered: > 1) The discussion on whether it should be part of DPDK still not concluded (export license issues should come after this) > 2) What are the export licensing issues in the context of DPDK as an open source project? > 3) Can it be a 'hosted-project' (similar to pkt-gen etc)? > >> >>> >>> >>> >>> I propose to take this to TB to reach to consensus as we are going in circles in >> mailing list. >>> >>> >>> >>> >>> >>> >>>> >>>> I am glad/help to execute option 1 or 2 or help to a new maintainer >>>> if he/she would like to step up and take ownership. >>>> >>>> --- >>>> MAINTAINERS | 1 - >>>> doc/guides/cryptodevs/armv8.rst | 3 +-- >>>> 2 files changed, 1 insertion(+), 3 deletions(-) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS index b02066270..8096d93c4 >>>> 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst >>>> F: doc/guides/cryptodevs/features/ccp.ini >>>> >>>> ARMv8 Crypto >>>> -M: Jerin Jacob <jerinj@marvell.com> >>>> F: drivers/crypto/armv8/ >>>> F: doc/guides/cryptodevs/armv8.rst >>>> F: doc/guides/cryptodevs/features/armv8.ini >>>> diff --git a/doc/guides/cryptodevs/armv8.rst >>>> b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644 >>>> --- a/doc/guides/cryptodevs/armv8.rst >>>> +++ b/doc/guides/cryptodevs/armv8.rst >>>> @@ -28,8 +28,7 @@ Installation >>>> >>>> In order to enable this virtual crypto PMD, user must: >>>> >>>> -* Download ARMv8 crypto library source code from >>>> - `here <https://github.com/caviumnetworks/armv8_crypto>`_ >>>> +* Use ARMv8 crypto library source code from vendor SDK >>>> >>>> * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with >>>> the path where the ``armv8_crypto`` library was downloaded >>>> -- >>>> 2.23.0