From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED5894404F; Wed, 12 Jun 2024 17:26:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86701432F6; Wed, 12 Jun 2024 17:07:09 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 065D54327A for ; Wed, 12 Jun 2024 17:07:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204822; x=1749740822; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aduZupJtrsBXNGsId60nUUOLc0v2fLn9g1ETFZmNUGY=; b=atNQqFigg7VMWx/7xxe9vWgIqYZzblMi3iHXjB4qwdjQmb1qt5ozk0Qb 2vpp/2/Awj09LEwNGF2rejpvfbWlEl7H5giuUYwRgV4TaR2pibhV76lay KgphI1Liv09trxBoGejixp8Xjn87w/auEE6FFUPksJE6OissnOH+QNoHz aCN+e5xhzsGVJ7BwlKS+2RakGAaAJbnidsQAvHziUqJdoomzm+e6Brgi7 pVFlvCSO63+fcqySSkQnx82nokJpciX7yqFuKP9Ajwl38X4qeXrpOrzlP cU0QUuL7sBWaArmk2zuxWqmMPx1tPPUqC4tTRfIf1wazhX7m7Q/uDtCWU A==; X-CSE-ConnectionGUID: sM2d1SMIR8SlaQnzrmSNOw== X-CSE-MsgGUID: FkSyHQdUR3KykEvcf4rugg== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32460123" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32460123" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:07:02 -0700 X-CSE-ConnectionGUID: SlaY+V4wTVaQnasdoRD5Qw== X-CSE-MsgGUID: lQvz+eYqTiO9Yr2FQx6k8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39926008" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:07:01 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Ian Stokes , bruce.richardson@intel.com, Fabio Pricoco Subject: [PATCH v2 134/148] net/ice/base: too big a timeout for QV diagnostic tests Date: Wed, 12 Jun 2024 16:02:08 +0100 Message-ID: <2c2a611ab25f32c52d4fb86c19c924ef1333c738.1718204529.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ian Stokes QV tools are affected by two issues: - Diagnostic tests do not end and cannot be aborted - Celo hangs after tests start Reason is that huge timeout dedicated to FPGA was applied. This patch is adjusting the code to QV compilation flags and use correct timeout. Signed-off-by: Fabio Pricoco Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index df827c26e4..cc84b8a6ec 100644 --- a/drivers/net/ice/base/ice_common.c +++ b/drivers/net/ice/base/ice_common.c @@ -1139,7 +1139,7 @@ void ice_deinit_hw(struct ice_hw *hw) */ int ice_check_reset(struct ice_hw *hw) { - u32 cnt, reg = 0, grst_timeout, uld_mask; + u32 cnt, reg = 0, grst_timeout, uld_mask, reset_wait_cnt; /* Poll for Device Active state in case a recent CORER, GLOBR, * or EMPR has occurred. The grst delay value is in 100ms units. @@ -1170,8 +1170,10 @@ int ice_check_reset(struct ice_hw *hw) uld_mask = ICE_RESET_DONE_MASK; + reset_wait_cnt = ICE_PF_RESET_WAIT_COUNT; + /* Device is Active; check Global Reset processes are done */ - for (cnt = 0; cnt < ICE_PF_RESET_WAIT_COUNT; cnt++) { + for (cnt = 0; cnt < reset_wait_cnt; cnt++) { reg = rd32(hw, GLNVM_ULD) & uld_mask; if (reg == uld_mask) { ice_debug(hw, ICE_DBG_INIT, "Global reset processes done. %d\n", cnt); @@ -1180,7 +1182,7 @@ int ice_check_reset(struct ice_hw *hw) ice_msec_delay(10, true); } - if (cnt == ICE_PF_RESET_WAIT_COUNT) { + if (cnt == reset_wait_cnt) { ice_debug(hw, ICE_DBG_INIT, "Wait for Reset Done timed out. GLNVM_ULD = 0x%x\n", reg); return ICE_ERR_RESET_FAILED; -- 2.43.0