* [dpdk-dev] [PATCH] net/mlx5: fix default set for multicast traffic
@ 2016-10-24 7:59 Raslan Darawsheh
2016-10-28 12:07 ` Adrien Mazarguil
0 siblings, 1 reply; 2+ messages in thread
From: Raslan Darawsheh @ 2016-10-24 7:59 UTC (permalink / raw)
To: dev; +Cc: Raslan Darawsheh, Adrien Mazarguil
Remove non-IPv6 multicast traffic with destination MAC 33:33:* from the
default set when not in promiscuous or allmulticast modes.
Fixes: 0497ddaac511 ("mlx5: add special flows for broadcast and IPv6 multicast")
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
drivers/net/mlx5/mlx5_rxmode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c
index 173e6e8..4ffe703 100644
--- a/drivers/net/mlx5/mlx5_rxmode.c
+++ b/drivers/net/mlx5/mlx5_rxmode.c
@@ -104,7 +104,6 @@ static const struct special_flow_init special_flow_init[] = {
.hash_types =
1 << HASH_RXQ_UDPV6 |
1 << HASH_RXQ_IPV6 |
- 1 << HASH_RXQ_ETH |
0,
.per_vlan = 1,
},
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix default set for multicast traffic
2016-10-24 7:59 [dpdk-dev] [PATCH] net/mlx5: fix default set for multicast traffic Raslan Darawsheh
@ 2016-10-28 12:07 ` Adrien Mazarguil
0 siblings, 0 replies; 2+ messages in thread
From: Adrien Mazarguil @ 2016-10-28 12:07 UTC (permalink / raw)
To: Raslan Darawsheh; +Cc: dev
On Mon, Oct 24, 2016 at 10:59:14AM +0300, Raslan Darawsheh wrote:
> Remove non-IPv6 multicast traffic with destination MAC 33:33:* from the
> default set when not in promiscuous or allmulticast modes.
>
> Fixes: 0497ddaac511 ("mlx5: add special flows for broadcast and IPv6 multicast")
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxmode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c
> index 173e6e8..4ffe703 100644
> --- a/drivers/net/mlx5/mlx5_rxmode.c
> +++ b/drivers/net/mlx5/mlx5_rxmode.c
> @@ -104,7 +104,6 @@ static const struct special_flow_init special_flow_init[] = {
> .hash_types =
> 1 << HASH_RXQ_UDPV6 |
> 1 << HASH_RXQ_IPV6 |
> - 1 << HASH_RXQ_ETH |
> 0,
> .per_vlan = 1,
> },
> --
> 1.9.1
(NACK)
While technically correct, looks like this patch sometimes break IPv6
multicast traffic as well, let's drop it until we figure out the reason.
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-28 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 7:59 [dpdk-dev] [PATCH] net/mlx5: fix default set for multicast traffic Raslan Darawsheh
2016-10-28 12:07 ` Adrien Mazarguil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).