From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F70E42DA9; Wed, 5 Jul 2023 03:33:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0501E40A8B; Wed, 5 Jul 2023 03:33:26 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id A3D23406BC for ; Wed, 5 Jul 2023 03:33:24 +0200 (CEST) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qwht84r4LzMqJY; Wed, 5 Jul 2023 09:30:08 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 09:33:22 +0800 Subject: Re: [PATCH v3] eal: fix prompt info when remap_segment failed To: Fengnan Chang , , CC: References: <20230704121751.92253-1-changfengnan@bytedance.com> From: fengchengwen Message-ID: <2c4141ee-1a38-9290-fe82-85069b49900d@huawei.com> Date: Wed, 5 Jul 2023 09:33:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20230704121751.92253-1-changfengnan@bytedance.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is bugfix, suggest add Cc. With above add, Acked-by: Chengwen Feng On 2023/7/4 20:17, Fengnan Chang wrote: > When there is not enough space to memsegs, we should prompt > which configuration should be modified instead of printing > some numbers. > > Signed-off-by: Fengnan Chang > --- > lib/eal/common/eal_common_dynmem.c | 6 ++---- > lib/eal/freebsd/eal_memory.c | 8 +++----- > lib/eal/linux/eal_memory.c | 11 ++++------- > 3 files changed, 9 insertions(+), 16 deletions(-) > ...