From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AF43A3989 for ; Mon, 30 Jan 2017 12:00:09 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 30 Jan 2017 03:00:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,311,1477983600"; d="scan'208";a="1088859020" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga001.jf.intel.com with ESMTP; 30 Jan 2017 03:00:07 -0800 To: Keith Wiles , dev@dpdk.org References: <20170129021205.36860-1-keith.wiles@intel.com> From: Ferruh Yigit Message-ID: <2c430141-94c1-5482-7fc2-94f5908b41e0@intel.com> Date: Mon, 30 Jan 2017 11:00:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170129021205.36860-1-keith.wiles@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 11:00:10 -0000 On 1/29/2017 2:12 AM, Keith Wiles wrote: > The tap driver setup both rx and tx file descriptors when the > rte_eth_rx_queue_setup() causing the tx to be closed when tx setup > was called. Can you please describe the problem more. Without this patch rx->fd == tx->fd, with this patch rx and tx has different file descriptors. What was the wrong with rx and tx having same fd? As far as I can see, rte_eth_rx_queue_setup() won't close tx->fd, that function will do nothing if rx or tx has valid fd. > > Signed-off-by: Keith Wiles <...>