From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EA90EA04B6;
	Thu, 24 Sep 2020 17:27:02 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 8387F1DDE5;
	Thu, 24 Sep 2020 17:27:01 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 3A4D41DDC9
 for <dev@dpdk.org>; Thu, 24 Sep 2020 17:27:00 +0200 (CEST)
IronPort-SDR: da3YoNSf6fu9SMxVuVRcqMZSnf2Z8cQoVrN57XRctThHZo8GNzuuxunSMEB2cezIGM7qXHqNOL
 4EBbo4078vQg==
X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148991648"
X-IronPort-AV: E=Sophos;i="5.77,298,1596524400"; d="scan'208";a="148991648"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Sep 2020 08:26:59 -0700
IronPort-SDR: wz7S9bwdojYrQ09IN5A7+2BkTarbASgu4BuMMyutJpv2DZrFqTZu0621RmT1jODB5ejnpr8oxR
 NPf9QUmig5UA==
X-IronPort-AV: E=Sophos;i="5.77,298,1596524400"; d="scan'208";a="512204147"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.85.112])
 ([10.251.85.112])
 by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Sep 2020 08:26:58 -0700
To: Phil Yang <Phil.Yang@arm.com>, David Liu <dliu@iol.unh.edu>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "lylavoie@iol.unh.edu"
 <lylavoie@iol.unh.edu>, "thomas@monjalon.net" <thomas@monjalon.net>,
 nd <nd@arm.com>
References: <20200915154208.50383-1-dliu@iol.unh.edu>
 <20200915172740.55178-1-dliu@iol.unh.edu>
 <DB7PR08MB386597C0A07C87C7D5C30D1FE93B0@DB7PR08MB3865.eurprd08.prod.outlook.com>
 <DB7PR08MB386576F77CFBDE9B1485C396E9390@DB7PR08MB3865.eurprd08.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <2c4935de-5b4d-3cf9-2e4d-9757ae502d29@intel.com>
Date: Thu, 24 Sep 2020 16:26:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <DB7PR08MB386576F77CFBDE9B1485C396E9390@DB7PR08MB3865.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom
 display
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/24/2020 11:57 AM, Phil Yang wrote:
> 
> dev <dev-bounces@dpdk.org> On Behalf Of Phil Yang : writes:
> 
> 
>>> Subject: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module
>>> eeprom display
>>>
>>> Add module EEPROM/EEPROM dump command
>>>     "show port <port_id> (module_eeprom|eeprom)"
>>> Commands will dump the content of the EEPROM/module
>>> EEPROM for the selected port.
>>
>>
>> Verified with some popular NICs, it can dump the same info as the Linux
>> ethtool does.
>> This is supported in examples/ethtool as well.
>>
>> Minor nitpick comments inlined.
>>
>> Thanks,
>> Phil
>>
>>>
>>> Signed-off-by: David Liu <dliu@iol.unh.edu>

<...>

> 
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

(empty line above include fixed while merging.)
Applied to dpdk-next-net/main, thanks.