From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E78ADA0096 for ; Thu, 6 Jun 2019 10:49:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 167961B95D; Thu, 6 Jun 2019 10:49:32 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id ADF131B95B for ; Thu, 6 Jun 2019 10:49:30 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id s3so1520749wms.2 for ; Thu, 06 Jun 2019 01:49:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=c60JFm8+VQpuU8EJ4YfAShLO+OwlhYYG8SZ4cbQMVfI=; b=M+u2kO1WFIedg/kAZsgNhePMEAqLUogIEO25CwpS+9xLhuyMrzYOBycQnf01diu0Ha 75bJhGNS09c9p/TKEQygddpb/G2tux/X4wntbQWwaGr/OekHKeSJEv/lTWxX3lt6G0L0 hUQ3iIaan761+Y80lX0auzDUU8TkZ+w3muSC9rpIS5/Yw+6nwlnUop7MhTE1S4iQ0r3o qM5M/RL3s5bQDZoh9nkwm8pvQNIAbgwfc+zRUkWA45YYVeZAlqQcboMJ4fHOEEcFqmAr hjz1h0+LylJICaJSbAKGm+2YHYNfgGh5vn3cTE43ozv/anoelBm/vhVm1rv+/EvCS1eJ +8bw== X-Gm-Message-State: APjAAAVOuH+XDzMhrS8GdiWCzaP2R1o8dypbZuF2YidhaJuHs6ARhbSc UWNUHpzq962ScGA4aoRJihg= X-Google-Smtp-Source: APXvYqxAu/hCH7EaRGjtyu4MG4TjH+2Mtnu1F/83zwbQpb0LduRPmjSTNmQ9uCLQvQTSsFFi3kTkVw== X-Received: by 2002:a1c:f70f:: with SMTP id v15mr25355606wmh.102.1559810970246; Thu, 06 Jun 2019 01:49:30 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p2sm1448028wrx.90.2019.06.06.01.49.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 06 Jun 2019 01:49:28 -0700 (PDT) Message-ID: <2c71e421ff1b2a595956dc799b934df73c878d80.camel@debian.org> From: Luca Boccassi To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" Cc: Satha Koteswara Rao Kottidi , Vamsi Krishna Attunuru Date: Thu, 06 Jun 2019 09:49:27 +0100 In-Reply-To: References: <20190601182030.8282-1-jerinj@marvell.com> <20190601182030.8282-2-jerinj@marvell.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build infra and device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2019-06-06 at 08:32 +0000, Jerin Jacob Kollanukkaran wrote: > > -----Original Message----- > > From: Luca Boccassi < > > bluca@debian.org > > > > > Sent: Monday, June 3, 2019 4:48 PM > > To: Jerin Jacob Kollanukkaran < > > jerinj@marvell.com > > >;=20 > > dev@dpdk.org > >=20 > > Cc: Satha Koteswara Rao Kottidi < > > skoteshwar@marvell.com > > >; Vamsi Krishna > > Attunuru < > > vattunuru@marvell.com > > > > > Subject: Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build > > infra > > and device probe > >=20 > > On Sat, 2019-06-01 at 23:50 +0530,=20 > > jerinj@marvell.com > > wrote: > > > diff --git a/drivers/raw/octeontx2_dma/meson.build > > > b/drivers/raw/octeontx2_dma/meson.build > > > new file mode 100644 > > > index 000000000..1281268aa > > > --- /dev/null > > > +++ b/drivers/raw/octeontx2_dma/meson.build > > > @@ -0,0 +1,18 @@ > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(C) 2019 > > > Marvell > > > +International Ltd. > > > +# > > > + > > > +deps +=3D ['rawdev', 'ring', 'kvargs', 'bus_pci', > > > 'common_octeontx2', > > > 'mempool_octeontx2'] > > > +sources =3D files('otx2_dpi_rawdev.c') > > > + > > > +extra_flags =3D [] > > > +# This integrated controller runs only on a arm64 machine, > > > remove > > > 32bit warnings > > > +if not dpdk_conf.get('RTE_ARCH_64') > > > + extra_flags +=3D ['-Wno-int-to-pointer-cast', '-Wno- > > > pointer-to- > > > int-cast'] > > > +endif > > > + > > > +foreach flag: extra_flags > > > + if cc.has_argument(flag) > > > + cflags +=3D flag > > > + endif > > > +endforeach > >=20 > > If it only works on 64bit, shouldn't the build be disabled for > > 32bit targets? >=20 > We just thought of enabling it for 32bit to _detect_ build regression > for 32bit so > that in future we can run with ILP32 if required. >=20 > If you have strong option on this then we can disable it if required. No it's fine, it was just an observation. --=20 Kind regards, Luca Boccassi