From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13FB642E9C; Mon, 17 Jul 2023 15:23:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F6E740E25; Mon, 17 Jul 2023 15:23:04 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 3775B40698 for ; Mon, 17 Jul 2023 15:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689600183; x=1721136183; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=huv9HcyMamzIAlg/5R2x46xioT3UUThAQex3cTY4VVs=; b=jKQjQJywX/gSaCQ7YZ4fRawXuV4dbr7olexWUnVPRV2+N1aG1YSs9Qv+ mvJp7u6mJOIDBVg8dSB/Na921u99sjP+PvwT/KG9n8Arwoq33MADvXAKH jWjfKtbFx4KobM/fjJex7TuufBpdnOllOrNyRZ8sdJFWF/nMFvVnsVfr/ jXIarPVDuGqBhtcwZGHnbGeFSi5haqpezMkVC7gtPOo2E6PpU5CHU1Sl/ fYhPy5erNHxCIgjXDAu43udQMgcauu7+qztbHmJALUC6JHQqQImdAlDzp PRqaTwaHgGGdtLJe1zRDcBvVKg3j0ijBlQEYFW825KrMJbY7dcLIcC22o A==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="368570741" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="368570741" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 06:22:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="847284358" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="847284358" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2023 06:22:50 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 06:22:49 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 17 Jul 2023 06:22:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 17 Jul 2023 06:22:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkZVKXlcpkRXpMqg3d7UcEl6hXdmIjug8CqKGIRGffo8uBQGVQGOk7DtQyB+ORiotdDanzTjHAubCSjiM1wHONJbMStOAzvcn9RGNhUis8mHWc4oMRCO8t1DDuMS6tD7zfuil8MS+lhLHHXfojz9AIEk+UPXpJB0p0udbQnt9WMVFWw5ESXDryS/h9A6NXUI5Ss+CkyCoPQwj1nE2ehGuKmocYyiMTFbR9deAFLDdmw2k6d/9Y5ItiU3mjV8x7tLP8X5MtSVxiaMxSPVui6MVJYiYbQZzlw2v/jVz3zWQKZWJLu1HvbN6BbD45phhwcTiAzAvCGQjT71M6Mng8gC1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/98R6PhBlQ4EhG/Pq5V+DETU4TLib9B28UDUfnIaCyc=; b=jQA5MIu3c2r9VcYh61U7awMCHzQ5uTZoO23nQODp5OZEclFmypL5TF5SxQjx9nrtzylsUxAEXr26q+EXQ0xyGwo7HkXeYbqyymHejApMy0UTWg97S4hHYK5ryg7/UT7dN7B92uf+lyJyx6sLxADS3EzxmfMmKBQp4blB+wNoR849DYvCFeec7SYUQjVSht7d3KVwFzO1cbVIQ8/7fb/EhoRY39mOjFkDGclRUu1Zhrb13BT0U4Bejj4XX0eXghwub+3I1iRfGKi2m+firxUSTA2gQa8ozTpiGM7qpuZ+Gn2LvM9xb41Yf7C+CbPgXPo6ZdxbVqAiPxdSlJkCoRlTLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CH0PR11MB5332.namprd11.prod.outlook.com (2603:10b6:610:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Mon, 17 Jul 2023 13:22:34 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::d0ad:26fd:7bc2:4487]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::d0ad:26fd:7bc2:4487%3]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 13:22:34 +0000 Message-ID: <2c76da7d-4369-d9d3-e7e1-1b4aca95681c@intel.com> Date: Mon, 17 Jul 2023 14:22:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v16 2/6] test/memarea: support memarea test Content-Language: en-US To: Chengwen Feng , , CC: , , , , , References: <20220721044648.6817-1-fengchengwen@huawei.com> <20230710064923.19849-1-fengchengwen@huawei.com> <20230710064923.19849-3-fengchengwen@huawei.com> From: "Burakov, Anatoly" In-Reply-To: <20230710064923.19849-3-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0067.eurprd04.prod.outlook.com (2603:10a6:10:232::12) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CH0PR11MB5332:EE_ X-MS-Office365-Filtering-Correlation-Id: 120277c1-3afb-4dbe-c9bc-08db86c8e184 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tQVYDAD4WLNVDWpmwXVM2jHE3inc/Ekd753WGZEewpsD7VGrLoRjmW3DzkSOAipqCgFaDxHmDwNhOtN2Qzbnn/rG+SNuURpucO28HVfcgGf0Ipsuz2MtSkSh1AOd8XGKZ6z1w64N/uhnQCI+351O7koEbYNSNpgMN76wXvRdaYhVQyxasQUo9Ip2ZK/lxKneUHMCJVCLW5yDtKWVUle5cwZwOTm4LnxX1BhST4fcrDSNHp4QVI+NwiuLzJ3pCmL3/IChXb+jyTPb7d3ZnpzC67GltD7sNwD71BwoQczRfca9y+H6kq3889x+SxIlpFauRyBfCPFH/8h7vhJ/PA1SXmzK6JQ21OmZNvME938YIo6AGdqM1nDbLmUg5IacaLAskKaaESlmRsDpRbz3wZNZS4xcP1s/8PpE+FGccQTabQQ7gS+mrvMAXowxTjlZCPS8zK9rdoMJC3E3YkevsoqRQu+/GVuzRHE74BPtILivlwWXryc4weUTjqX7un861q0glSqIVcslF5bIAtt+B2HlGqW40FbFRRRj47D233ivoWbq6//DenUiynikO1EEuj9/1ro3MiPnK7hvPxYkeaqMK3unqY1g4/C7fLnjSX+tC/OziodnPyrBd3igOxK9yC/pktP5uzisoSywkDYz+QZikw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(136003)(376002)(346002)(366004)(451199021)(478600001)(66946007)(66556008)(66476007)(4326008)(5660300002)(316002)(8936002)(2906002)(8676002)(41300700001)(6666004)(31686004)(6512007)(6506007)(6486002)(26005)(53546011)(82960400001)(38100700002)(186003)(66574015)(2616005)(36756003)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWh1eDVrK0s5Q1IzY0s2YUJSQjEwQ01QajFvUTJuRHhaSXR1QWdVQkNZSEpq?= =?utf-8?B?a2h0SHVweG0wMkxUZDd5cHgwbWhCZ0JYTlhmNjJzVXRPblE5TUdmNExERmJx?= =?utf-8?B?WVh1ZE5BRWZYYnNld2hPMzBjMk9ncngvMVF2TWZJS2RlSzNXYkxmSmZobXRz?= =?utf-8?B?Uy9yQzZQdENGUWZ6NTd0REkveW9kUFVRVnNzc0xDanY4ajVSdmh6L2FPVE5n?= =?utf-8?B?d3J0OW1LSWNiRVlUd25RNEFOMGZXN0E0S0hLbS9GSVEyR1FHa3cyR0xvQUJP?= =?utf-8?B?Z29OblA0ek5xK0orNExHckEwOUVxaUJFVXJCeVRuZ1NMOTFRUndkbnBHc2p0?= =?utf-8?B?eU9aZFpwRlVzNzdyRWZtSzFJWmVJYUc4S1UrY0pKQUcwTWRYTHlxK2JkYm9D?= =?utf-8?B?QU4zdFdOdlRvdTZ1dXhMUnhPM0lPQ1lDTGR1VVBTVktKMmJZWldaT1pwUFhM?= =?utf-8?B?V0ZKUzk0SitzMzQ5MncrYVRhMXdvU3VOQjJLTFVDd2NkYU9YV2VIdzdjRVZZ?= =?utf-8?B?U2dCZkVuVGc3ek9FV0xPOHRtaXVmbjVjREVRUHpTejVaMG1yS1pNczJ6NGVB?= =?utf-8?B?RjEvUVl3bDdydDJNbG81TDBmVE9KSmJsV1FPUmk3SDN6b0UzT3ZRc0hYeGdP?= =?utf-8?B?b2xHTFNJNzJMQ0p0NFBPNzN6YVh3MmpmbGcvbEpTMWxUWkt3aHIxeC9qR2ZP?= =?utf-8?B?Sk9yc2ROaW0xa2VWY2hRNVV2RGNheFM2bndqYy9LbWdpanlVTDZ0U1NFeUhj?= =?utf-8?B?cFE4Q0EvcjFFTzFiUTFiRzZ0OUVoVGx0RHduZ04wY0haeUdxWXBHc2VaQ3N3?= =?utf-8?B?QzJ2V2lYK3V0TlhqdXF2dkF3dEhISnowQVdlaGVVTmthQUthVmtOcHdONkpl?= =?utf-8?B?eXVoOHUrVit3RDBQcS9tdW5PeURWa2dQTUcxeFZJUEdYYTNRcXRqMTdxUzcr?= =?utf-8?B?QTZqRndCZmd1ZEJUM1pDSW16aTVwS0hTckM3K3VPVm9QS1lzTmI1T0QwWjg5?= =?utf-8?B?UGc3L0hZWWpSZTZqOUxhSy9leWppOWhSMzY2STd5TmhqVkhOeTRPTHFTMitl?= =?utf-8?B?VUFZV2JQOE80L0MzUzEzT3J4d2F0OGJuN2F2SW5rRTMzb1JzS0Y2cENabDln?= =?utf-8?B?ck52YS80Vkp6N0RPL01jS1RUalJrYnN4NFZLdXFIc3Zub1hiNjlmSUVkUExH?= =?utf-8?B?OGtVYlRoWkN5VDhJekMzdzI5My8rUVpKa2toZ2xmN3o4c0JIWm04YmZQZi9p?= =?utf-8?B?RngxYm8xRlppb2V0UzhDdmlZUXdPb2o0angwakliV2JyMkJwK0tQNDhocU53?= =?utf-8?B?S1lVeDZ4NW5ZdG1DeUFaWFhtM1ZYWTUwaWhudGh6SmhmUFRyVUhFS3VBdDd2?= =?utf-8?B?MElzZnZWU0wySmdXTFMrVUVRSm85UTB4NzE2enJ6WFpnRU9GMS84bytBWHUw?= =?utf-8?B?Rk5VMHNRWGRYVHorYzZKcytKQnVnVzBLOVh6MWtERkJubWhaMXo1MW1DWTA0?= =?utf-8?B?RkpDazNNV29Xa3EzeDlMMnJEZFFBQXF2RnJEdFJQLzdRcnFGYXQxNmVac1NM?= =?utf-8?B?ZW91SjZwTkFSeTVxRGtJVjVrSmNpMFVRNDdLekYwTUUxUHFyMjFHSzJpbEp2?= =?utf-8?B?WXdQZlhONXU1a3JjckdMWGx6blJEUE1IdzMwMVFzSHZHWFNReFo5Y0FzekVq?= =?utf-8?B?WDdzYXg5Z3B4dCtYdnhXa3FMKzZ4bjFYNjZWZzRIRU02UklBc1lHNWYyLzFF?= =?utf-8?B?QllURjMwdFdtVmdHV05YVjB2UjVlUUFUL3lZRDR0bVNVeGlCa2FYNU5nVHRz?= =?utf-8?B?WGcvU1dWQXVjVWJmeXhJd0QzV2lqOVVQc0hFSUJPY011VVBlRHBTb0JlNDhk?= =?utf-8?B?UTBaWDc5M1ZsWEVqMDg1Q09RdHl0RXdKbzNCV2tkblNoRzltaXV2QW1vN2NJ?= =?utf-8?B?Q3VhUHNiQ2FEbFR1Smt1R3RkdmM2R3JRd1h1bVdhdnZVRHJMNG43N20xOGFq?= =?utf-8?B?aSt2WmhLT3BQQXRUbDY4WkxISUgva21qdlNKVkVXdVprV3dZWnFjZ0VLNGhx?= =?utf-8?B?ZzZaS0NMeWxqZCsxWU1EU0lHUUhoZ1ludWswRzlaTzZFYjlZNmhEU3ArejZh?= =?utf-8?B?eG9NQ1IzZ2pkSUtFSk1XTnBKTHhjMHl4aUE5TzlUZm9uZzkzcFlXQlZFckJM?= =?utf-8?B?c3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 120277c1-3afb-4dbe-c9bc-08db86c8e184 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 13:22:33.9610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s4Wnd8wJQI1WEGklfskJBSuU3/L68NqWuan3mpjcsiGoFzWgMPaxj5aJvhhfCCrmCwPCi444pNbgx3nwCN9OfCh3AkOhIoSGdEXlGYJuxIo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5332 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/10/2023 7:49 AM, Chengwen Feng wrote: > This patch supports memarea test of rte_memarea_create() and > rte_memarea_destroy() API. > > Signed-off-by: Chengwen Feng > Reviewed-by: Dongdong Liu > Acked-by: Morten Brørup > --- Hi, > + /* test for create with LIBC */ > + test_memarea_init_param(&init); > + init.source = RTE_MEMAREA_SOURCE_LIBC; > + ma = rte_memarea_create(&init); > + TEST_ASSERT(ma != NULL, "Expected Non-NULL"); > + rte_memarea_destroy(ma); > + > + return 0; Here and in other test functions: I think TEST_SUCCESS would be the semantically correct value to return. > +} > + > +static struct unit_test_suite memarea_test_suite = { > + .suite_name = "Memarea Unit Test Suite", > + .setup = NULL, > + .teardown = NULL, > + .unit_test_cases = { > + TEST_CASE(test_memarea_create_bad_param), > + TEST_CASE(test_memarea_create_destroy), > + > + TEST_CASES_END() /**< NULL terminate unit test array */ > + } > +}; > + > +static int > +test_memarea(void) > +{ > + return unit_test_suite_runner(&memarea_test_suite); > +} > + > +REGISTER_TEST_COMMAND(memarea_autotest, test_memarea); Acked-by: Anatoly Burakov -- Thanks, Anatoly