From: "Kinsella, Ray" <mdr@ashroe.eu> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "jay.jayatheerthan@intel.com" <jay.jayatheerthan@intel.com>, "erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>, "abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>, "timothy.mcdaniel@intel.com" <timothy.mcdaniel@intel.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "harry.van.haaren@intel.com" <harry.van.haaren@intel.com>, "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>, "liang.j.ma@intel.com" <liang.j.ma@intel.com>, Neil Horman <nhorman@tuxdriver.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4 2/8] eventdev: introduce event vector Rx capability Date: Mon, 22 Mar 2021 11:07:04 +0000 Message-ID: <2c7dde74-8a97-11ea-f4f9-019935ce345c@ashroe.eu> (raw) In-Reply-To: <PH0PR18MB408652365B455D27C939F8D5DE659@PH0PR18MB4086.namprd18.prod.outlook.com> On 22/03/2021 10:07, Pavan Nikhilesh Bhagavatula wrote: > >> On 19/03/2021 20:57, pbhagavatula@marvell.com wrote: >>> From: Pavan Nikhilesh <pbhagavatula@marvell.com> >>> >>> Introduce event ethernet Rx adapter event vector capability. >>> >>> If an event eth Rx adapter has the capability of >>> RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx >> queue >>> can be configured to enable event vectorization by passing the >>> flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR to >>> rte_event_eth_rx_adapter_queue_conf::rx_queue_flags while >> configuring >>> Rx adapter through rte_event_eth_rx_adapter_queue_add. >>> >>> The max vector size, vector timeout define the vector size and >>> mempool used for allocating vector event are configured through >>> rte_event_eth_rx_adapter_queue_add. The element size of the >> element >>> in the vector pool should be equal to >>> sizeof(struct rte_event_vector) + (vector_sz * sizeof(uintptr_t)) >>> >>> Application can use `rte_event_vector_pool_create` to create the >>> vector mempool used for >>> rte_event_eth_rx_adapter_queue_conf::vector_mp. >>> >>> The Rx adapter would be responsible for vectorizing the mbufs >>> based on the flow, the vector limits configured by the application >>> and add the vector event of mbufs to the event queue set via >>> rte_event_eth_rx_adapter_queue_conf::ev::queue_id. >>> It should also mark rte_event_vector::union_valid and fill >>> rte_event_vector::port, rte_event_vector::queue. >>> >>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> >>> --- >>> .../prog_guide/event_ethernet_rx_adapter.rst | 38 ++++++++ >>> .../rte_event_eth_rx_adapter.h | 95 +++++++++++++++++++ >>> lib/librte_eventdev/rte_eventdev.h | 30 +++++- >>> lib/librte_eventdev/version.map | 2 + >>> 4 files changed, 163 insertions(+), 2 deletions(-) >>> >> >> Seems strange that you add the forward declaration of the symbol, >> and you also detail the symbol in the map file, indicating how the >> symbol should be treated. > > I wanted to have only spec change here to make it easier for review, > the actual implementation is in [4/8]. > >> >> But the patch is missing the symbol implementation itself, it should be >> here right? >> > > I will add a skeleton implementation here. perfect. > >> >
next prev parent reply other threads:[~2021-03-22 11:07 UTC|newest] Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-20 22:09 [dpdk-dev] [PATCH 0/7] Introduce event vectorization pbhagavatula 2021-02-20 22:09 ` [dpdk-dev] [PATCH 1/7] eventdev: introduce event vector capability pbhagavatula 2021-03-08 16:49 ` Jerin Jacob 2021-02-20 22:09 ` [dpdk-dev] [PATCH 2/7] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-08 17:07 ` Jerin Jacob 2021-02-20 22:09 ` [dpdk-dev] [PATCH 3/7] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-08 17:09 ` Jerin Jacob 2021-02-20 22:09 ` [dpdk-dev] [PATCH 4/7] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-08 17:27 ` Jerin Jacob 2021-03-16 10:41 ` Jayatheerthan, Jay 2021-02-20 22:09 ` [dpdk-dev] [PATCH 5/7] eventdev: add Tx " pbhagavatula 2021-02-20 22:09 ` [dpdk-dev] [PATCH 6/7] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-02-20 22:09 ` [dpdk-dev] [PATCH 7/7] eventdev: fix ABI breakage due to event vector pbhagavatula 2021-03-08 18:44 ` Jerin Jacob 2021-03-12 14:28 ` David Marchand 2021-03-16 5:54 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2021-03-15 10:01 ` [dpdk-dev] " Kinsella, Ray 2021-03-08 16:41 ` [dpdk-dev] [PATCH 0/7] Introduce event vectorization Jerin Jacob 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 0/8] " pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-16 17:48 ` Jerin Jacob 2021-03-16 19:17 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 5/8] eventdev: add Tx " pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-16 15:48 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v2 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 0/8] Introduce event vectorization pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-18 6:19 ` Jayatheerthan, Jay 2021-03-18 6:23 ` Pavan Nikhilesh Bhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 5/8] eventdev: add Tx " pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [PATCH v3 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-16 20:01 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v3 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 0/8] Introduce event vectorization pbhagavatula 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-22 9:06 ` Kinsella, Ray 2021-03-22 9:10 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2021-03-23 11:12 ` [dpdk-dev] " Jerin Jacob 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-22 9:12 ` Kinsella, Ray 2021-03-22 10:07 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2021-03-22 11:07 ` Kinsella, Ray [this message] 2021-03-23 16:56 ` [dpdk-dev] " Jerin Jacob 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-23 18:30 ` Jerin Jacob 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 5/8] eventdev: add Tx " pbhagavatula 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-23 18:39 ` Jerin Jacob 2021-03-19 20:57 ` [dpdk-dev] [PATCH v4 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-19 20:57 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v4 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-23 18:44 ` [dpdk-dev] [PATCH v4 0/8] Introduce event vectorization Jerin Jacob 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 " pbhagavatula 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-24 6:48 ` Jayatheerthan, Jay 2021-03-24 18:20 ` Pavan Nikhilesh Bhagavatula 2021-03-24 9:16 ` Kinsella, Ray 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-24 9:15 ` Kinsella, Ray 2021-03-25 8:15 ` Jayatheerthan, Jay 2021-03-25 9:24 ` Pavan Nikhilesh Bhagavatula 2021-03-25 9:50 ` Jayatheerthan, Jay 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-25 8:16 ` Jayatheerthan, Jay 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-25 10:37 ` Jayatheerthan, Jay 2021-03-25 13:14 ` Pavan Nikhilesh Bhagavatula 2021-03-26 6:26 ` Jayatheerthan, Jay 2021-03-26 9:00 ` Pavan Nikhilesh Bhagavatula 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 5/8] eventdev: add Tx " pbhagavatula 2021-03-25 11:44 ` Jayatheerthan, Jay 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-24 5:05 ` [dpdk-dev] [PATCH v5 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-24 9:16 ` Kinsella, Ray 2021-03-24 5:05 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v5 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-25 12:27 ` Jayatheerthan, Jay 2021-03-25 13:55 ` Pavan Nikhilesh Bhagavatula 2021-03-26 7:09 ` Jayatheerthan, Jay 2021-03-26 9:44 ` Pavan Nikhilesh Bhagavatula 2021-03-24 5:39 ` [dpdk-dev] [PATCH v5 0/8] Introduce event vectorization Jayatheerthan, Jay 2021-03-24 6:44 ` Pavan Nikhilesh Bhagavatula 2021-03-24 8:10 ` Jayatheerthan, Jay 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 " pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 5/8] eventdev: add Tx " pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [PATCH v6 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-24 19:28 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v6 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 0/8] Introduce event vectorization pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 5/8] eventdev: add Tx " pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [PATCH v7 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-25 17:10 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v7 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 0/8] Introduce event vectorization pbhagavatula 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-27 12:07 ` Jayatheerthan, Jay 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-28 8:18 ` Jerin Jacob 2021-03-29 6:09 ` Jayatheerthan, Jay 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 5/8] eventdev: add Tx " pbhagavatula 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-26 14:08 ` [dpdk-dev] [PATCH v8 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-26 14:43 ` Jerin Jacob 2021-03-27 12:07 ` Jayatheerthan, Jay 2021-03-26 14:08 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v8 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 0/8] Introduce event vectorization pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-31 6:35 ` Jayatheerthan, Jay 2021-03-31 6:40 ` Pavan Nikhilesh Bhagavatula 2021-03-31 6:55 ` Jayatheerthan, Jay 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 5/8] eventdev: add Tx " pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [PATCH v9 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-30 8:22 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v9 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-03-31 6:55 ` Jayatheerthan, Jay 2021-03-31 9:29 ` [dpdk-dev] [PATCH v10 0/8] Introduce event vectorization pbhagavatula 2021-03-31 9:29 ` [dpdk-dev] [PATCH v10 1/8] eventdev: introduce event vector capability pbhagavatula 2021-03-31 9:29 ` [dpdk-dev] [PATCH v10 2/8] eventdev: introduce event vector Rx capability pbhagavatula 2021-03-31 9:29 ` [dpdk-dev] [PATCH v10 3/8] eventdev: introduce event vector Tx capability pbhagavatula 2021-03-31 9:29 ` [dpdk-dev] [PATCH v10 4/8] eventdev: add Rx adapter event vector support pbhagavatula 2021-03-31 9:29 ` [dpdk-dev] [PATCH v10 5/8] eventdev: add Tx " pbhagavatula 2021-03-31 9:30 ` [dpdk-dev] [PATCH v10 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula 2021-03-31 9:30 ` [dpdk-dev] [PATCH v10 7/8] doc: announce event Rx adapter config changes pbhagavatula 2021-03-31 9:30 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v10 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula 2021-08-18 4:56 ` [dpdk-dev] [PATCH v11] " pbhagavatula 2021-08-18 4:59 ` [dpdk-dev] [PATCH v12] " pbhagavatula 2021-08-18 6:57 ` [dpdk-dev] [PATCH v13] " pbhagavatula 2021-08-18 8:22 ` Jayatheerthan, Jay 2021-08-20 7:33 ` Naga Harish K, S V 2021-09-07 8:30 ` Jerin Jacob 2021-09-15 13:15 ` [dpdk-dev] [PATCH v14] " pbhagavatula 2021-09-15 13:18 ` Kinsella, Ray 2021-09-16 4:28 ` Jerin Jacob 2021-04-03 9:44 ` [dpdk-dev] [PATCH v10 0/8] Introduce event vectorization Jerin Jacob
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2c7dde74-8a97-11ea-f4f9-019935ce345c@ashroe.eu \ --to=mdr@ashroe.eu \ --cc=abhinandan.gujjar@intel.com \ --cc=dev@dpdk.org \ --cc=erik.g.carrillo@intel.com \ --cc=harry.van.haaren@intel.com \ --cc=hemant.agrawal@nxp.com \ --cc=jay.jayatheerthan@intel.com \ --cc=jerinj@marvell.com \ --cc=liang.j.ma@intel.com \ --cc=mattias.ronnblom@ericsson.com \ --cc=nhorman@tuxdriver.com \ --cc=pbhagavatula@marvell.com \ --cc=timothy.mcdaniel@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git