From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9876CA034F; Mon, 22 Mar 2021 12:07:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1783540042; Mon, 22 Mar 2021 12:07:17 +0100 (CET) Received: from mail-109-mta81.mxroute.com (mail-109-mta81.mxroute.com [136.175.109.81]) by mails.dpdk.org (Postfix) with ESMTP id ADC5940040 for ; Mon, 22 Mar 2021 12:07:14 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta81.mxroute.com (ZoneMTA) with ESMTPSA id 178599dfc640004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 22 Mar 2021 11:07:09 +0000 X-Zone-Loop: c147980bd772c0a883d42e4a1180ffa5230551ab402e X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kGM7lqB3GnuN9Xmr4aBW7SAqoQJWa7BJvMxu/j4zdxQ=; b=bApa3ym9XZCCcK9cTc+dYGAiWq IFrrLhHi3eZIVbSApvGvasgj5/XZerujOwiHwdkoKyK+FoDu+/PsVBDV3MNbbwC69NX2xB75QMC3q nw0wT44utrFeyqmnQdQv/OUy94caRryXb0tyOctNKScYFF2JdkdcUjhrR/Sbq+18YI38frveHxsli fH+vS1vofGDYU0qApMCrYPUMRlr/+CUauRScYYC97i7WbPeVbpz5GZuBVI2Zz4IX0qda2HIkI26Em IEZGY2l0AKFiMkriooCReWzU+zy4XmSqpSl9oWXptm11Sd6T8xebM+1M9Txl/PPeGIkm4XSp3Oldw TaDKhOHA==; To: Pavan Nikhilesh Bhagavatula , Jerin Jacob Kollanukkaran , "jay.jayatheerthan@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" , "timothy.mcdaniel@intel.com" , "hemant.agrawal@nxp.com" , "harry.van.haaren@intel.com" , "mattias.ronnblom@ericsson.com" , "liang.j.ma@intel.com" , Neil Horman Cc: "dev@dpdk.org" References: <20210316200156.252-1-pbhagavatula@marvell.com> <20210319205718.1436-1-pbhagavatula@marvell.com> <20210319205718.1436-3-pbhagavatula@marvell.com> From: "Kinsella, Ray" Message-ID: <2c7dde74-8a97-11ea-f4f9-019935ce345c@ashroe.eu> Date: Mon, 22 Mar 2021 11:07:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4 2/8] eventdev: introduce event vector Rx capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22/03/2021 10:07, Pavan Nikhilesh Bhagavatula wrote: > >> On 19/03/2021 20:57, pbhagavatula@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Introduce event ethernet Rx adapter event vector capability. >>> >>> If an event eth Rx adapter has the capability of >>> RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx >> queue >>> can be configured to enable event vectorization by passing the >>> flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR to >>> rte_event_eth_rx_adapter_queue_conf::rx_queue_flags while >> configuring >>> Rx adapter through rte_event_eth_rx_adapter_queue_add. >>> >>> The max vector size, vector timeout define the vector size and >>> mempool used for allocating vector event are configured through >>> rte_event_eth_rx_adapter_queue_add. The element size of the >> element >>> in the vector pool should be equal to >>> sizeof(struct rte_event_vector) + (vector_sz * sizeof(uintptr_t)) >>> >>> Application can use `rte_event_vector_pool_create` to create the >>> vector mempool used for >>> rte_event_eth_rx_adapter_queue_conf::vector_mp. >>> >>> The Rx adapter would be responsible for vectorizing the mbufs >>> based on the flow, the vector limits configured by the application >>> and add the vector event of mbufs to the event queue set via >>> rte_event_eth_rx_adapter_queue_conf::ev::queue_id. >>> It should also mark rte_event_vector::union_valid and fill >>> rte_event_vector::port, rte_event_vector::queue. >>> >>> Signed-off-by: Pavan Nikhilesh >>> --- >>> .../prog_guide/event_ethernet_rx_adapter.rst | 38 ++++++++ >>> .../rte_event_eth_rx_adapter.h | 95 +++++++++++++++++++ >>> lib/librte_eventdev/rte_eventdev.h | 30 +++++- >>> lib/librte_eventdev/version.map | 2 + >>> 4 files changed, 163 insertions(+), 2 deletions(-) >>> >> >> Seems strange that you add the forward declaration of the symbol, >> and you also detail the symbol in the map file, indicating how the >> symbol should be treated. > > I wanted to have only spec change here to make it easier for review, > the actual implementation is in [4/8]. > >> >> But the patch is missing the symbol implementation itself, it should be >> here right? >> > > I will add a skeleton implementation here. perfect. > >> >