DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Liu, Yong" <yong.liu@intel.com>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	"Wang, Zhihong" <zhihong.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost add vectorized data path
Date: Thu, 15 Oct 2020 17:35:19 +0200
Message-ID: <2c9a8c71-eaa3-f405-c315-300c6234e56e@redhat.com> (raw)
In-Reply-To: <6c634a226f7e48cbbca3d9091f68eea0@intel.com>

Hi Marvin,

On 10/15/20 5:28 PM, Liu, Yong wrote:
> Hi All,
> Performance gain from vectorized datapath in OVS-DPDK is around 1%, meanwhile it have a small impact of original datapath. 
> On the other hand, it will increase the complexity of vhost (new parameter introduced, prepare memory information for address translation). 
> After weighed the procs and co, I’d like to drawback this patch set.  Thanks for your time.

Thanks for running the test with the new version.
I have removed it from Patchwork.

Thanks,
Maxime

> Regards,
> Marvin
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Monday, October 12, 2020 4:22 PM
>> To: Liu, Yong <yong.liu@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>;
>> Wang, Zhihong <zhihong.wang@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [PATCH v3 0/5] vhost add vectorized data path
>>
>> Hi Marvin,
>>
>> On 10/9/20 10:14 AM, Marvin Liu wrote:
>>> Packed ring format is imported since virtio spec 1.1. All descriptors
>>> are compacted into one single ring when packed ring format is on. It is
>>> straight forward that ring operations can be accelerated by utilizing
>>> SIMD instructions.
>>>
>>> This patch set will introduce vectorized data path in vhost library. If
>>> vectorized option is on, operations like descs check, descs writeback,
>>> address translation will be accelerated by SIMD instructions. On skylake
>>> server, it can bring 6% performance gain in loopback case and around 4%
>>> performance gain in PvP case.
>>
>> IMHO, 4% gain on PVP is not a significant gain if we compare to the
>> added complexity. Moreover, I guess this is 4% gain with testpmd-based
>> PVP? If this is the case it may be even lower with OVS-DPDK PVP
>> benchmark, I will try to do a benchmark this week.
>>
>> Thanks,
>> Maxime
>>
>>> Vhost application can choose whether using vectorized acceleration, just
>>> like external buffer feature. If platform or ring format not support
>>> vectorized function, vhost will fallback to use default batch function.
>>> There will be no impact in current data path.
>>>
>>> v3:
>>> * rename vectorized datapath file
>>> * eliminate the impact when avx512 disabled
>>> * dynamically allocate memory regions structure
>>> * remove unlikely hint for in_order
>>>
>>> v2:
>>> * add vIOMMU support
>>> * add dequeue offloading
>>> * rebase code
>>>
>>> Marvin Liu (5):
>>>   vhost: add vectorized data path
>>>   vhost: reuse packed ring functions
>>>   vhost: prepare memory regions addresses
>>>   vhost: add packed ring vectorized dequeue
>>>   vhost: add packed ring vectorized enqueue
>>>
>>>  doc/guides/nics/vhost.rst           |   5 +
>>>  doc/guides/prog_guide/vhost_lib.rst |  12 +
>>>  drivers/net/vhost/rte_eth_vhost.c   |  17 +-
>>>  lib/librte_vhost/meson.build        |  16 ++
>>>  lib/librte_vhost/rte_vhost.h        |   1 +
>>>  lib/librte_vhost/socket.c           |   5 +
>>>  lib/librte_vhost/vhost.c            |  11 +
>>>  lib/librte_vhost/vhost.h            | 239 +++++++++++++++++++
>>>  lib/librte_vhost/vhost_user.c       |  26 +++
>>>  lib/librte_vhost/virtio_net.c       | 258 ++++-----------------
>>>  lib/librte_vhost/virtio_net_avx.c   | 344 ++++++++++++++++++++++++++++
>>>  11 files changed, 718 insertions(+), 216 deletions(-)
>>>  create mode 100644 lib/librte_vhost/virtio_net_avx.c
>>>
> 


  reply	other threads:[~2020-10-15 15:35 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  3:24 [dpdk-dev] [PATCH v1 " Marvin Liu
2020-08-19  3:24 ` [dpdk-dev] [PATCH v1 1/5] vhost: " Marvin Liu
2020-09-21  6:48   ` [dpdk-dev] [PATCH v2 0/5] vhost " Marvin Liu
2020-09-21  6:48     ` [dpdk-dev] [PATCH v2 1/5] vhost: " Marvin Liu
2020-09-21  6:48     ` [dpdk-dev] [PATCH v2 2/5] vhost: reuse packed ring functions Marvin Liu
2020-09-21  6:48     ` [dpdk-dev] [PATCH v2 3/5] vhost: prepare memory regions addresses Marvin Liu
2020-10-06 15:06       ` Maxime Coquelin
2020-09-21  6:48     ` [dpdk-dev] [PATCH v2 4/5] vhost: add packed ring vectorized dequeue Marvin Liu
2020-10-06 14:59       ` Maxime Coquelin
2020-10-08  7:05         ` Liu, Yong
2020-10-06 15:18       ` Maxime Coquelin
2020-10-09  7:59         ` Liu, Yong
2020-09-21  6:48     ` [dpdk-dev] [PATCH v2 5/5] vhost: add packed ring vectorized enqueue Marvin Liu
2020-10-06 15:00       ` Maxime Coquelin
2020-10-08  7:09         ` Liu, Yong
2020-10-06 13:34     ` [dpdk-dev] [PATCH v2 0/5] vhost add vectorized data path Maxime Coquelin
2020-10-08  6:20       ` Liu, Yong
2020-10-09  8:14   ` [dpdk-dev] [PATCH v3 " Marvin Liu
2020-10-09  8:14     ` [dpdk-dev] [PATCH v3 1/5] vhost: " Marvin Liu
2020-10-09  8:14     ` [dpdk-dev] [PATCH v3 2/5] vhost: reuse packed ring functions Marvin Liu
2020-10-09  8:14     ` [dpdk-dev] [PATCH v3 3/5] vhost: prepare memory regions addresses Marvin Liu
2020-10-09  8:14     ` [dpdk-dev] [PATCH v3 4/5] vhost: add packed ring vectorized dequeue Marvin Liu
2020-10-09  8:14     ` [dpdk-dev] [PATCH v3 5/5] vhost: add packed ring vectorized enqueue Marvin Liu
2020-10-12  8:21     ` [dpdk-dev] [PATCH v3 0/5] vhost add vectorized data path Maxime Coquelin
2020-10-12  9:10       ` Liu, Yong
2020-10-12  9:57         ` Maxime Coquelin
2020-10-12 13:24           ` Liu, Yong
2020-10-15 15:28       ` Liu, Yong
2020-10-15 15:35         ` Maxime Coquelin [this message]
2020-08-19  3:24 ` [dpdk-dev] [PATCH v1 2/5] vhost: reuse packed ring functions Marvin Liu
2020-08-19  3:24 ` [dpdk-dev] [PATCH v1 3/5] vhost: prepare memory regions addresses Marvin Liu
2020-08-19  3:24 ` [dpdk-dev] [PATCH v1 4/5] vhost: add packed ring vectorized dequeue Marvin Liu
2020-09-18 13:44   ` Maxime Coquelin
2020-09-21  6:26     ` Liu, Yong
2020-09-21  7:47       ` Liu, Yong
2020-08-19  3:24 ` [dpdk-dev] [PATCH v1 5/5] vhost: add packed ring vectorized enqueue Marvin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c9a8c71-eaa3-f405-c315-300c6234e56e@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=yong.liu@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git