DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] vhost: allow to check in-flight packets for async vhost
Date: Wed, 7 Jul 2021 11:21:53 +0200	[thread overview]
Message-ID: <2ca10f09-e744-6a85-5e18-7fe1ecaacf08@redhat.com> (raw)
In-Reply-To: <1625658843-89612-1-git-send-email-jiayu.hu@intel.com>



On 7/7/21 1:54 PM, Jiayu Hu wrote:
> This patch allows to check the amount of in-flight packets
> for vhost queues which register async channel acceleration.
> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
> v2:
> * use DEBUG log level
> * return -1 when async is not registered
> 
>  doc/guides/prog_guide/vhost_lib.rst |  5 +++++
>  lib/vhost/rte_vhost_async.h         | 14 ++++++++++++++
>  lib/vhost/version.map               |  3 +++
>  lib/vhost/vhost.c                   | 33 +++++++++++++++++++++++++++++++++
>  4 files changed, 55 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
> index d18fb98..9fdc6d5 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -281,6 +281,11 @@ The following is an overview of some key Vhost API functions:
>    Poll enqueue completion status from async data path. Completed packets
>    are returned to applications through ``pkts``.
>  
> +* ``rte_vhost_async_get_inflight(vid, queue_id)``
> +
> +  This function returns the amount of in-flight packets by now for the
> +  vhost queue which registers async channel acceleration.

What about:

"
This function returns the amount of in-flight packets for the Vhost
queue using async acceleration.
"

Other than that, it looks good to me:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2021-07-07  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 15:05 [dpdk-dev] [PATCH] " Jiayu Hu
2021-06-08 14:30 ` Maxime Coquelin
2021-07-07 11:54 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
2021-07-07  9:21   ` Maxime Coquelin [this message]
2021-07-08 10:21   ` [dpdk-dev] [PATCH v3] " Jiayu Hu
2021-07-20  2:47     ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ca10f09-e744-6a85-5e18-7fe1ecaacf08@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).