From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADA9AA0C4A; Wed, 7 Jul 2021 11:22:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27EB1406FF; Wed, 7 Jul 2021 11:22:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id CEC35406B4 for ; Wed, 7 Jul 2021 11:22:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625649726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0u+YPbcWpo7lQKaoEDKqUNXF06BUDwDIV8CbKVVuVl4=; b=IJiGZRWjnlaMyNEbEc7zZLVbrnNMrnCVhWQzvBrrTgD5qjk2HH425zcS0RdCOSL5KTkner hZrWR6sC5xzgUqfZVC9fc4MQ/Y9hkO0CoF5he6Tqcin3H2ul7if4YbymROEjtwD/efm2xM +BbC46ucQ8HWBalEL2jl0FIoV0hZ7ws= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-rlZQSDdiNaWuXEVWDOgdbw-1; Wed, 07 Jul 2021 05:22:03 -0400 X-MC-Unique: rlZQSDdiNaWuXEVWDOgdbw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7538510C1ADC; Wed, 7 Jul 2021 09:22:02 +0000 (UTC) Received: from [10.36.110.10] (unknown [10.36.110.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2648B5D9FC; Wed, 7 Jul 2021 09:21:54 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com References: <1622646329-279450-1-git-send-email-jiayu.hu@intel.com> <1625658843-89612-1-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: <2ca10f09-e744-6a85-5e18-7fe1ecaacf08@redhat.com> Date: Wed, 7 Jul 2021 11:21:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1625658843-89612-1-git-send-email-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vhost: allow to check in-flight packets for async vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/7/21 1:54 PM, Jiayu Hu wrote: > This patch allows to check the amount of in-flight packets > for vhost queues which register async channel acceleration. > > Signed-off-by: Jiayu Hu > --- > v2: > * use DEBUG log level > * return -1 when async is not registered > > doc/guides/prog_guide/vhost_lib.rst | 5 +++++ > lib/vhost/rte_vhost_async.h | 14 ++++++++++++++ > lib/vhost/version.map | 3 +++ > lib/vhost/vhost.c | 33 +++++++++++++++++++++++++++++++++ > 4 files changed, 55 insertions(+) > > diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst > index d18fb98..9fdc6d5 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -281,6 +281,11 @@ The following is an overview of some key Vhost API functions: > Poll enqueue completion status from async data path. Completed packets > are returned to applications through ``pkts``. > > +* ``rte_vhost_async_get_inflight(vid, queue_id)`` > + > + This function returns the amount of in-flight packets by now for the > + vhost queue which registers async channel acceleration. What about: " This function returns the amount of in-flight packets for the Vhost queue using async acceleration. " Other than that, it looks good to me: Reviewed-by: Maxime Coquelin Thanks, Maxime