From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11E69A0527; Wed, 8 Jul 2020 17:05:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 565921D95C; Wed, 8 Jul 2020 17:05:04 +0200 (CEST) Received: from qrelay207.mxroute.com (qrelay207.mxroute.com [172.82.139.207]) by dpdk.org (Postfix) with ESMTP id 0A0921D667 for ; Wed, 8 Jul 2020 17:05:02 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay207.mxroute.com (ZoneMTA) with ESMTPA id 1732ef566d30009563.005 for ; Wed, 08 Jul 2020 15:05:01 +0000 X-Zone-Loop: 2753fc2f19d146d01704b78311a928370a0be9d4a1f7 X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 0FA39626A6; Wed, 8 Jul 2020 15:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=31OZ/KAlkzNGEcru9tiN+sPXPq6vQFTkmd+q4gPxQsA=; b=EA3In4AXXopJEm1h8Jsh1iifNH vq+2rrOTUnAzo3aBxTcH0pmtN9/7DlNQQyTQJqplflv/mh1alsTQUxDOcaef47b3Af7U4oRFad5zQ zCKX/piv/KY0o9YSwnoTa/nDH+BA6po7xQEnaQuFTYqJkD3v4gUNfcmpfWS+KIHvY5Xl+bMa4PZpC EM9dW0ssMBOpStTneUeeLWnR7yisB6JjIzIV2MyPF3h1OBAzsWbfC4j2Ns7SV+3CxLwFQdUhq3s+p eOe/RhfA0o6yXPRyGvmYvjXXKiFgFNApxr2j6tD692a6NeovUm2Oqq+E6mDsSLcokrJd0f7A9ZQkk naN7dXvw==; To: David Marchand , Phil Yang , Aaron Conole Cc: dev , David Christensen , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , nd , Dodji Seketeli , Neil Horman , Harman Kalra References: <1591871065-12461-1-git-send-email-phil.yang@arm.com> <1591871065-12461-2-git-send-email-phil.yang@arm.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <2cae9ce4-8521-6eef-3a46-1be11167eae9@ashroe.eu> Date: Wed, 8 Jul 2020 16:04:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/07/2020 13:29, David Marchand wrote: > On Thu, Jun 11, 2020 at 12:25 PM Phil Yang wrote: >> >> The event status is defined as a volatile variable and shared >> between threads. Use c11 atomics with explicit ordering instead >> of rte_atomic ops which enforce unnecessary barriers on aarch64. >> >> Signed-off-by: Phil Yang >> Reviewed-by: Ruifeng Wang >> --- >> lib/librte_eal/include/rte_eal_interrupts.h | 2 +- >> lib/librte_eal/linux/eal_interrupts.c | 47 ++++++++++++++++++++--------- >> 2 files changed, 34 insertions(+), 15 deletions(-) >> >> diff --git a/lib/librte_eal/include/rte_eal_interrupts.h b/lib/librte_eal/include/rte_eal_interrupts.h >> index 773a34a..b1e8a29 100644 >> --- a/lib/librte_eal/include/rte_eal_interrupts.h >> +++ b/lib/librte_eal/include/rte_eal_interrupts.h >> @@ -59,7 +59,7 @@ enum { >> >> /** interrupt epoll event obj, taken by epoll_event.ptr */ >> struct rte_epoll_event { >> - volatile uint32_t status; /**< OUT: event status */ >> + uint32_t status; /**< OUT: event status */ >> int fd; /**< OUT: event fd */ >> int epfd; /**< OUT: epoll instance the ev associated with */ >> struct rte_epoll_data epdata; > > I got a reject from the ABI check in my env. > > 1 function with some indirect sub-type change: > > [C]'function int rte_pci_ioport_map(rte_pci_device*, int, > rte_pci_ioport*)' at pci.c:756:1 has some indirect sub-type changes: > parameter 1 of type 'rte_pci_device*' has sub-type changes: > in pointed to type 'struct rte_pci_device' at rte_bus_pci.h:57:1: > type size hasn't changed > 1 data member changes (2 filtered): > type of 'rte_intr_handle rte_pci_device::intr_handle' changed: > type size hasn't changed > 1 data member change: > type of 'rte_epoll_event rte_intr_handle::elist[512]' changed: > array element type 'struct rte_epoll_event' changed: > type size hasn't changed > 1 data member change: > type of 'volatile uint32_t rte_epoll_event::status' changed: > entity changed from 'volatile uint32_t' to 'typedef > uint32_t' at stdint-uintn.h:26:1 > type size hasn't changed > > type size hasn't changed > > > This is probably harmless in our case (going from volatile to non > volatile), but it won't pass the check in the CI without an exception > rule. > > Note: checking on the test-report ml, I saw nothing, but ovsrobot did > catch the issue with this change too, Aaron? > > Agreed, probably harmless and requires something in libagigail.ignore.