From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6386D4BE1 for ; Mon, 18 Sep 2017 14:33:49 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 05:33:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,412,1500966000"; d="scan'208";a="312898403" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.228.187]) ([163.33.228.187]) by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2017 05:33:47 -0700 To: zengganghui , "dev@dpdk.org" References: <1504064774-6340-1-git-send-email-zengganghui@huawei.com> <8ae48210-7291-7ee5-a17c-c82f9ed116cd@intel.com> <7683DD995282C14797C50C5AB01DF6D6B8C010@DGGEMA504-MBX.china.huawei.com> From: "Doherty, Declan" Message-ID: <2cbd474d-6505-9188-97ae-476a5edb16ef@intel.com> Date: Mon, 18 Sep 2017 13:33:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7683DD995282C14797C50C5AB01DF6D6B8C010@DGGEMA504-MBX.china.huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 12:33:49 -0000 On 18/09/2017 12:12 PM, zengganghui wrote: > For example, when packets received from an MLX network card, the value of mbuf->vlan_tci is a random value. So that this value cannot be used to determine whether VLAN packets . We need to judgment mbuf->ol_flags first. > > BR. > Zeng Ganghui > Huawei Technologies Co., Ltd. > > -----Original Message----- > From: Doherty, Declan [mailto:declan.doherty@intel.com] > Sent: Monday, September 18, 2017 5:14 PM > To: zengganghui; dev@dpdk.org > Subject: Re: [PATCH] net/bonding: strengthen the judgment of lacp packets > > On 30/08/2017 4:46 AM, ZengGanghui wrote: >> When the nic does not support vlan rx offload may be wrong, resulting >> in lacp packets will not be processed. >> >> Signed-off-by: ZengGanghui >> --- > ... >> > > Acked-by: Declan Doherty > Ok, I see your point. A LACP PDU can't be encapsulated in a VLAN packet anyway, as it is link local traffic. So a check for ol_flags & PKT_RX_VLAN_PKT != 0 should be sufficient, otherwise if the PKT_RX_VLAN_PKT flag is true the packet cannot be link local and therefore a LACP PDU. I think that it's safe to assume all PMDs must set this flag if VLAN stripping is enabled?