From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 50EAB1CB86 for ; Sat, 12 May 2018 02:52:40 +0200 (CEST) To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <152600304856.53146.9681482138854493833.stgit@localhost.localdomain> <152600319123.53146.4272659647114602311.stgit@localhost.localdomain> <96e61f34-c028-44b4-4a5b-6da3b6d6dd62@warmcat.com> From: Andy Green Message-ID: <2cfb813e-a8c8-c96a-353c-c2b145e4dad9@warmcat.com> Date: Sat, 12 May 2018 08:52:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 15/18] app: can't find include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2018 00:52:40 -0000 On 05/11/2018 09:20 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Andy Green [mailto:andy@warmcat.com] >> Sent: Friday, May 11, 2018 12:13 PM >> To: De Lara Guarch, Pablo ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 15/18] app: can't find include >> >> >> >> On 05/11/2018 07:04 PM, De Lara Guarch, Pablo wrote: >>> >>> >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green >>>> Sent: Friday, May 11, 2018 2:47 AM >>>> To: dev@dpdk.org >>>> Subject: [dpdk-dev] [PATCH v4 15/18] app: can't find include >>>> >>>> /home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10: >>>> fatal error: rte_pmd_dpaa.h: No such file or directory #include >>>> >>>> ^~~~~~~~~~~~~~~~ >>>> >>>> Signed-off-by: Andy Green >>> >>> As I said in the v3, I think this patch is not needed. >>> >> >> Do you have an idea why the actual error pasted in the patch is coming without >> this patch? > > Without this patch, do you see the file in ./build/include? > The file should be copied in there. If it is not there, it wasn't built and that won't fix the issue. > DPDK builds ok for me on Fedora 28/gcc 8 without this patch. Hm... so it was there $ ls -l build/include/rte_pmd_dpaa.h lrwxrwxrwx. 1 agreen agreen 37 May 11 09:41 build/include/rte_pmd_dpaa.h -> ../../drivers/net/dpaa/rte_pmd_dpaa.h I removed build/include and recooked it, the symlink was regenerated. As far as I can tell, you're right it doesn't need the patch. But it did earlier in the week for whatever reason... -Andy >> >> -Andy