From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A238C43F05; Thu, 25 Apr 2024 16:04:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 881EB43853; Thu, 25 Apr 2024 16:04:36 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2087.outbound.protection.outlook.com [40.107.244.87]) by mails.dpdk.org (Postfix) with ESMTP id 15C0C40284 for <dev@dpdk.org>; Thu, 25 Apr 2024 16:04:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VSBDL32pxZeZrHpX4iuR59oPzh3AhqDp0QEgHtG/G0+aIRbRE1yyfao7+hug+Hwi98kJlya4dDMA+MdUicQVES7rbnCtgRfdt0W4sMGObGthosDjl5W9GkU+fv2R2d2C6+9fYqX8jo5QtPy332m2LPHPXXNA+n5jVZfP9iPDnzjzDKmsVLl915ah+CQqLWRnQyypb9zu2NWgKolja/AKvUTwlPAC9FxEzgnU+K5XoAhGPzFXrciVRK6OIfOSPZgkX7TqLFeFUyj/rfQeJyRUpKb1DfYfMyxKoX723NpiY1T80+wJQbmcYhBAfoZpbPYyTSZnpYmux2tPedR6vvxzpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KyGa6mb3n7mEcPWuA7oC5356iS8/UvrB9PhDwPDJaR8=; b=eEW2QiCxciSE58BfdC3Ldxklltosj5iTUe5Px/mbb1Fm9GEybHi8sdZ4vb07YA3gEPbaTsuA8Y8BnONKv/pxZfs24AAT1PENKJGFE7rvQrYuFBLIbN6qaB+roJYW0dqHRuqijWPr15JaHho3hDsfYf59d7JGNn+eyVCx5R+VKdE4wq+do8dLDYRT70QAaVvEGwjE85w52X3G7WGkFkLFwALWAndWs/ruKUlgCsLoexBTZFFRAX+MAMERGuoNu5YFYQ+aH217dB4UlP2f6VbxQJjDpYjz71UgWyqMvp6RwV2js/L0/kEJNSjzWvgaDvNdUwzaizCbucABcp5rns/qWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KyGa6mb3n7mEcPWuA7oC5356iS8/UvrB9PhDwPDJaR8=; b=HnVJOJ8i2A0F1AAknhxReawMvT59ej5MHrsnJD4DZAeZurlDx/xFEDGtb1idOPgwjpRIqp8Kk7BxV2C4l2z0SR89Ru7I9N1ApixbaI0JBZN6l8CmSvFudmqpkr6B2lcMWeM90znHS4kh6+2NKA9K+5i/4qHbeR2uKbjhbaeIh0I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8208.namprd12.prod.outlook.com (2603:10b6:208:409::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.24; Thu, 25 Apr 2024 14:04:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7472.044; Thu, 25 Apr 2024 14:04:31 +0000 Message-ID: <2d07603e-e024-45a4-bfb1-c350b08ccdfb@amd.com> Date: Thu, 25 Apr 2024 15:04:27 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/af_packet: cache align Rx/Tx structs To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>, Stephen Hemminger <stephen@networkplumber.org> Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, "John W . Linville" <linville@tuxdriver.com>, dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com> References: <20240423090813.94110-1-mattias.ronnblom@ericsson.com> <6f7aabcb-2c12-4cfe-ae9d-73b42bfd4977@amd.com> <63dbb564-61f6-4d9f-9c13-4a21f5e97dc9@lysator.liu.se> <5d2a0887-527a-4948-943c-65f1dfda9328@amd.com> <3b2cf48e-2293-4226-b6cd-5f4dd3969f99@lysator.liu.se> <0ff40e60-926b-44eb-8af5-2e16aff1c336@amd.com> <20240424121330.7547e290@hermes.local> <2371b1a8-bdc5-4184-8491-54e2e3a64211@lysator.liu.se> <20240424165534.2ad8ae0a@hermes.local> <4c0f1625-4387-4870-a60a-dc423885811e@lysator.liu.se> Content-Language: en-US From: Ferruh Yigit <ferruh.yigit@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <4c0f1625-4387-4870-a60a-dc423885811e@lysator.liu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0250.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::21) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8208:EE_ X-MS-Office365-Filtering-Correlation-Id: b338552e-29bb-4182-5878-08dc6530a096 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RWlvRldwcDhRRWJxbkNxVG1sTEZIWWtKczF6SUhYeS9EWkdaZXp4UnFjRlE4?= =?utf-8?B?amgzL1hQZWlMZ05QanBDeW9RKy9XaUNDY3NOSzdXVWgxR0hFVjM0NGNjVW1s?= =?utf-8?B?b2lPNFJkbDd1czVsV3gzZ0hhdDBtMjIraExsdGphSVYrUGpNTzEwakNIUWJn?= =?utf-8?B?OUFZSWRLNnR5dExUT0dwYXNwRGo4SHBhS0NvVVN0V0tiS2podlI3WEZLY3Mv?= =?utf-8?B?RURET0hGZ3U2MGQ1VUhNYW5LbzRSRnp6UnVkMC9IL2VnVTUvOWRJclJuS2FR?= =?utf-8?B?RG9PWVBrOGxNZFowK1FrRnFTTU1RN2J2Z0NYUjdHenNnWnZFZWRlaFJ0ZGwr?= =?utf-8?B?NkJLUlZQSHNPVGs2RjdZS3JxNmp0MFAvc0p5WEMrMUZGN3UvNVBUS3RCZ2x0?= =?utf-8?B?dkdCNnpJR1hxallETzFFd0p2a25rY0RmQ29VNHFHeVpwcWZFOElydHhNU2FS?= =?utf-8?B?RjV5dk9ZU05BQWRTWHg4MVFkQ0Z3b2owb0hmbkI5WWtlQnRqMXcxaUtjOXV5?= =?utf-8?B?cTdwaEZQMVpEMzFnL0xxRHlQQmd1M0JGZEVFUlJPUjlZdEFiY2N6STUzMzhE?= =?utf-8?B?aFMrM1EzNDhpbmZLajVWcDByaldmRy9aRUcxdE5OalVaSGgrclk0UE4rU040?= =?utf-8?B?aGpuQm1uUE5vTWhBSkF0aEF1Qmg3ZEp4TXJWaFBmQzRGQWE2WWNubjl4MFlq?= =?utf-8?B?ZVhPdkh2M09pallsMk5YOFJKSjRpZlA0NXpORW9rS3o1eUN0VVk5ZUxpNjR0?= =?utf-8?B?VDZVdkg3bElUYTkxYVlpS1NGTjdxbnNsZEdNM0NCcHZlekhoSkhjK0lFOTVr?= =?utf-8?B?Z0ZXRjIxM3p5ZnpvVG1mZXNibW40OEhjOUczZ2JGOC9uNXBvVWNlTlVUeUNT?= =?utf-8?B?UkphVmVzQ3RBeURxUnk2UlBhVDRhdzdiZmpGN0MvRnA0b0xlM01YY1ExV216?= =?utf-8?B?T0pMemJlVTNxYW9ZM0swRUd6WDNLZGExVTh4ZmVZbFdrT0hDeWdOejF0Zy8y?= =?utf-8?B?QnZ5bDVEUklpTWIvRldMSW1WVzN2eVN0UlNxZ2NleFVwU1RPS2VYaXcvcG1H?= =?utf-8?B?V0t4UTd2ZVVHeTJTZlAzL2ZwaTZacEJMOVBtTlRiVHlWdWZXRURQUEdtK2hy?= =?utf-8?B?VDgxbG4vOW5mdjV2TGlUMmdLWUh2dnozWHR1bWdLUzBvanM3dENpbERIeXVX?= =?utf-8?B?OFBBZmROYnk5UmRUN1ZvM0pva3psTkFJbG5JZjFqMXUvMjZNZDdZK2ZwQjgy?= =?utf-8?B?TjFMRFBTUWI0YlZ6aFdoay94ZjQvS21Ha3ZBSEtmcGJYbkREQXN6TWlpdnhX?= =?utf-8?B?NWN2cUQrbmljTTY0Qk0weFZuSlpxMW1zQW8xcDRPNlJ6L2VMNFNzMW1vdUlX?= =?utf-8?B?UGJoZVNLU2ppZmNDVml3WkQ4TnVZZU5NOUZpSllxS2tOTTFnNm9PSE5LbTBo?= =?utf-8?B?UUI4ZG9zb1Q5dkVEbWMzMC9RRHNJd21ZVzJaRzVmZExjWGNrcHo3bVVvMkRF?= =?utf-8?B?VHZXd3dzS2pveUhDTFpFY2hpZnZRRGsralBtaFRLaEVoZFJoWFFDTkttUTBp?= =?utf-8?B?dCt4d09LbGdoVUNyM2NBNVo2b21ibHRUMW9DU3hXS1dWWTJCU1RLdHRXUnF2?= =?utf-8?B?WThDSGRrWkhVNmw1aTF0UG91QW83RUhyb0taYjNkK25wSXhGd3UwUkJ0VVQ4?= =?utf-8?B?RDRUclhBOUw3NVVpOFByNmJzdmFZU2Fha3FGMEZvSFFnTzhuMFBFazRRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q29hMXRuc1NaSUs3NktFTmthQ0o5ME1CWU1Yamt6V1NPZkpRMWQrdFp3WENP?= =?utf-8?B?NVJKL1RVTFBCRmxzMGdPQitqS2tDWDE1MExiWW9lenROaXF3b0Y1SWpmZFZU?= =?utf-8?B?VVVjSm5sbEduc0tYeExtT3VVcWxxcHNsL1gzT3c4MWFKbEs1QUFKT2xnVGxK?= =?utf-8?B?UEtJdmpmbWVGaFFCZ0cwNlFrL28rRlhKQ3NrMVpGWmkvSFZjQWlUVFNibU85?= =?utf-8?B?b1FpVW8xTmk0RXRmVmh3aWpRdkVyU0ZjWTUwRzN4MWFUeU9VTUxPU2lCUXk2?= =?utf-8?B?VjFqWjJVYTR2dnI2Zlh4U2ZSdHpOeWc1NHpUTzN4WnVoYnBVbmRrUUNOY1Rq?= =?utf-8?B?ZzdrQlVHaUhRdVVkNUFMZWpMOHluU2czR1VENmlmcVEwZWw0U0RUTkpndUJ3?= =?utf-8?B?RWZYWUlWOW05QndqdnFjV1Q1WnZhckZScjhQOTRHczg3OCtreXl0SFZBZTc4?= =?utf-8?B?NE5aQ2NRU2cvS1VTUjNKWVp5M08rN09JTkVBMzBXTCtmOW5tTUJ3a1JmTDd0?= =?utf-8?B?dzVPMDd5RGQwQmtvOFF0aE9LaWFHbmV1VEVVQzMrNTlYcTFSZi9xRkxBNDQr?= =?utf-8?B?MkFKSkFMY2p0MUVpTFh5d3NzV3B5QTdnTldnUlJRVHpaejEyWVVadHRDUlBH?= =?utf-8?B?V0pGdzl2ZXNQZ0lCcHJNdGM0bVpEZUNzRVVmcjkrTGNYQktRd0NDbHkrZm5P?= =?utf-8?B?aUNqY0dNRHQ5QlZRMmZRQ3R0TytiQjFSK2dUZEJCZzNIWEFnUHNsRXRJS2FT?= =?utf-8?B?ZUJ3NUVSWkdBL3ZlcXhSUEMwL2FIbWphVGpuQVlTamQ5K3dSdmxyV0FGakh6?= =?utf-8?B?eGVObW0wUjl0OVFJZmVCMUpZcGlQU2Jta1dWd3NoaUY0QW0zbFNWa0FZTGdm?= =?utf-8?B?Y1dVdE5DZW9UNVRnNmk0N29qYk11THpDY3Y3R21YMUNpa1crSHVqSVE1ZjVl?= =?utf-8?B?eENoSi9LV3dJOHpGREhsYzBtdTFOUmtBa3l6c3FHT1RVUmRoMksxUmUwS2FK?= =?utf-8?B?blFKM1BNTzdjZWlqYVREdytLYlU4L2V3Y1JNOE9IanppQ0Y1RDQ5WkJIMURR?= =?utf-8?B?NjZHK283aHVPV2FnTFd2TWQ1WXVVdmZCRm9JTkRPS3ZmeDYwOFNYR1RrWnYw?= =?utf-8?B?a3FLZjA4QVRSZEVGSG1tcFVPR1pWcm5jV3E3aEI2N2MzVTJabWJFemh1VjI0?= =?utf-8?B?dGdjWVdpS3I3djhXYThINkpVcml3dkFVdThDZGxlbFh4NWVtL1pqZXNBMWdZ?= =?utf-8?B?cTdvOUxobzUwSFgvNThpcnk1cWQ5VHR5bTc4ZGxzYkJ0MGgvbzZ5NUE3ZjYr?= =?utf-8?B?RVdXditZdXRqVDVTZGQya1FBNTFsVGF5N21ZVk02TWJSTFR0VFNrdmNVL2NT?= =?utf-8?B?eFlvZFRPQUZmTVdPd0pHV3Z6VVFFeGd6Z0w4RXRQMCt6N3U5V1Jpd2hKcERW?= =?utf-8?B?RkNRTGRRa29meWJvS0pKdkY3dTVDY3crT1hFMEdndVNOanNsYzNwVGUzaVNC?= =?utf-8?B?c2tIVlV2R1BpKzdQUFduK3RDdGJPQjdXZFFHSzFLclhWSjJpVmtCVEd4Ukhj?= =?utf-8?B?MUhFVFpneTVMTzVzQXJBdE8zaHZmTmpYelhuZDlaejhtZHEyTjRsSW1aYzJQ?= =?utf-8?B?RTk2TjFGYVlZdTFNb3lVWWRGNm44dmpHOVN6c25QKzBaOEQwYVdMTUk1ZlVa?= =?utf-8?B?TWprMDFyeHFGbjU3Um56ZCtiN3RnM09HS0JacWljckVrbHlPQi96Tm84cnlU?= =?utf-8?B?MlkxVHhQQ1VnaWpCUU1ld2dRbEgwQ1ZnMHhycVNPOHAxS3JPWE5VZzJCdWJp?= =?utf-8?B?bEZtWmdNbWZRaVkxRVcwNzgzZVJhZE5EbzBZS004T2h3dnU3dEt1SkVDdkw0?= =?utf-8?B?RzRhYXBndUlYS3dkTDArS01SUkxHbFFsUUlLekVka0RjR1ZmK3lpUUJOR2kz?= =?utf-8?B?dTVFTlpibzRnRUttQ3pkdUVUbzl4OUZkSisrWTJOS1BQd24wdUQ4T1JnQ2Nk?= =?utf-8?B?b1h5UlgzcFNtREpOYW1EeENPQXp6MVhDWVJYT09IbG5yZEh3U3JxQ2N6NkZH?= =?utf-8?B?YVJUKzB4bEUzZ0d6M1lEeldWOEVGa2phSjVmcmZreXMzQzRFdlBmV2F2N0I5?= =?utf-8?Q?tDj3QwVifWtIVoWm6NAfJNmQ8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b338552e-29bb-4182-5878-08dc6530a096 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 14:04:30.9571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RXcHyk0aHHb5jamu6agsiAzjE5QWIrM7owYxVs8+A8W/YG51jqd131vxPBp11JHA X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8208 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 4/25/2024 10:26 AM, Mattias Rönnblom wrote: > On 2024-04-25 01:55, Stephen Hemminger wrote: >> On Thu, 25 Apr 2024 00:27:36 +0200 >> Mattias Rönnblom <hofors@lysator.liu.se> wrote: >> >>> On 2024-04-24 21:13, Stephen Hemminger wrote: >>>> On Wed, 24 Apr 2024 18:50:50 +0100 >>>> Ferruh Yigit <ferruh.yigit@amd.com> wrote: >>>> >>>>>> I don't know how slow af_packet is, but if you care about >>>>>> performance, >>>>>> you don't want to use atomic add for statistics. >>>>>> >>>>> >>>>> There are a few soft drivers already using atomics adds for >>>>> updating stats. >>>>> If we document expectations from 'rte_eth_stats_reset()', we can >>>>> update >>>>> those usages. >>>> >>>> Using atomic add is lots of extra overhead. The statistics are not >>>> guaranteed >>>> to be perfect. If nothing else, the bytes and packets can be skewed. >>>> >>> >>> The sad thing here is that in case the counters are reset within the >>> load-modify-store cycle of the lcore counter update, the reset may end >>> up being a nop. So, it's not like you missed a packet or two, or suffer >>> some transient inconsistency, but you completed and permanently ignored >>> the reset request. >> >> That is one of the many reasons the Linux kernel intentionally did not >> implement a reset statistics operation. > > DPDK should deprecate statistics reset, it seems to me. > > The current API is broken anyway, if you care about correctness. A reset > function must return the current state of the counters, at the point > them being reset. Otherwise, a higher layer may miss counter updates. > > The af_packet PMD should return -ENOTSUP on reset (which is allowed by > the API). > > Maintaining an offset-since-last-reset for counters is a control plane > thing, and shouldn't be in PMDs. (If MT-safe reset for SW-managed > counters are to be expected from the PMDs, we should have some helper > API to facilitate its efficient & correct-enough implementation.) > statistics reset works for HW devices, instead of removing statics reset I am for documenting API that it may be not reliable, I can send a patch for it. With above change, we can be more relax on stats update specially for soft drivers, and can convert atomic_add stats updates to "atomic load + add + atomic store". Does this plan make sense?