From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B37421559 for ; Mon, 10 Sep 2018 11:09:41 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 7A22340005A; Mon, 10 Sep 2018 09:09:40 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 10 Sep 2018 02:09:36 -0700 To: Dekel Peled , , , , CC: , References: <1536235311-43741-1-git-send-email-dekelp@mellanox.com> From: Andrew Rybchenko Message-ID: <2d0b247c-e15d-f88b-a613-6017db7e4017@solarflare.com> Date: Mon, 10 Sep 2018 12:09:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1536235311-43741-1-git-send-email-dekelp@mellanox.com> Content-Language: en-US X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ocex03.SolarFlarecom.com (10.20.40.36) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24084.005 X-TM-AS-Result: No-13.195000-4.000000-10 X-TMASE-MatchedRID: +f/wAVSGjugOwH4pD14DsPHkpkyUphL9wx0jRRxcQfNZps+y1VXzqdIS YzBUt2RaJC6r8LawABm59NaP1GUq7wM6op3uvrMHkVUMyVUKRZ7Eu1SSYkqHdCz+5QCTrE/sLPJ tWpbJjY2K1rZlxUX6G0/R0GK3SpMWl722oUhn92BDU5wIS9P5twQp8uZa2O9n0SxMhOhuA0SlHj sjMHC3hlqw5Ke6UIMf4YS6FyG8vyjyUQNiagGSs9sfxZpQv2qMm/y00tE9Sta/wz3p7pLVvSxZV 2XdhwOw7fNKgmEEsE15yBhThbfWE8xbM9+io50WnTqdU4w65WkcDDLReGt4PfmUDxpFogQXo8WM kQWv6iUD0yuKrQIMCAGLeSok4rrZec3QM3secWYeCE4fIYBYgQUcNfYflqHvvgolP4NCNNvblXe 7YZb+LrFHw47JpPxC5cmWrlJ4Nt1xi6SUnIZ07ZepCX4kOSzQxKrowz5A0Ox+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--13.195000-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24084.005 X-MDID: 1536570581-osUM80rZSHEv Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 09:09:42 -0000 On 09/06/2018 03:01 PM, Dekel Peled wrote: > Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx. > If new Tx offload capabilities are defined, they also must be mentioned > in rte_tx_offload_names in rte_ethdev.c file. > > This patch adds the required lines in aray rte_tx_offload_names. > > Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO") > > Cc: xuemingl@mellanox.com > > Signed-off-by: Dekel Peled > --- > lib/librte_ethdev/rte_ethdev.c | 2 ++ > lib/librte_ethdev/rte_ethdev.h | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 3f8de93..5004b9f 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -156,6 +156,8 @@ struct rte_eth_xstats_name_off { > RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS), > RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE), > RTE_TX_OFFLOAD_BIT2STR(SECURITY), > + RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO), > + RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO), > }; > > #undef RTE_TX_OFFLOAD_BIT2STR > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index fa2812b..5456ce2 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -941,18 +941,18 @@ struct rte_eth_conf { > * the same mempool and has refcnt = 1. > */ > #define DEV_TX_OFFLOAD_SECURITY 0x00020000 > +#define DEV_TX_OFFLOAD_UDP_TNL_TSO 0x00040000 > /** > * Device supports generic UDP tunneled packet TSO. > * Application must set PKT_TX_TUNNEL_UDP and other mbuf fields required > * for tunnel TSO. > */ > -#define DEV_TX_OFFLOAD_UDP_TNL_TSO 0x00040000 > +#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000 > /** > * Device supports generic IP tunneled packet TSO. > * Application must set PKT_TX_TUNNEL_IP and other mbuf fields required > * for tunnel TSO. > */ > -#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000 I don't understand why it is changed. Comments should be before define. > > #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001 > /**< Device supports Rx queue setup after device started*/