From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C79BA0543; Fri, 7 Oct 2022 21:45:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FD0B400D5; Fri, 7 Oct 2022 21:45:44 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 67E4240042 for ; Fri, 7 Oct 2022 21:45:42 +0200 (CEST) Received: from [192.168.1.126] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id BD5EE7B; Fri, 7 Oct 2022 22:45:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru BD5EE7B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665171941; bh=0Auy3+MlTVYSgDgv5JMHbxStlGF7GJVHEvK23CfdoGI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iNzaAWQXHp4rYHOVMtfunTFRf7liuGui/PCMyU888xonSwqSWUsedwavBLODvQTUC +YujxHhd0eSMVQTY4m6jTHYEgpi2FwtcOKE0h1njsm1RPUaYRuWWvCHHYf946D8B9a uXh8KY7xZ/9/Z7D1so/oz7IctqBcmx1uEQFQLlZ0= Message-ID: <2d104133-083b-5e98-9028-44f05bbae67f@oktetlabs.ru> Date: Fri, 7 Oct 2022 22:45:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v8 2/4] ethdev: support multiple mbuf pools per Rx queue Content-Language: en-US To: Thomas Monjalon Cc: Ferruh Yigit , dev@dpdk.org, Hanumanth Pothula References: <20221006170126.1322852-1-hpothula@marvell.com> <20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru> <20221007172921.3325250-3-andrew.rybchenko@oktetlabs.ru> <2575143.k3LOHGUjKi@thomas> From: Andrew Rybchenko In-Reply-To: <2575143.k3LOHGUjKi@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/7/22 21:35, Thomas Monjalon wrote: > 07/10/2022 19:29, Andrew Rybchenko: >> +* **Added support for mulitiple mbuf pools per ethdev Rx queue.** > > mulitiple -> multiple > > I can fix when merging. Thanks, I've delegated first 3 patches to you. I think it is ready to go. Let's sort out testpmd patch a bit later. May be we'll have testpmd maintainers review. > >> + >> + The capability allows application to provide many mempools of different >> + size and PMD and/or NIC to choose a memory pool based on the packet's >> + length and/or Rx buffers availability. > [...] >> + /** >> + * Array of mempools to allocate Rx buffers from. >> + * >> + * This provides support for multiple mbuf pools per Rx queue. >> + * The capability is reported in device info via positive >> + * max_rx_mempools. >> + * >> + * It could be useful for more efficient usage of memory when an >> + * application creates different mempools to steer the specific >> + * size of the packet. >> + * >> + * If many mempools are specified, packets received using Rx >> + * burst may belong to any provided mempool. From ethdev user point >> + * of view it is undefined how PMD/NIC chooses mempool for a packet. >> + * >> + * If Rx scatter is enabled, a packet may be delivered using a chain >> + * of mbufs obtained from single mempool or multiple mempools based >> + * on the NIC implementation. >> + */ >> + struct rte_mempool **rx_mempools; >> + uint16_t rx_nmempool; /** < Number of Rx mempools */ > > OK, it's clear, thanks. > >