From: Jeff Guo <jia.guo@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, qiming.yang@intel.com
Cc: simei.su@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ice: remove RSS for SCTP in PPPoE
Date: Mon, 27 Jul 2020 10:38:32 +0800 [thread overview]
Message-ID: <2d46ea04-541f-4b63-dd9e-1bcdbad8da12@intel.com> (raw)
In-Reply-To: <20200725125830.3561-1-qi.z.zhang@intel.com>
hi, qi
On 7/25/2020 8:58 PM, Qi Zhang wrote:
> We don't support SCTP in PPPoE RSS, remove it.
>
> Fixes: d117de460035 ("net/ice: fix GTPU/PPPoE packets with no hash value")
> Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow")
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 12 ------------
> drivers/net/ice/ice_hash.c | 14 --------------
> 2 files changed, 26 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index a4a0390f8..c4c0e638f 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -2666,12 +2666,6 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
> if (ret)
> PMD_DRV_LOG(ERR, "%s GTPU_EH_IPV4_SCTP rss flow fail %d",
> __func__, ret);
> -
> - ret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_SCTP_IPV4,
> - ICE_FLOW_SEG_HDR_PPPOE, 0);
> - if (ret)
> - PMD_DRV_LOG(ERR, "%s PPPoE_IPV4_SCTP rss flow fail %d",
> - __func__, ret);
> }
>
> if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {
> @@ -2686,12 +2680,6 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
> if (ret)
> PMD_DRV_LOG(ERR, "%s GTPU_EH_IPV6_SCTP rss flow fail %d",
> __func__, ret);
> -
> - ret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_SCTP_IPV6,
> - ICE_FLOW_SEG_HDR_PPPOE, 0);
> - if (ret)
> - PMD_DRV_LOG(ERR, "%s PPPoE_IPV6_SCTP rss flow fail %d",
> - __func__, ret);
> }
> }
>
> diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
> index e535e4b95..4243f7ce9 100644
> --- a/drivers/net/ice/ice_hash.c
> +++ b/drivers/net/ice/ice_hash.c
> @@ -204,10 +204,6 @@ struct rss_type_match_hdr hint_eth_pppoes_ipv4_tcp = {
> ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 |
> ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,
> ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_TCP};
> -struct rss_type_match_hdr hint_eth_pppoes_ipv4_sctp = {
> - ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 |
> - ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP,
> - ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_SCTP};
> struct rss_type_match_hdr hint_eth_ipv4_esp = {
> ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER |
> ICE_FLOW_SEG_HDR_ESP,
> @@ -313,10 +309,6 @@ struct rss_type_match_hdr hint_eth_pppoes_ipv6_tcp = {
> ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 |
> ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP,
> ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_TCP};
> -struct rss_type_match_hdr hint_eth_pppoes_ipv6_sctp = {
> - ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 |
> - ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP,
> - ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_SCTP};
> struct rss_type_match_hdr hint_eth_pppoes = {
> ICE_FLOW_SEG_HDR_PPPOE,
> ETH_RSS_ETH | ETH_RSS_PPPOE};
> @@ -398,10 +390,6 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = {
> &hint_eth_pppoes_ipv4},
> {pattern_eth_pppoes_ipv4_udp, ICE_INSET_NONE,
> &hint_eth_pppoes_ipv4_udp},
> - {pattern_eth_pppoes_ipv4_tcp, ICE_INSET_NONE,
> - &hint_eth_pppoes_ipv4_tcp},
The tcp should not be removed. Need a new version please.
> - {pattern_eth_pppoes_ipv4_sctp, ICE_INSET_NONE,
> - &hint_eth_pppoes_ipv4_sctp},
> {pattern_eth_ipv4_esp, ICE_INSET_NONE,
> &hint_eth_ipv4_esp},
> {pattern_eth_ipv4_udp_esp, ICE_INSET_NONE,
> @@ -452,8 +440,6 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = {
> &hint_eth_pppoes_ipv6_udp},
> {pattern_eth_pppoes_ipv6_tcp, ICE_INSET_NONE,
> &hint_eth_pppoes_ipv6_tcp},
> - {pattern_eth_pppoes_ipv6_sctp, ICE_INSET_NONE,
> - &hint_eth_pppoes_ipv6_sctp},
> {pattern_eth_pppoes, ICE_INSET_NONE,
> &hint_eth_pppoes},
> };
next prev parent reply other threads:[~2020-07-27 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 12:58 Qi Zhang
2020-07-27 1:29 ` Lu, Nannan
2020-07-27 2:38 ` Jeff Guo [this message]
2020-07-27 3:44 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d46ea04-541f-4b63-dd9e-1bcdbad8da12@intel.com \
--to=jia.guo@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).