From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7A2CA0524; Mon, 27 Jul 2020 04:38:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACAF71C029; Mon, 27 Jul 2020 04:38:38 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8DFD111A2 for ; Mon, 27 Jul 2020 04:38:36 +0200 (CEST) IronPort-SDR: 5WVOx6i4g78EwZTNjYmbr9Veh9IFd1d53vUt5YyA4QTnUFSRFhOQrzlQ3aMUGSPx/VRQMexDSI e9l7+AIuOQvw== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="131009432" X-IronPort-AV: E=Sophos;i="5.75,400,1589266800"; d="scan'208";a="131009432" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2020 19:38:35 -0700 IronPort-SDR: tsznHH3r8g5htl+/JJYxGdMocBUrdKPIFrH51GQlJr5naaaR0ab8lZT03iCyqwq/Y9SH45cdp/ v67xh65oWShg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,400,1589266800"; d="scan'208";a="327877657" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176]) ([10.67.68.176]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 19:38:33 -0700 To: Qi Zhang , qiming.yang@intel.com Cc: simei.su@intel.com, dev@dpdk.org References: <20200725125830.3561-1-qi.z.zhang@intel.com> From: Jeff Guo Message-ID: <2d46ea04-541f-4b63-dd9e-1bcdbad8da12@intel.com> Date: Mon, 27 Jul 2020 10:38:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200725125830.3561-1-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/ice: remove RSS for SCTP in PPPoE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, qi On 7/25/2020 8:58 PM, Qi Zhang wrote: > We don't support SCTP in PPPoE RSS, remove it. > > Fixes: d117de460035 ("net/ice: fix GTPU/PPPoE packets with no hash value") > Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow") > > Signed-off-by: Qi Zhang > --- > drivers/net/ice/ice_ethdev.c | 12 ------------ > drivers/net/ice/ice_hash.c | 14 -------------- > 2 files changed, 26 deletions(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index a4a0390f8..c4c0e638f 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -2666,12 +2666,6 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) > if (ret) > PMD_DRV_LOG(ERR, "%s GTPU_EH_IPV4_SCTP rss flow fail %d", > __func__, ret); > - > - ret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_SCTP_IPV4, > - ICE_FLOW_SEG_HDR_PPPOE, 0); > - if (ret) > - PMD_DRV_LOG(ERR, "%s PPPoE_IPV4_SCTP rss flow fail %d", > - __func__, ret); > } > > if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) { > @@ -2686,12 +2680,6 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) > if (ret) > PMD_DRV_LOG(ERR, "%s GTPU_EH_IPV6_SCTP rss flow fail %d", > __func__, ret); > - > - ret = ice_add_rss_cfg(hw, vsi->idx, ICE_HASH_SCTP_IPV6, > - ICE_FLOW_SEG_HDR_PPPOE, 0); > - if (ret) > - PMD_DRV_LOG(ERR, "%s PPPoE_IPV6_SCTP rss flow fail %d", > - __func__, ret); > } > } > > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c > index e535e4b95..4243f7ce9 100644 > --- a/drivers/net/ice/ice_hash.c > +++ b/drivers/net/ice/ice_hash.c > @@ -204,10 +204,6 @@ struct rss_type_match_hdr hint_eth_pppoes_ipv4_tcp = { > ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 | > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP, > ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_TCP}; > -struct rss_type_match_hdr hint_eth_pppoes_ipv4_sctp = { > - ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV4 | > - ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP, > - ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV4_SCTP}; > struct rss_type_match_hdr hint_eth_ipv4_esp = { > ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER | > ICE_FLOW_SEG_HDR_ESP, > @@ -313,10 +309,6 @@ struct rss_type_match_hdr hint_eth_pppoes_ipv6_tcp = { > ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 | > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP, > ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_TCP}; > -struct rss_type_match_hdr hint_eth_pppoes_ipv6_sctp = { > - ICE_FLOW_SEG_HDR_PPPOE | ICE_FLOW_SEG_HDR_IPV6 | > - ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP, > - ETH_RSS_ETH | ETH_RSS_PPPOE | ETH_RSS_NONFRAG_IPV6_SCTP}; > struct rss_type_match_hdr hint_eth_pppoes = { > ICE_FLOW_SEG_HDR_PPPOE, > ETH_RSS_ETH | ETH_RSS_PPPOE}; > @@ -398,10 +390,6 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = { > &hint_eth_pppoes_ipv4}, > {pattern_eth_pppoes_ipv4_udp, ICE_INSET_NONE, > &hint_eth_pppoes_ipv4_udp}, > - {pattern_eth_pppoes_ipv4_tcp, ICE_INSET_NONE, > - &hint_eth_pppoes_ipv4_tcp}, The tcp should not be removed. Need a new version please. > - {pattern_eth_pppoes_ipv4_sctp, ICE_INSET_NONE, > - &hint_eth_pppoes_ipv4_sctp}, > {pattern_eth_ipv4_esp, ICE_INSET_NONE, > &hint_eth_ipv4_esp}, > {pattern_eth_ipv4_udp_esp, ICE_INSET_NONE, > @@ -452,8 +440,6 @@ static struct ice_pattern_match_item ice_hash_pattern_list_comms[] = { > &hint_eth_pppoes_ipv6_udp}, > {pattern_eth_pppoes_ipv6_tcp, ICE_INSET_NONE, > &hint_eth_pppoes_ipv6_tcp}, > - {pattern_eth_pppoes_ipv6_sctp, ICE_INSET_NONE, > - &hint_eth_pppoes_ipv6_sctp}, > {pattern_eth_pppoes, ICE_INSET_NONE, > &hint_eth_pppoes}, > };