From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 228802BF2
 for <dev@dpdk.org>; Mon,  3 Jul 2017 13:18:54 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP; 03 Jul 2017 04:18:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,302,1496127600"; d="scan'208";a="103966375"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91])
 ([10.237.220.91])
 by orsmga004.jf.intel.com with ESMTP; 03 Jul 2017 04:18:52 -0700
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 Shrikrishna Khare <skhare@vmware.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
References: <1497280691-18641-1-git-send-email-bernard.iremonger@intel.com>
 <1497529790-31587-2-git-send-email-bernard.iremonger@intel.com>
 <2139772.cOZ1VZa0cE@xps> <5c648ffc-7b7b-672c-21c0-e209f2589497@intel.com>
 <51c5491c-7d40-fe32-d06e-02085f9fbf57@intel.com>
 <8CEF83825BEC744B83065625E567D7C24E01D63B@IRSMSX108.ger.corp.intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <2d48d57d-ffb2-5767-7fcd-35d6f43f9420@intel.com>
Date: Mon, 3 Jul 2017 12:18:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E01D63B@IRSMSX108.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jul 2017 11:18:55 -0000

On 7/3/2017 12:06 PM, Iremonger, Bernard wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Monday, July 3, 2017 10:05 AM
>> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Shrikrishna Khare
>> <skhare@vmware.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process API
>>
>> On 7/3/2017 10:01 AM, Ferruh Yigit wrote:
>>> On 7/1/2017 4:19 PM, Thomas Monjalon wrote:
>>>> 15/06/2017 14:29, Bernard Iremonger:
>>>>> From: "Bernard.Iremonger" <Bernard.iremonger@intel.com>
>>>>>
>>>>> Change the rte_eth_dev_callback_process function to return int, and
>>>>> add a void *ret_param parameter.
>>>>
>>>> Adding this explanation:
>>>> 	The new parameter is used by ixgbe and i40e instead of abusing
>>>> 	the user data of the callback.
>>>> and this title:
>>>> 	ethdev: add return values to callback process API
>>>>
>>>> And applied, thanks
>>>>
>>>
>>> Hi Bernard, Shrikrishna,
>>>
>>> This patch breaks vmxnet3 build, can you please send a patch to fix it?
>>
>> The build error is on next-net. Main repo looks good.
>>
>>>
>>> Thanks,
>>> ferruh
>>>
> 
> In dpdk-next-net a call to _rte_eth_dev_callback_process() has been added in vmxnet3_ethdev.c at line 1321 using the old API.
> I can send a patch or could you add an extra NULL parameter at line 1325 in vmxnet3_ethdev.c?

Fix is trivial, but I shouldn't just update the code. It should be done
by a proper process, with a fix patch.

Would you mind sending the patch?

Thanks,
ferruh

> 
> Regards,
> 
> Bernard.
>