From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0047.outbound.protection.outlook.com [104.47.38.47]) by dpdk.org (Postfix) with ESMTP id 29E281B217 for ; Thu, 12 Oct 2017 12:58:28 +0200 (CEST) Received: from BN3PR03CA0111.namprd03.prod.outlook.com (10.174.66.29) by CY1PR03MB2362.namprd03.prod.outlook.com (10.166.207.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 12 Oct 2017 10:58:26 +0000 Received: from BN1BFFO11FD020.protection.gbl (2a01:111:f400:7c10::1:139) by BN3PR03CA0111.outlook.office365.com (2603:10b6:400:4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Thu, 12 Oct 2017 10:58:26 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD020.mail.protection.outlook.com (10.58.144.83) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 12 Oct 2017 10:58:25 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9CAwMG1022690; Thu, 12 Oct 2017 03:58:23 -0700 To: Cristian Dumitrescu , References: <1507208974-180500-2-git-send-email-cristian.dumitrescu@intel.com> <1507301136-131382-1-git-send-email-cristian.dumitrescu@intel.com> <1507301136-131382-3-git-send-email-cristian.dumitrescu@intel.com> CC: , , , , From: Hemant Agrawal Message-ID: <2d538d82-406d-0a71-ff2d-83cf387b2256@nxp.com> Date: Thu, 12 Oct 2017 16:28:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1507301136-131382-3-git-send-email-cristian.dumitrescu@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131522795059695204; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(39860400002)(39380400002)(346002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(24454002)(377454003)(189002)(50986999)(76176999)(81156014)(65956001)(54356999)(2950100002)(77096006)(189998001)(106466001)(2906002)(104016004)(105606002)(966005)(53546010)(230700001)(47776003)(65806001)(86362001)(65826007)(53936002)(23746002)(81166006)(8676002)(31696002)(33646002)(54906003)(229853002)(5660300001)(68736007)(4326008)(31686004)(110136005)(6246003)(498600001)(6306002)(305945005)(85426001)(97736004)(8936002)(356003)(36756003)(83506001)(50466002)(316002)(58126008)(64126003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2362; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD020; 1:5YjIF1AxGPLBnyl18lT7vs9wCCFgtfaEp3I6xVmt8FU6/ZmBJ34iRv7Rgi/fn6z5w6r77nokaAhcZbLQROc4ARa7+9ySzJwlikHETqu0LM6xxCOhtb7oacMuGZdTqQwW X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf911027-a177-45c6-ed05-08d5116029da X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2362; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 3:VSMEfjvKsxCtYQR8gTE/04tevBlBxjwdgiNbK5cdRYwLGoE30r1bENeXhSV2qBaUJWDmNmYLX1+vNdls5txtZ5fTVI4kMD6Za1Lg3jLu1lSi17zGoGBmgQAkSttRqTOovlRnHUhLPNnVv3uO52729U0HnnGj3u1UhB94auC4QLJTJ74Ozp49GUf3yb72N7RovrIo6pw9GrGGsa4kznQEWQ3IP6KQGtZNQ9IltPQEmdfUvZSgKmHiHa9Q/WWfdfY+ez/OjPtL2pg788EK14jOTxKGgDbujNrzCdM/AlCKvJCNEQG7QQDE+zi1H1b9lAHRZ2jxq5PfqqfFaUmmnupW7jZc7FjPm0FHTKpxrouEyEo=; 25:CeyVgHJzOYuyGSDwmfYbsT0URW/VkC7Fgy/r8jkkrpNqXdp0FEc4FpAXUQma8Snsu5pR7jB+XG3++pl2NpZWZXkOdhbKowSN6DX8FHk7c/NIOQdC2fjgoKxGqO/G5OzGQu0y9ZwdBX1S+XNPlblqjfcYddHXIVRtRUoebc/uTGga3TyCy3h8l74eD6vlI4FLWwYmRdnHmSPTJQ8XZ17xR9Ud7BVNDGfACbQCicM386Mylr94iZpj3hRQbnkrKK22tsOr/gNwmv1E44uEa+8FtO+K5/rY/Q7YpvF4cNWakoWLlpA/gXKBc63HmLru73kuO2MPHQuU4ppfvA/PwcpOldeo6SmLdOB14Ca75rZfFPo= X-MS-TrafficTypeDiagnostic: CY1PR03MB2362: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 31:63zc60UG61OllvIkSYp6oQlRnX6FghayEnVk4gAmTa2ncEusk3R2d3tm5vgYsxmRla3UoyL52bRm5QLIJyW+wPJKEU/j+L6+3Qd09abVfP1o7+B86zs0jeIwi0paiGLhFbCvy2Qz2Q5ixYBuYMi6N9Mw0msZckJ7SOZ4It+4H37oJbYd4tk1bkuhABm5cd/Yg+ChbK1C8NSxFryNE5n9xcuHsCbrAqpfj6JIkA0Qmec=; 4:J4ZKp9ms02Al02strK33OF75icR1DsVp46iw62Dp0bswAKa/JMq5nE4S5yxZO7S2kJK2bZVf8My2eWiNMKve2ErCckHLZrJbjmu6DDjjbcnN2TCwne9MfK0BmoZmu6FtQXOWKHxbD2sBIH0KL9Dq9MAEaTnWyd8yYLDWETKnSAuAsQakZ3sESUYw0AARFfSswxeUZGrFehwdjjKiYj5WifixsoRERa/unH0CpHmVU0i0bs7TW/P5AU/GpdnlmqagAP5JwEdYt+SfV2U7w/gn97ZSq6UfuD+I4iMiUIhswiEUKYMvI7NhceC2g9aJE8mPA8YKfhrLm3uOqOuUYRE6sA== X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123563025)(20161123556025)(20161123561025)(20161123565025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2362; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2362; X-Forefront-PRVS: 04583CED1A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR03MB2362; 23:EWwwoXyWvSBZHFMNT9yOvRgb0hCdbkn4SV33C?= =?Windows-1252?Q?HnV5yeYSq6Bw1wSnmIEHI/l9QgDdXoE3VtyN6Blm6tvPp6hRtur8SpH6?= =?Windows-1252?Q?3wGYymewzx5lwDsdVJ17XPdbnEMkQZmB76DJxIs9gtl6XcmslMfp4Hjy?= =?Windows-1252?Q?AbJn34Yc2Mgt1wH0w6L0ZvVoAqHUFsz1bOZ5qS3Ij7NKNoL+mpONnAN6?= =?Windows-1252?Q?WrXK833A3vRoKErq5hUYDUzfTHHvYsFjkemo7Rjq16NqQ0GeUpSiF0ra?= =?Windows-1252?Q?q6IKJNETfJut869HkSRucjU8mar5c1EStXR7I1AThj/XpOyn3UMoUxlm?= =?Windows-1252?Q?YQ2ZaN7gVjiBQlxMQjNZXsKgEpLhD0VqPh8ObILpSy6mmwKTcQUxMlwV?= =?Windows-1252?Q?7OvbMqG89QZ4kNzFO0H/tlSu9mFT38Jzn27zwuaMsLXEAv8lUBMM1hYq?= =?Windows-1252?Q?SNsFS6Q1FvUbRBzBBD1+K1hy96BgAJNcVe7LpFKOVBBYxNIyOUB7Bgct?= =?Windows-1252?Q?zPb2brSnakTZUJNXE/6C4QTMwBZiYmEFjUOBVgd6TdChTAE4Qfa+1SSP?= =?Windows-1252?Q?nt/0SQL+74HcJwwyog9cWxQmp4sWV5CIyr69QEy0XI8UpROVx7e24H/I?= =?Windows-1252?Q?F94dpZ2rGsSFADy/cc5iYxIdJmEknogW4iO1D8FU7EltuloaIGgMo1Nn?= =?Windows-1252?Q?UmOC0JHn91hezyYuebfUgeHmAET2xRJJpfNHBZ2f7NlqvWW7UaLoM1J0?= =?Windows-1252?Q?yCJb+1PHMjXK2bOoOJ+7MD9RSYDM8nR5pAxZRcPUI/Dpn8FAmOJ6F6Kq?= =?Windows-1252?Q?TQs87IXNyTZz/vUoOHOZlfxKCvCgdNpfo6HCfK6wResOlKHZm9/BXSjr?= =?Windows-1252?Q?WEb3DVhLA+KiY47n80O63p2EdQMzB4fNXBBH3kNMnKaZkEHBpAGdNYsW?= =?Windows-1252?Q?/Zf1rp9IUGhl+WfhcT8Ya1Rb4EAg7HNxQGsu0ZXGzPNqYDogkiRGJpjy?= =?Windows-1252?Q?Zy0kLOBk35BLsuV5PuH8zXDaXtdr9KtyVPBcQYKVeJDx/G6+8548UkE/?= =?Windows-1252?Q?z1cmVvvnjm6RQIrsdkp5p8B7jqlMBT+TU7NY1/3LtfoOhXU9Qm3xKN+5?= =?Windows-1252?Q?tpiOmKYDklnmzAeSHT+rexJrFHHiuS6upAS5Te5K0smAS4hfl8WHZcta?= =?Windows-1252?Q?7X/yKUg6tpIGR6XVZ095TSJJcFWkR5ty953sSH+/XdbtQQqMh20tlPdY?= =?Windows-1252?Q?lsWiqhbitz97+qbzB7mJiN0xss7TN5GYPIFasJuQD9AZWvgp23KyHzmQ?= =?Windows-1252?Q?QAJoGAOMkVMS+w/Mn7sQrI8ICbXSw0W9UY0XZ++LSlBWThZ1V+JOgVvo?= =?Windows-1252?Q?grsxOcSUApW+eKyn9C8JqldT8emkQcpU+BO6GP8QQSD8DycMPGuUpPrX?= =?Windows-1252?Q?4JLXX/b0my3eXbFNteEXtTrsO143QyelimrFQXY/O/4JrNFZvVR76QAs?= =?Windows-1252?Q?Fljyi+k9ormSYwNsQplxgtMCg29rbhKH4xLO+00gBEYsXexgw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 6:b5m0dld/ZOrayG0l6viva4pO/i9gVZR/XRR67CroAF1U/B/kpTI4lHaO8fdWwRYVi1pgLjq44YtHuO+GFp46yJ0BHqNzk+xI1K7gfHHdZpumN/fbUjc5DPxpvFElRcDfHW7SL2XunDXaXZx5Y09GbD4pD0X8YjCjEVjdGTjGgGFcZO/DODGkymErXX+GgxmqCuE9+QeQMiJPTUDvP+qPX9ays/l7dfE2fXSjboqISL2tTuopbIcmZq7PdpZbDorb3JWZEF4lRVS3RsstkMG4Er+1s5zDirD6vi9SE92jPOF9ITIJK5irIdULsZrmZ77d1LxgXJyxAOx081jeOwmCQw==; 5:8UNNvDwqNrLyYugW+cNdSB/k4DkUYzO0zvh06ZobImQ7SlW3FOxHSL9NbP0hX3bzvwKDdEkLS/0GoBUbw22XU75GsZA2K9ouHcTnyriFDuVXKRZFAAg1GcR5F+RkmBxrXLf/iGeOAbBA8f/4/FwmuQ==; 24:itocw1E1r+aDGQBwY+HJkUiwmXMr771kd9ofGbR0Wtq6LA0FboP6bDsrqUcD2pXoSm8WEpRfFKYC2Ytj2L3zS7Krq8KrJBr3l123PTXSXVE=; 7:1cimfKjheo/B7AEO14PEoMCzQ33fY/SfAtv8DvdxwgJ7qycA1nb/ZrquA/prY6qepISU4DLu5Ng/IOHgymW2JEW88oc+9gRtxv9pE8zvnJat4ls7B1rMYiRDFbRtzH73XT7DAM4sjuGHQFFngpfp3MjTzdXVr9MJ5QfbToEd/0BLwYxgngJ4m+7k6eSQCxk4tHXHd68V0Q/QpadzxIAogcjBDt+JLlihpTTGKw80Sr8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 10:58:25.7511 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2362 Subject: Re: [dpdk-dev] [PATCH V3 2/5] ethdev: add new eth_dev_ops function for mtr ops get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 10:58:28 -0000 On 10/6/2017 8:15 PM, Cristian Dumitrescu wrote: > Following similar approach as rte_flow and rte_tm for modularity reasons, > the ops for the new rte_mtr API are retrieved through a new eth_dev_ops > function. > > Signed-off-by: Cristian Dumitrescu > --- > Changes in v3: > - None > > Changes in v2: > -None > > Changes in v1 (from RFC [1]): > - Removed ethdev API function to get the MTR ops, as it is not needed > (input from Thomas) > > [1] RFC: http://www.dpdk.org/ml/archives/dev/2017-May/066888.html > > lib/librte_ether/rte_ethdev.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 99cdd54..a5802b0 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1424,6 +1424,9 @@ typedef int (*eth_filter_ctrl_t)(struct rte_eth_dev *dev, > typedef int (*eth_tm_ops_get_t)(struct rte_eth_dev *dev, void *ops); > /**< @internal Get Traffic Management (TM) operations on an Ethernet device */ > > +typedef int (*eth_mtr_ops_get_t)(struct rte_eth_dev *dev, void *ops); > +/**< @internal Get Trafffic Metering and Policing (MTR) operations */ > + > typedef int (*eth_get_dcb_info)(struct rte_eth_dev *dev, > struct rte_eth_dcb_info *dcb_info); > /**< @internal Get dcb information on an Ethernet device */ > @@ -1548,6 +1551,9 @@ struct eth_dev_ops { > > eth_tm_ops_get_t tm_ops_get; > /**< Get Traffic Management (TM) operations. */ > + > + eth_mtr_ops_get_t mtr_ops_get; > + /**< Get Traffic Metering and Policing (MTR) operations. */ > }; > > /** > Reviewed-by: Hemant Agrawal