From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0059.outbound.protection.outlook.com [104.47.42.59]) by dpdk.org (Postfix) with ESMTP id 6528C2A58 for ; Mon, 12 Sep 2016 07:10:04 +0200 (CEST) Received: from BY2PR03CA070.namprd03.prod.outlook.com (10.141.249.43) by BY2PR0301MB0711.namprd03.prod.outlook.com (10.160.63.153) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9; Mon, 12 Sep 2016 05:10:02 +0000 Received: from BN1AFFO11FD020.protection.gbl (2a01:111:f400:7c10::192) by BY2PR03CA070.outlook.office365.com (2a01:111:e400:2c5d::43) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9 via Frontend Transport; Mon, 12 Sep 2016 05:10:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD020.mail.protection.outlook.com (10.58.52.80) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.619.6 via Frontend Transport; Mon, 12 Sep 2016 05:09:59 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8C59uCu012215; Sun, 11 Sep 2016 22:09:57 -0700 To: Yuanhan Liu References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> <1472704915-13112-2-git-send-email-shreyansh.jain@nxp.com> <20160911121531.GW23158@yliu-dev.sh.intel.com> CC: , , From: Shreyansh Jain Message-ID: <2d7081b0-b578-86b5-fe9f-a65a50bef754@nxp.com> Date: Mon, 12 Sep 2016 10:40:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160911121531.GW23158@yliu-dev.sh.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131181306013296276; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(199003)(189002)(377454003)(69234005)(24454002)(9170700003)(23746002)(4001520100001)(87936001)(77096005)(36756003)(105606002)(11100500001)(356003)(4001350100001)(4326007)(189998001)(106466001)(76176999)(54356999)(586003)(50986999)(92566002)(50466002)(31696002)(86362001)(626004)(2906002)(230700001)(83506001)(85426001)(2950100001)(81166006)(65956001)(19580405001)(19580395003)(8676002)(65806001)(8936002)(5660300001)(7846002)(33646002)(110136002)(305945005)(31686004)(64126003)(104016004)(65826007)(47776003)(5001760100003); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0711; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD020; 1:Bz6uROeP3M4ZBqppSJW7auZ6k7sWuxxIlgGZEjAcq1daU5/fNc6VX44U5uMKMobzxWnuN4KpWRndlX8BK0GUvYpMMh0IcbIgUiwJHyhqJHRn1nFpqw8DTkm3sxsd0dmxkHGn5SfhXVdorGajYd41l74wNSgsauNOe3uXM7sL5FW4yomokfj4MxEl5otNpPp+VhcOxMXjKKrsvpca1fx9BV0ENYeJwT3v5hKteV8NGdAYH7S5FOuBRIO+BMj5xiVvT3EARRlMhGfKr6fbGHBTOZ/4NE3CRm13i8UedXlNl2KP74aRcphnfNZuUmTDWpLz1LAJg4OA71HdUO3TJk7EcHFuPH15PjpEfqEi6z3dg+GH6EL8JAAAw/jm8U2waLf16XcnGtdy0NRoOWN9jOkZAvZdRn1MUWoFjEYcPW4cu3zez0GeEH47U/QB3BCUSH7tw2WpSTvjWBsYPP8jkhmLXd9rcwOL57HLn0bKOK+XdnvaFTnsGaIUqwAqLl3mBgjBW1iDQ2y5E81KN03Tk9xD3Ripb7bf4YA2HKu5Gl5WTWJDvS7KsJg7pceZc3B5evjDwAqpGPKzmDTyE9KAsP4UFsk7XN3FD2lowqBr6jtvJhvGKE0AaK7lvOHnRuimgq9rCD+aeRUb3rvG11iZQVFe4w== X-MS-Office365-Filtering-Correlation-Id: 2a79978a-6247-4c76-c534-08d3dacb0c8c X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0711; 2:phMC+R7vt7rkaPBiyJk23m2B6IMij8UKaBMQvEaDypHzAU6rQTuUCHc6yndPqpF+u0KENDHpsq7lCOYdbRPV2Slyyx0Jyk5AuRqa+PWZKrGWgNb7HRhu1CxB+2JRRiUZ8TA34WmWuILM2FmsmTvZAmCuuv+1ksnf6JWP/b2Qa38wORJ4qFeU9CRKnmaKJJUx; 3:V15gUD6ZbH/AnpKArmIdk46C2iq07Svi51P43uBTt091yX/ZSNsXD8t4naknaPgCRmt9HRl9BY+e+fNFBVhPYgItjIADE/+KjhNo+28ihbsrcfqEJWXl1mjdETDH6F916v1CJLi0CIk8bZ/9nXUSj47W9jc33rqhjE82MJUVTyn10KSoO5/Sse0Q5dgbCc+WEAFF+W/hAAGiJzjN5Unq8OHwprQ+oe+KrruRHjWbnGQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0711; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0711; 25:Af+UpDGkIhK9BzPA84hdZmUkO4oaGJPy1QiIOfThERZgAZwI+bY8bTu3K5QJkbuQ1q7Pdy5XKpYv5FssqY/UoZyAQnvC6/4WfTaud4pVejznavtzlqyVfMurGrC1qemD7kOmfbWiOMMYNzU+kg7CoSa5GgyZmLsoc8B4tHSLXPiNJiNMEETtz2sUg1uKPGWBccpQrFMAtbkUTPJ5OgrrDXrQ78Ej40NtzClVzpjDzlyArpwQ8fNbzHWUT5/i+7CS3ZoISen+304kuCFIw44EpMwbiWNR4rkWLwPrkPDWQIHEEZCv49nVVfemhQBFAOeKIyqFEFz6ks4XpS9NnTXPdt0mSM6U5q3LhW7ENh8GuSTk65Mk8En1Nsvcqq/yjilObnFfPktl90V6RSOvqEGvCZhAPfP07vCSuZ1oyby7UjXFlNIrxhrFeEZ0oKtadJb9Ke5aQb/fmc5YqISeR4c35CxZhw8kagYzRLxqePqsiTaAf3DcVajxmo6VRQPQWq43+Zlywh2DIPyP1jrku+G6KgkCMBMy3Oto5toSNSGYsOaMHXj7nq+NYa3qxid/WG39v2p0/fHuY6v0YIlmClImsNoS3aS4OgeSmBJrgYif26QVVFRj1PNkeGUn5b2WVwlQGdQex9vos1yRUBbj2yd2lLEDMNFyTDx5cKmzDBjwHQ8A45zb6wy+ghqWaR30+vaMTgijUHTYe2GH53z9uKF7PSj7QcU+GkyhVcndkEOHW54= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0711; 31:02TdnvVHvZcLF4DIYSpzQXiToXJ5ETqOHHkIYSmNYjGy/n+axqbjGWEWCSt9TDW2OSvhx9bZYLLMKPIdECsSVFfa03XlkULmm3qGC4xKvFX66/xZppEAeosEZ/LVnFQStXwxrFWQUJeHD4qdPeLnv86JW48K+bpA/mYhpFh/Gn2+uGLoWTIX/QwwuBXb2s0q+E4aOPPtCoVeSEyY0jVUkxrriHuAAs2x3D5c+9Ugs0k=; 4:gD/L6wI5a2sSBavHhPW8867dq6hGjyNzH6ZRU2f3fhIQeOS1jLfVxhndg3tQXYCyoe5rLJPTIDrJ7bQcgh4Jq5cfF3Uq4zrtjefrM3YzbI5DXo3ftqOipnyDXaVB+dSpdLeGoueVp7nJbprD7gPW7CyUvhu/hQuMi7ZdONi9Q1ukYwUhOjDaacYzL1QdXI6n/S6P+KNJwihJnmEuHUuKVFM2AFa6BC8YWf/i0LZQ48alzTdcWE7hVVm9aY/qCKVbdxN5IHZQwDxgyjBmk7aArtDXlcYr/AVqy6aA3rhI4wbMN4Yyzlw3yy06EjtmEuGVwJ1J8prypw9NcKO0CI+vYglkwR9bg8W3aJ1PiEeQaLk0ehL2sAfOQw1GomfpSuN9JJIo+rX3tVREje7mYXFJ3+8dRZasEOfplxkWMxcmMa1llOfaCiof/EresirF/1p19GNjg/i4qLkg2Q0/WsAeEzCKJGKG827rzvi2PBpcs5NhBVkTZjjQgtG7/L6bzuky5jY5VQDyENi+QEbyiN4wxhv4VhF5twzWa9+zgwO4m4Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13017025)(13018025)(13015025)(13024025)(13023025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BY2PR0301MB0711; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0711; X-Forefront-PRVS: 006339698F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB0711; 23:dlTrCruHKuPk2HJwM8+mxmX3KLwzwcV40n0?= =?Windows-1252?Q?k9WzX6InVhiXuM3WasvjmDuVnW5Try01W2XO6bJ3DzWCCt3pUY7nPhPV?= =?Windows-1252?Q?A6BrpRSX8k/RHizAV8YqIXU/dYG5l17Wqrt9wWJfowFYcmbfY55+2U8v?= =?Windows-1252?Q?YRbZVWlvqNbTuEBZe4BgpTCR/RiQD7MqWg8JYqJo9K5QDRCxKylfC1eX?= =?Windows-1252?Q?OF8s2vHq6uTmoC2l9I5uKU51d1fjrOZkE1UpTTRoecamM3Z+/8DwIVuN?= =?Windows-1252?Q?7G6FgZSodHAsbJdf20CJfEdE3PAsjcmow+ch0xQ87uVcT4zX9/Qrzeki?= =?Windows-1252?Q?PMdyi3XdcXlqcI7lAMjqTI9zRig5eJYdgHYWeeR439GHkNYZjqxXvMgH?= =?Windows-1252?Q?twjpH/7BIZHdDp6ou+PWZ7AXDIuLk8E+3g/brfPdG0m3JLg3rCz4asl5?= =?Windows-1252?Q?IduFdy6FwEN+zdyN6pCMj7DgyB3kuf1Me9AUmffQ4BKxXxim54aUSaDz?= =?Windows-1252?Q?TK+sUcV69PYT5rICwzlgahL1q1Pud59F0rtWNIStmgPD0ySv7JSJ6Dzc?= =?Windows-1252?Q?enls75bm2tP+C/j1PdFzZlkAk9D9tnEZqj6oLqP//FsymfIRtRIBV8w9?= =?Windows-1252?Q?IOU2LIfJeDdV6h54rncXr+zpo9X7VPyJOCN5DLZZKV3lLrSmGvoJTSRS?= =?Windows-1252?Q?io7UfdD2cipQdCB7NY26Vu/gZ4ESXWskClJ2NcVUmdg044PcLO/wo1I1?= =?Windows-1252?Q?zgwTH/BC+toWQSP1IxeGoJM7s6UIFmsPqGopzBJNXPZHL2s9UFZMc5QA?= =?Windows-1252?Q?RfWYFL+rRsDe0BSGOSZJpyfkWTv3UiQaK8It3MhiqG66LGNjmW+RmWhy?= =?Windows-1252?Q?LKuCH1zBfEPReOnq88mpPzbooMjVj6goYXpwikqVpP9zwJkguYsUwVM7?= =?Windows-1252?Q?GGpgclKSXzZgQN3nPS0Sig7U/m5PbAf+Pf5N8WXY4PC/l9ApiV5GGzx0?= =?Windows-1252?Q?aq/dkrmI1ciHvBSl2LAjDMDrqJpI4fCLBRJKlR152qbVHqK90TJ6bkw8?= =?Windows-1252?Q?OGDMiFD2NvKZJPYoKTgtqMv8IEjDfz5XUwI/wLhP/VUzvJ7GI0LiyxJ1?= =?Windows-1252?Q?cEgEBb7ajVPajg76Y7X/3nF1bwGeFhC3LpzbDjbZeSf67+SfOhin5qM8?= =?Windows-1252?Q?7z+f6AepTYjRdzn6RPy2rVKKCu4u/hNcZYj4Ao9+Lj9p9RyyfbwIJCjz?= =?Windows-1252?Q?wveX+7+yeF9Q1EJO/jW4Qohm6FWZIbJvVDszQBpx0jSzJ7TXP3vy0OFP?= =?Windows-1252?Q?bDXMhxmkNY0JAi+eMCWsEIl/2V0BRWqdoaOW5/4RuxZ0cvnleGn2FoMc?= =?Windows-1252?Q?fMC/asLiDuBZQfRxrob2mKSrO6az8wxlxYLWFkVXVG8rbGOpcUphVWX4?= =?Windows-1252?Q?I9ioWJ6b6IgpkhW+OLtUZQQrHs/c7J/NgpQhnqsA6ZzrHQWhtKf+ZIFY?= =?Windows-1252?Q?DWJcZGD0=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0711; 6:cM6tPEHP8ny+j8/psvEp2e9Bo1N+dz0lMDsZwauvLT5gDf05DjJKJ9JKhcwqqmMz7kMgW67LHlfYCCSFzFzWWEuuvzJ9jLLu5dtYez23WVVJCiNJFV+oIMzNQI+C4N6bw2SBJTUZijxFmGleM2PXu/rDx69gcwbanDbj5C0AwpWEsttEQ3MXXviIv5r/HpaSIGEnmZ3jSBK9PijgKKEKL3d3G4YATITWsJWRu8n+EEa+ZhDcPcNUwjiuJGuol17GLYotwvZwDsKuolltq6V2PHmSZHI3W7C2N3G+0QeefkA=; 5:0R0wPvvT/fCGlLy6RzMOW8trNN4TQNunDB3csH2WTLTEEdkDyTeVSGVDhPGrsPYwuSrIR30lCAiNMSOWo4jNcZw+XHt6Ojc1uv5HY+WF2gdpfqTwRRNqPwnpxS92yS2xOZsEXfjhEkTikou6jffPbSvaNsLDyGsJKItUXg5a7F0=; 24:ZBBJ+1o/m2p6gWkujLCzg0E5jLAV9JrWMt4itJOW9MCbWo2pL1bfgI1zmuGJVYOSA0dAwAvv7oFbLZjuuuNfp+OJ3F7h33gFw9BPIhhxncE=; 7:wYRgBXeRApKnodwrGhr/shNO4C7Ky+LIKWOfu3bCpckofX0+BqdwFSO27ZJLiYUUQ97Oily3aXKwNJPetSuNLm2QHczM5J87qkP6O5gmwr6t6Hk8WpSGS3K1JpDAzzCWukeo4HCLlacnSZ+wa0lT54SDQfyzAciujkmi8Kce1ykXLa0hirMpZ7Mh6TDaU5owQqJ4BrAT2oKyXEZhe8z6H7Q1e+25XfSN0gWnZhMHI04k065mXWfSuWlxWBglwqAv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2016 05:09:59.7228 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0711 Subject: Re: [dpdk-dev] [PATCH 1/5] eal: make enum rte_kernel_driver non-PCI specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 05:10:05 -0000 Hi, On Sunday 11 September 2016 05:45 PM, Yuanhan Liu wrote: > On Thu, Sep 01, 2016 at 10:11:51AM +0530, Shreyansh Jain wrote: >> From: Jan Viktorin >> >> From: Jan Viktorin >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain > > Hi, > > FYI, my testrobot caught some errors when this patch is applied. > > --yliu > > --- > i686-native-linuxapp-gcc: config-all-yes > ======================================== > In file included from lib/librte_eal/linuxapp/eal/eal_pci.c:38:0: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c:52:0: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_thread.c:55: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > make[7]: *** [eal_thread.o] Error 1 > make[7]: *** Waiting for unfinished jobs.... > In file included from lib/librte_eal/linuxapp/eal/eal.c:72:0: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_memory.c:97: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_log.c:50: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > make[7]: *** [eal_log.o] Error 1 > make[7]: *** [eal_vfio_mp_sync.o] Error 1 > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_vfio.c:45: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > make[7]: *** [eal.o] Error 1 > make[7]: *** [eal_memory.o] Error 1 > make[7]: *** [eal_vfio.o] Error 1 > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_map_device': > lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: note: each undeclared identifier is reported only once for each function it appears in > lib/librte_eal/linuxapp/eal/eal_pci.c:139:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:140:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_unmap_device': > lib/librte_eal/linuxapp/eal/eal_pci.c:160:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:163:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:164:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'pci_scan_one': > lib/librte_eal/linuxapp/eal/eal_pci.c:381:16: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_VFIO; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:383:16: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_IGB_UIO; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:385:16: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_UIO_GENERIC; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:387:16: error: 'RTE_KDRV_UNKNOWN' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_UNKNOWN; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:389:15: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_NONE; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_map': > lib/librte_eal/linuxapp/eal/eal_pci.c:626:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:631:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:634:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:641:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_read': > lib/librte_eal/linuxapp/eal/eal_pci.c:662:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:666:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:669:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:672:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_write': > lib/librte_eal/linuxapp/eal/eal_pci.c:688:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:692:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:695:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:698:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_unmap': > lib/librte_eal/linuxapp/eal/eal_pci.c:715:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:720:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:723:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:730:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > make[7]: *** [eal_pci.o] Error 1 > make[6]: *** [eal] Error 2 > make[5]: *** [linuxapp] Error 2 > make[4]: *** [librte_eal] Error 2 > make[3]: *** [lib] Error 2 > make[2]: *** [all] Error 2 > make[1]: *** [pre_install] Error 2 > make: *** [install] Error 2 > error: build failed > Thanks for highlighting. That is my mistake. While sending the patch my intention was to highlight that these are more as a RFC than direct patches. I forgot to add that and didn't notice it after posting either. Problem is that this patch moves 'enum rte_kernel_driver' to rte_dev.h from rte_pci.h. All the above errors are reported by files which still include rte_dev.h. I was hoping that if these patches look fine to all, I will update all the headers and send again. -- Shreyansh