From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE760A0A03; Mon, 18 Jan 2021 18:10:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 987B0140D63; Mon, 18 Jan 2021 18:10:27 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 71DE9140D54 for ; Mon, 18 Jan 2021 18:10:24 +0100 (CET) IronPort-SDR: A5yOciEvqR2dJRLDrQU0dmIcihxBs7Ccpo1pKKzbnQWQvE5JoYhB/2oS4M0fhy1b8vnwTNkAYE a3MNfQ1rS3xw== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="166494555" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="166494555" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 09:10:23 -0800 IronPort-SDR: WpvKpj4MV25Ogf4wLZJosix9qlZXZesR93BcNN3bgMI9jfC/jJ61SvkI/uY8mwRAefoEr3uHTx Ry0n0B8Lz1eQ== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383630484" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24]) ([10.213.241.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 09:10:21 -0800 To: Andrew Boyer , dev@dpdk.org Cc: Alfredo Cardigliano References: <20210111190209.70928-1-aboyer@pensando.io> <20210111190209.70928-7-aboyer@pensando.io> From: Ferruh Yigit Message-ID: <2d80000a-6df4-36fd-8df7-1dafaf92d451@intel.com> Date: Mon, 18 Jan 2021 17:10:20 +0000 MIME-Version: 1.0 In-Reply-To: <20210111190209.70928-7-aboyer@pensando.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 6/6] net/ionic: correctly set link speed and autonegotiation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/11/2021 7:02 PM, Andrew Boyer wrote: > Don't assume autoneg in link_update(). > > Always call ionic_dev_cmd_port_autoneg() in start(). > > This allows the client to specify the link settings. > > Signed-off-by: Andrew Boyer Fixes: 598f6726390f ("net/ionic: add basic port operations") Cc: stable@dpdk.org