From: Sinan Kaya <okaya@codeaurora.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: support PCI domains
Date: Tue, 4 Oct 2016 09:59:58 -0400 [thread overview]
Message-ID: <2d9df664-7b51-a0d5-4073-5bb386e8433c@codeaurora.org> (raw)
In-Reply-To: <3354300.QnNDgIpU56@xps13>
On 10/4/2016 4:15 AM, Thomas Monjalon wrote:
> 2016-07-22 18:56, Sinan Kaya:
>> On 7/22/2016 5:12 PM, Stephen Hemminger wrote:
>>> On Fri, 22 Jul 2016 11:34:10 -0400
>>> Sinan Kaya <okaya@codeaurora.org> wrote:
>>>
>>>> The current code is enumerating devices based on bus, device and function
>>>> pairs. This does not work well for architectures with multiple PCI
>>>> segments/domains. Multiple PCI devices will have the same BDF value but
>>>> different segment numbers (01:01:01.0 and 02:01:01.0) for instance.
>>>>
>>>> Adding segment numbers to device naming so that we can uniquely identify
>>>> devices.
>>>>
>>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>>>
>>> I ran into this yes. There is a small risk of breaking some application that
>>> assumed something about names though.
>>>
>>> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>>>
>>
>> Thanks, hopefully the change is minor and can be contained until next release.
>
> It is part of the EAL rework.
> The function has been moved in EAL and includes the PCI domain:
> http://dpdk.org/commit/affe1cdc
>
Thanks for taking care of it.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2016-10-04 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 15:34 Sinan Kaya
2016-07-22 21:12 ` Stephen Hemminger
2016-07-22 22:56 ` Sinan Kaya
2016-10-04 8:15 ` Thomas Monjalon
2016-10-04 13:59 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d9df664-7b51-a0d5-4073-5bb386e8433c@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).