From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by dpdk.org (Postfix) with ESMTP id 28F5D2BA6 for ; Tue, 4 Oct 2016 16:00:01 +0200 (CEST) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4842061AAE; Tue, 4 Oct 2016 14:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1475589600; bh=6DTS1EF93MOq0NoQrzS6U2mq5/7dmrVFLZODzmInVbA=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=YgWcvKTe2xG2D2UawhWmRXQuteKFkYn+aorCzdcczme+kHuh7EfrRw6W3fhVbOC++ f+IeXxYPTMve6Owe6VdDbOC0oCCCqkyLrCuPxHhJZppoWot2uuXjhjlr9nvxr/n060 H7IBmys33dTQP12w82ikkt44VHhrn5V/1oj5BU0Q= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.228.68.32] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A268E6184B; Tue, 4 Oct 2016 13:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1475589600; bh=6DTS1EF93MOq0NoQrzS6U2mq5/7dmrVFLZODzmInVbA=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=YgWcvKTe2xG2D2UawhWmRXQuteKFkYn+aorCzdcczme+kHuh7EfrRw6W3fhVbOC++ f+IeXxYPTMve6Owe6VdDbOC0oCCCqkyLrCuPxHhJZppoWot2uuXjhjlr9nvxr/n060 H7IBmys33dTQP12w82ikkt44VHhrn5V/1oj5BU0Q= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org A268E6184B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org To: Thomas Monjalon References: <1469201650-32447-1-git-send-email-okaya@codeaurora.org> <20160722141259.35ea0a7e@xeon-e3> <3354300.QnNDgIpU56@xps13> Cc: dev@dpdk.org, Stephen Hemminger From: Sinan Kaya Message-ID: <2d9df664-7b51-a0d5-4073-5bb386e8433c@codeaurora.org> Date: Tue, 4 Oct 2016 09:59:58 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3354300.QnNDgIpU56@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 05 Oct 2016 10:57:03 +0200 Subject: Re: [dpdk-dev] [PATCH] ethdev: support PCI domains X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 14:00:01 -0000 On 10/4/2016 4:15 AM, Thomas Monjalon wrote: > 2016-07-22 18:56, Sinan Kaya: >> On 7/22/2016 5:12 PM, Stephen Hemminger wrote: >>> On Fri, 22 Jul 2016 11:34:10 -0400 >>> Sinan Kaya wrote: >>> >>>> The current code is enumerating devices based on bus, device and function >>>> pairs. This does not work well for architectures with multiple PCI >>>> segments/domains. Multiple PCI devices will have the same BDF value but >>>> different segment numbers (01:01:01.0 and 02:01:01.0) for instance. >>>> >>>> Adding segment numbers to device naming so that we can uniquely identify >>>> devices. >>>> >>>> Signed-off-by: Sinan Kaya >>> >>> I ran into this yes. There is a small risk of breaking some application that >>> assumed something about names though. >>> >>> Acked-by: Stephen Hemminger >>> >> >> Thanks, hopefully the change is minor and can be contained until next release. > > It is part of the EAL rework. > The function has been moved in EAL and includes the PCI domain: > http://dpdk.org/commit/affe1cdc > Thanks for taking care of it. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.