Re: [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists

[Ranjit Menon <ranjit.menon@intel.com>]

Hi Khoa,

On 2/18/2021 10:40 AM, Khoa To wrote:
> EAL -a and -b options are used to specify which PCI devices are
> explicitly allowed or blocked during PCI bus scan.  This evaluation
> is missing in the Windows implementation of rte_pci_scan.
> This patch provides this missing functionality, so that apps can specify
> which NetUIO devices to ignore during PCI bus scan.
>
> Signed-off-by: Khoa To <khot@linux.microsoft.com>
> ---
>
> v2:
> * Truncate commit description lines to 75 charaters or less
>
>
>   drivers/bus/pci/windows/pci.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index f66258452..0bba05eb4 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -396,6 +396,7 @@ rte_pci_scan(void)
>   	DWORD device_index = 0, found_device = 0;
>   	HDEVINFO dev_info;
>   	SP_DEVINFO_DATA device_info_data;
> +	struct rte_pci_addr addr;
>   
>   	/* for debug purposes, PCI can be disabled */
>   	if (!rte_eal_has_pci())
> @@ -420,6 +421,13 @@ rte_pci_scan(void)
>   		    &GUID_DEVCLASS_NET) ||
>   			IsEqualGUID(&(device_info_data.ClassGuid),
>   			    &GUID_DEVCLASS_NETUIO)) {
> +
> +			if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0)
> +				continue;
> +
> +			if (rte_pci_ignore_device(&addr))
> +				continue;
> +
>   			ret = pci_scan_one(dev_info, &device_info_data);
>   			if (ret == ERROR_SUCCESS)
>   				found_device++;
I think this change can be made inside the pci_scan_one() function where 
we already call

get_device_pci_address().

ranjit m.