From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74B2CA0547; Fri, 12 Mar 2021 16:19:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 637241608B9; Fri, 12 Mar 2021 16:19:54 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 0B998406FF for ; Fri, 12 Mar 2021 16:19:52 +0100 (CET) IronPort-SDR: V4FTwO8muGRaUjAteRQyWZWoBd35bdv+6UqAA8GYUCMzojpYVVNqaqg/G0ZU3cSxvLQ3HIeZgE 0SkBrKYtA+yw== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="250209688" X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="250209688" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 07:19:50 -0800 IronPort-SDR: ePDmTfO1gDDsQWmb7ciukcF6BBy/MmHDqOGYgPraUMivEMHacTLRDdCVCorVeGIBiOD/LNVLTu 8a04NvK/lhBA== X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="510352554" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.11.60]) ([10.252.11.60]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 07:19:44 -0800 To: Tyler Retzlaff , dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <2da8b376-9016-11e6-8891-6db3957c7d79@intel.com> Date: Fri, 12 Mar 2021 15:19:36 +0000 MIME-Version: 1.0 In-Reply-To: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > Introduce a meson option enable_driver_sdk when true installs internal > driver headers for ethdev. this allows drivers that do not depend on > stable api/abi to be built external to the dpdk source tree. > > Signed-off-by: Tyler Retzlaff > --- > > it's still unclear to me if we should be renaming the headers: > > ethdev_driver.h -> rte_ethdev_driver.h > ethdev_pci.h -> rte_ethdev_pci.h > ethdev_vdev.h -> rte_ethdev_vdev.h > > lib/librte_ethdev/meson.build | 5 +++++ > meson_options.txt | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > index c37b2e377..7ecdec6f0 100644 > --- a/lib/librte_ethdev/meson.build > +++ b/lib/librte_ethdev/meson.build > @@ -20,6 +20,11 @@ headers = files('rte_ethdev.h', > 'rte_mtr_driver.h', > 'rte_tm.h', > 'rte_tm_driver.h') > +if get_option('enable_driver_sdk') > +headers += files('ethdev_driver.h', > + 'ethdev_pci.h', > + 'ethdev_vdev.h') > +endif Instead of adding the "get_option('enable_driver_sdk')" checks to the modules, what about a more generic solution, like: modules assign relevant headers into a new variable, let's say 'pmd_headers', and in a high level meson file, all 'pmd_headers' are installed if 'enable_driver_sdk' enabled?