Re: [dpdk-dev] [RFC v2 5/6] net/ixgbe: define the mirror filter parser

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/3/2020 8:28 AM, Steve Yang wrote:
> Define the sample filter parser for mirror, it will divide to two phases,
> the one is sample attributions pattern parsing, and the mirror config
> will be filled in according to pattern type VF/PF/VLAN when sample ratio
> is 1.
> The another is sample action parsing that the port id of mirror config
> will be filled in according to action type VF/PF.
> 
> Signed-off-by: Steve Yang <stevex.yang@intel.com>

<...>

> +
> +#define GET_VLAN_ID_FROM_TCI(vlan_item, default_vid) \
> +	((vlan_item) ? ntohs((vlan_item)->tci) & 0x0fff : (default_vid))
> +

Although ixgbe is not build for windows, better to use 'IXGBE_NTOHS' for 
consistency.

>   /* ntuple filter list structure */
>   struct ixgbe_ntuple_filter_ele {
>   	TAILQ_ENTRY(ixgbe_ntuple_filter_ele) entries;
> @@ -79,6 +91,11 @@ struct ixgbe_rss_conf_ele {
>   	TAILQ_ENTRY(ixgbe_rss_conf_ele) entries;
>   	struct ixgbe_rte_flow_rss_conf filter_info;
>   };
> +/* rss filter list structure */

copy/paste error?

<...>

> +	if (attr->group) {
> +		rte_flow_error_set(error, EINVAL,
> +				   RTE_FLOW_ERROR_TYPE_ATTR_GROUP,
> +				   attr, "Not support group.");
> +		return -rte_errno;
> +	}
> +	if (attr->transfer) {
> +		rte_flow_error_set(error, EINVAL,
> +				   RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
> +				   attr, "Not support group.");

copy/paste error?