From: Ivan Malov <Ivan.Malov@oktetlabs.ru> To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org Cc: Ray Kinsella <mdr@ashroe.eu>, Jerin Jacob <jerinj@marvell.com>, Thomas Monjalon <thomas@monjalon.net>, Ori Kam <orika@nvidia.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Andy Moreton <amoreton@xilinx.com> Subject: Re: [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath Date: Tue, 12 Oct 2021 22:39:32 +0300 Message-ID: <2db4ece1-7375-e492-c556-6b62b700e494@oktetlabs.ru> (raw) In-Reply-To: <e627ebbd-4d64-c49a-2dab-5fe94d610ce1@intel.com> Hi Ferruh, On 12/10/2021 21:08, Ferruh Yigit wrote: > On 10/5/2021 4:56 PM, Ivan Malov wrote: >> Detect the flag in Rx prefix and pass it to users. >> >> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru> >> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> >> Reviewed-by: Andy Moreton <amoreton@xilinx.com> > > <...> > >> @@ -407,6 +409,15 @@ sfc_ef100_rx_prefix_to_offloads(const struct >> sfc_ef100_rxq *rxq, >> ESF_GZ_RX_PREFIX_RSS_HASH); >> } >> + if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { >> + uint32_t user_flag; >> + >> + user_flag = EFX_OWORD_FIELD(rx_prefix[0], >> + ESF_GZ_RX_PREFIX_USER_FLAG); >> + if (user_flag != 0) >> + ol_flags |= PKT_RX_FDIR; >> + } >> + > > Hi Ivan, > > This cause a build error after another sfc patch merged into next-net [1]. > Following change [2] seems fixing the issue, but to be sure nothing is > missed > can you please send a new version rebasing on top of latest next-net? Done. Thank you. > > > [1] > Commit d86c6ced8732 ("net/sfc: use xword type for EF100 Rx prefix") > > [2] > diff --git a/drivers/net/sfc/sfc_ef100_rx.c > b/drivers/net/sfc/sfc_ef100_rx.c > index 704c62c0ac90..8237b772f151 100644 > --- a/drivers/net/sfc/sfc_ef100_rx.c > +++ b/drivers/net/sfc/sfc_ef100_rx.c > @@ -415,7 +415,7 @@ sfc_ef100_rx_prefix_to_offloads(const struct > sfc_ef100_rxq *rxq, > if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { > uint32_t user_flag; > > - user_flag = EFX_OWORD_FIELD(rx_prefix[0], > + user_flag = EFX_XWORD_FIELD(rx_prefix[0], > ESF_GZ_RX_PREFIX_USER_FLAG); > if (user_flag != 0) > ol_flags |= PKT_RX_FDIR; -- Ivan M
next prev parent reply other threads:[~2021-10-12 19:39 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-02 14:23 [dpdk-dev] [PATCH 0/5] A means to negotiate support for Rx meta information Ivan Malov 2021-09-02 14:23 ` [dpdk-dev] [PATCH 1/5] ethdev: add API " Ivan Malov 2021-09-02 14:47 ` Jerin Jacob 2021-09-02 16:14 ` Kinsella, Ray 2021-09-03 9:34 ` Jerin Jacob 2021-09-02 14:23 ` [dpdk-dev] [PATCH 2/5] net/sfc: provide API to negotiate supported Rx meta features Ivan Malov 2021-09-02 14:23 ` [dpdk-dev] [PATCH 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows Ivan Malov 2021-09-02 14:23 ` [dpdk-dev] [PATCH 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-09-02 14:23 ` [dpdk-dev] [PATCH 5/5] net/sfc: allow to discern user flag on EF100 native datapath Ivan Malov 2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 0/5] A means to negotiate support for Rx meta information Ivan Malov 2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 1/5] ethdev: add API " Ivan Malov 2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 2/5] net/sfc: provide API to negotiate supported Rx meta features Ivan Malov 2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows Ivan Malov 2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 5/5] net/sfc: allow to discern user flag on EF100 native datapath Ivan Malov 2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data Ivan Malov 2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 1/5] ethdev: add API " Ivan Malov 2021-09-30 14:59 ` Ori Kam 2021-09-30 15:07 ` Andrew Rybchenko 2021-09-30 19:07 ` Ivan Malov 2021-10-01 6:50 ` Andrew Rybchenko 2021-10-03 7:42 ` Ori Kam 2021-10-03 9:30 ` Ivan Malov 2021-10-03 11:01 ` Ori Kam 2021-10-03 17:30 ` Ivan Malov 2021-10-03 21:04 ` Ori Kam 2021-10-03 23:50 ` Ivan Malov 2021-10-04 6:56 ` Ori Kam 2021-10-04 11:39 ` Ivan Malov 2021-10-04 13:53 ` Andrew Rybchenko 2021-10-05 6:30 ` Ori Kam 2021-10-05 7:27 ` Andrew Rybchenko 2021-10-05 8:17 ` Ori Kam 2021-10-05 8:38 ` Andrew Rybchenko 2021-10-05 9:41 ` Ori Kam 2021-10-05 10:01 ` Andrew Rybchenko 2021-10-05 10:10 ` Ori Kam 2021-10-05 11:11 ` Andrew Rybchenko 2021-10-06 8:30 ` Thomas Monjalon 2021-10-06 8:38 ` Andrew Rybchenko 2021-10-06 9:14 ` Ori Kam 2021-09-30 21:48 ` Ajit Khaparde 2021-09-30 22:00 ` Ivan Malov 2021-09-30 22:12 ` Ajit Khaparde 2021-09-30 22:22 ` Ivan Malov 2021-10-03 7:05 ` Ori Kam 2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 2/5] net/sfc: support " Ivan Malov 2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov 2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov 2021-09-30 16:18 ` [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data Thomas Monjalon 2021-09-30 19:30 ` Ivan Malov 2021-10-01 6:47 ` Andrew Rybchenko 2021-10-01 8:11 ` Thomas Monjalon 2021-10-01 8:54 ` Andrew Rybchenko 2021-10-01 9:32 ` Thomas Monjalon 2021-10-01 9:41 ` Andrew Rybchenko 2021-10-01 8:55 ` Ivan Malov 2021-10-01 9:48 ` Thomas Monjalon 2021-10-01 10:15 ` Andrew Rybchenko 2021-10-01 12:10 ` Thomas Monjalon 2021-10-04 9:17 ` Andrew Rybchenko 2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 0/5] Negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov 2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov 2021-10-05 12:03 ` Ori Kam 2021-10-05 12:50 ` Ivan Malov 2021-10-05 13:17 ` Andrew Rybchenko 2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov 2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov 2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov 2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov 2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov 2021-10-05 21:40 ` Ajit Khaparde 2021-10-06 6:04 ` Somnath Kotur 2021-10-06 6:10 ` Ori Kam 2021-10-06 7:22 ` Wisam Monther 2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov 2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov 2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov 2021-10-12 18:08 ` Ferruh Yigit 2021-10-12 19:39 ` Ivan Malov [this message] 2021-10-12 19:48 ` Ivan Malov 2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov 2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov 2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov 2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov 2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov 2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov 2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov 2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov 2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov 2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov 2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov 2021-10-12 23:25 ` [dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2db4ece1-7375-e492-c556-6b62b700e494@oktetlabs.ru \ --to=ivan.malov@oktetlabs.ru \ --cc=ajit.khaparde@broadcom.com \ --cc=amoreton@xilinx.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jerinj@marvell.com \ --cc=mdr@ashroe.eu \ --cc=orika@nvidia.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git