From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DB28431E6; Mon, 23 Oct 2023 23:59:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D342402CB; Mon, 23 Oct 2023 23:59:07 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id D18C740275 for ; Mon, 23 Oct 2023 23:59:05 +0200 (CEST) Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39NLvPRe027490; Mon, 23 Oct 2023 21:59:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=PkINdtvVX4hVgeN6XmPYFObRTZpcwVZb9guFijXJo2s=; b=YyeQtfhdk9k+5M03ujmVxJpRtIEN716nyTouze3Dk7B3uYEQoxvAqfYuwMnsCUNAx4sD JRN9iheDaT1Z+IpZtdgOr1u+TpgvK8uWKVmf5tDcb6eeaSu3O/r0gOQe7o8XY1QMyPkv yL9m8Cti4uS6eiYFBq2ZC02a2CODUgTt+8niP2YYHEe0ftP5OPbC1N/ch8aZUhRyVgYz tJpJb2Jab+HzsxyS27xJIY+/uPWORYIVDhvVeK9WnxHbpyQ7ePQb6M0wgyIa/ylI+4ER pXyFdAWCaQkRCS3LgjtQ/oPbin/7MCsHwpnH6/zQrHDWX9xY3MUAySjIFEzPKgedLtne yQ== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tx16w84k4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Oct 2023 21:59:04 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39NKqNQc012387; Mon, 23 Oct 2023 21:59:02 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3tvup1jup5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Oct 2023 21:59:02 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39NLx2Y819989026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Oct 2023 21:59:02 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F157158055; Mon, 23 Oct 2023 21:59:01 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AAE855805B; Mon, 23 Oct 2023 21:59:01 +0000 (GMT) Received: from [9.61.122.13] (unknown [9.61.122.13]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Mon, 23 Oct 2023 21:59:01 +0000 (GMT) Message-ID: <2e4354af-824d-9b1c-b61f-b6501393212e@linux.vnet.ibm.com> Date: Mon, 23 Oct 2023 14:59:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le) To: Thomas Monjalon Cc: dev@dpdk.org References: <20231010225100.335049-1-drc@linux.vnet.ibm.com> <3356591.usfYGdeWWP@thomas> Content-Language: en-US From: David Christensen In-Reply-To: <3356591.usfYGdeWWP@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: HwhtlubRNnKTWCQBsQm6ntjf1oHgu6NX X-Proofpoint-GUID: HwhtlubRNnKTWCQBsQm6ntjf1oHgu6NX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-23_21,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=437 malwarescore=0 lowpriorityscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310230193 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/17/23 5:39 AM, Thomas Monjalon wrote: > I feel this function should not be implemented in the common EAL. > What about adding a new function in lib/eal/ppc/ ? > And add the "return true" for other architectures? Would it be more appropriate in the lib/eal/common level or lib/eal/linux only? I would expect the MMU requirement should apply to FreeBSD on ppc64le as well but IBM doesn't support or test FreeBSD internally. Dave