From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-dev] [PATCH v4 09/10] devargs: use proper namespace prefix
Date: Tue, 24 Apr 2018 00:41:09 +0200 [thread overview]
Message-ID: <2e531df113cd9d4a6ac97dcbd040758c2e8b9e4c.1524522515.git.gaetan.rivet@6wind.com> (raw)
In-Reply-To: <cover.1524522514.git.gaetan.rivet@6wind.com>
In-Reply-To: <cover.1524522514.git.gaetan.rivet@6wind.com>
rte_eal_devargs is useless, rte_devargs is sufficient.
Only experimental functions are changed for now.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/bus/vdev/vdev.c | 6 +++---
drivers/net/failsafe/failsafe_args.c | 2 +-
drivers/net/failsafe/failsafe_eal.c | 2 +-
lib/librte_eal/common/eal_common_dev.c | 8 ++++----
lib/librte_eal/common/eal_common_devargs.c | 12 ++++++------
lib/librte_eal/common/include/rte_devargs.h | 23 +++++++++++++----------
lib/librte_eal/rte_eal_version.map | 8 ++++----
7 files changed, 32 insertions(+), 29 deletions(-)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index d100f3232..f7a2148ef 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -228,7 +228,7 @@ rte_vdev_init(const char *name, const char *args)
goto fail;
}
- rte_eal_devargs_insert(devargs);
+ rte_devargs_insert(devargs);
TAILQ_INSERT_TAIL(&vdev_device_list, dev, next);
return 0;
@@ -278,7 +278,7 @@ rte_vdev_uninit(const char *name)
TAILQ_REMOVE(&vdev_device_list, dev, next);
- rte_eal_devargs_remove(devargs->bus->name, devargs->name);
+ rte_devargs_remove(devargs->bus->name, devargs->name);
free(dev);
return 0;
@@ -297,7 +297,7 @@ vdev_scan(void)
if (custom_scan->callback != NULL)
/*
* the callback should update devargs list
- * by calling rte_eal_devargs_insert() with
+ * by calling rte_devargs_insert() with
* devargs.bus = rte_bus_find_by_name("vdev");
* devargs.type = RTE_DEVTYPE_VIRTUAL;
* devargs.policy = RTE_DEV_WHITELISTED;
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index 5edc061e8..2c002b164 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -63,7 +63,7 @@ fs_parse_device(struct sub_device *sdev, char *args)
d = &sdev->devargs;
DEBUG("%s", args);
- ret = rte_eal_devargs_parse(d, "%s", args);
+ ret = rte_devargs_parse(d, "%s", args);
if (ret) {
DEBUG("devargs parsing failed with code %d", ret);
return ret;
diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c
index c11621e93..ee89236f1 100644
--- a/drivers/net/failsafe/failsafe_eal.c
+++ b/drivers/net/failsafe/failsafe_eal.c
@@ -69,7 +69,7 @@ fs_bus_init(struct rte_eth_dev *dev)
else
snprintf(devstr, sizeof(devstr), "%s",
rte_eth_devices[pid].device->name);
- ret = rte_eal_devargs_parse(da, "%s", devstr);
+ ret = rte_devargs_parse(da, "%s", devstr);
if (ret) {
ERROR("Probed devargs parsing failed with code"
" %d", ret);
diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index 809d6649d..61cb3b162 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -138,12 +138,12 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
if (da == NULL)
return -ENOMEM;
- ret = rte_eal_devargs_parse(da, "%s:%s,%s",
+ ret = rte_devargs_parse(da, "%s:%s,%s",
busname, devname, devargs);
if (ret)
goto err_devarg;
- ret = rte_eal_devargs_insert(da);
+ ret = rte_devargs_insert(da);
if (ret)
goto err_devarg;
@@ -168,7 +168,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
return 0;
err_devarg:
- if (rte_eal_devargs_remove(busname, devname)) {
+ if (rte_devargs_remove(busname, devname)) {
free(da->args);
free(da);
}
@@ -204,7 +204,7 @@ rte_eal_hotplug_remove(const char *busname, const char *devname)
if (ret)
RTE_LOG(ERR, EAL, "Driver cannot detach the device (%s)\n",
dev->name);
- rte_eal_devargs_remove(busname, devname);
+ rte_devargs_remove(busname, devname);
return ret;
}
diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index b251bb0a6..24d0f6f44 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -63,7 +63,7 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)
}
int __rte_experimental
-rte_eal_devargs_parse(struct rte_devargs *da, const char *format, ...)
+rte_devargs_parse(struct rte_devargs *da, const char *format, ...)
{
struct rte_bus *bus = NULL;
va_list ap;
@@ -125,11 +125,11 @@ rte_eal_devargs_parse(struct rte_devargs *da, const char *format, ...)
}
int __rte_experimental
-rte_eal_devargs_insert(struct rte_devargs *da)
+rte_devargs_insert(struct rte_devargs *da)
{
int ret;
- ret = rte_eal_devargs_remove(da->bus->name, da->name);
+ ret = rte_devargs_remove(da->bus->name, da->name);
if (ret < 0)
return ret;
TAILQ_INSERT_TAIL(&devargs_list, da, next);
@@ -149,7 +149,7 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
if (devargs == NULL)
goto fail;
- if (rte_eal_devargs_parse(devargs, "%s", dev))
+ if (rte_devargs_parse(devargs, "%s", dev))
goto fail;
devargs->type = devtype;
bus = devargs->bus;
@@ -174,7 +174,7 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
}
int __rte_experimental
-rte_eal_devargs_remove(const char *busname, const char *devname)
+rte_devargs_remove(const char *busname, const char *devname)
{
struct rte_devargs *d;
void *tmp;
@@ -223,7 +223,7 @@ rte_eal_devargs_dump(FILE *f)
/* bus-aware rte_devargs iterator. */
__rte_experimental
struct rte_devargs *
-rte_eal_devargs_next(const char *busname, const struct rte_devargs *start)
+rte_devargs_next(const char *busname, const struct rte_devargs *start)
{
struct rte_devargs *da;
diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h
index e261f7c69..07a4701b2 100644
--- a/lib/librte_eal/common/include/rte_devargs.h
+++ b/lib/librte_eal/common/include/rte_devargs.h
@@ -105,9 +105,10 @@ int rte_eal_parse_devargs_str(const char *devargs_str,
* - 0 on success.
* - Negative errno on error.
*/
-int __rte_experimental
-rte_eal_devargs_parse(struct rte_devargs *da,
- const char *format, ...)
+__rte_experimental
+int
+rte_devargs_parse(struct rte_devargs *da,
+ const char *format, ...)
__attribute__((format(printf, 2, 0)));
/**
@@ -120,8 +121,9 @@ __attribute__((format(printf, 2, 0)));
* - 0 on success
* - Negative on error.
*/
-int __rte_experimental
-rte_eal_devargs_insert(struct rte_devargs *da);
+__rte_experimental
+int
+rte_devargs_insert(struct rte_devargs *da);
/**
* Add a device to the user device list
@@ -162,8 +164,9 @@ int rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str);
* <0 on error.
* >0 if the devargs was not within the user device list.
*/
-int __rte_experimental rte_eal_devargs_remove(const char *busname,
- const char *devname);
+__rte_experimental
+int rte_devargs_remove(const char *busname,
+ const char *devname);
/**
* Count the number of user devices of a specified type
@@ -203,15 +206,15 @@ void rte_eal_devargs_dump(FILE *f);
*/
__rte_experimental
struct rte_devargs *
-rte_eal_devargs_next(const char *busname, const struct rte_devargs *start);
+rte_devargs_next(const char *busname, const struct rte_devargs *start);
/**
* Iterate over all rte_devargs for a specific bus.
*/
#define RTE_EAL_DEVARGS_FOREACH(busname, da) \
- for (da = rte_eal_devargs_next(busname, NULL); \
+ for (da = rte_devargs_next(busname, NULL); \
da != NULL; \
- da = rte_eal_devargs_next(busname, da)) \
+ da = rte_devargs_next(busname, da)) \
#ifdef __cplusplus
}
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 4054fc111..526b0d95c 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -217,10 +217,10 @@ EXPERIMENTAL {
rte_dev_event_monitor_start;
rte_dev_event_monitor_stop;
rte_eal_cleanup;
- rte_eal_devargs_insert;
- rte_eal_devargs_next;
- rte_eal_devargs_parse;
- rte_eal_devargs_remove;
+ rte_devargs_insert;
+ rte_devargs_next;
+ rte_devargs_parse;
+ rte_devargs_remove;
rte_eal_hotplug_add;
rte_eal_hotplug_remove;
rte_eal_mbuf_user_pool_ops;
--
2.11.0
next prev parent reply other threads:[~2018-04-23 22:41 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 16:07 [dpdk-dev] [PATCH 0/6] devargs cleanup Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 1/6] devargs: introduce iterator Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 2/6] devargs: introduce foreach macro Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 3/6] vdev: do not reference devargs_list Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 4/6] bus/pci: " Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 5/6] test: remove rte_devargs unit tests Gaetan Rivet
2017-08-25 16:07 ` [dpdk-dev] [PATCH 6/6] devargs: make devargs_list private Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 00/18] devargs cleanup Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 01/18] eal: prepend busname on legacy device declaration Gaetan Rivet
2017-12-11 13:57 ` Shreyansh Jain
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 02/18] eal: remove generic devtype Gaetan Rivet
2017-10-17 18:16 ` Aaron Conole
2017-10-18 8:20 ` Gaëtan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 03/18] devargs: introduce iterator Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 04/18] devargs: introduce foreach macro Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 05/18] vdev: do not reference devargs list Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 06/18] bus/pci: " Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 07/18] test: remove devargs unit tests Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 08/18] devargs: make devargs list private Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 09/18] devargs: make parsing variadic Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 10/18] devargs: require bus name prefix Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation Gaetan Rivet
2017-10-16 11:39 ` Shreyansh Jain
2017-10-16 11:42 ` Shreyansh Jain
2017-10-16 13:42 ` Gaëtan Rivet
2017-10-17 5:58 ` Shreyansh Jain
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 12/18] eal: add generic device declaration parameter Gaetan Rivet
2017-12-13 14:26 ` Shreyansh Jain
2017-12-13 14:47 ` Gaëtan Rivet
2017-12-13 15:24 ` Shreyansh Jain
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 13/18] bus: make device recognition function public Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 14/18] net/failsafe: keep legacy sub-device declaration Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 15/18] ether: use new devargs parsing function Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 16/18] devargs: remove old " Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 17/18] devargs: use proper prefix Gaetan Rivet
2017-10-12 8:21 ` [dpdk-dev] [PATCH v2 18/18] doc: remove devargs deprecation notices Gaetan Rivet
2017-10-12 11:28 ` Mcnamara, John
2017-12-13 10:17 ` Shreyansh Jain
2017-12-13 10:25 ` Gaëtan Rivet
2017-12-13 10:54 ` Shreyansh Jain
2017-12-22 4:59 ` Shreyansh Jain
2017-12-22 8:33 ` Gaëtan Rivet
2017-10-17 18:18 ` [dpdk-dev] [PATCH v2 00/18] devargs cleanup Aaron Conole
2017-10-18 8:36 ` Gaëtan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 00/10] " Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 01/10] devargs: introduce iterator Gaetan Rivet
2018-03-21 5:43 ` Tan, Jianfeng
2018-03-21 8:50 ` Gaëtan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 02/10] devargs: introduce foreach macro Gaetan Rivet
2018-04-22 21:42 ` Thomas Monjalon
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 03/10] bus/vdev: do not reference devargs list Gaetan Rivet
2018-03-21 5:41 ` Tan, Jianfeng
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 04/10] bus/pci: " Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 05/10] net/vdev_netvsc: " Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 06/10] test: remove devargs unit tests Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 07/10] devargs: make devargs list private Gaetan Rivet
2018-04-22 21:46 ` Thomas Monjalon
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 08/10] devargs: make parsing variadic Gaetan Rivet
2018-04-22 21:52 ` Thomas Monjalon
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 09/10] devargs: use proper namespace prefix Gaetan Rivet
2018-03-20 23:20 ` [dpdk-dev] [PATCH v3 10/10] devargs: rename legacy API Gaetan Rivet
2018-04-22 22:00 ` [dpdk-dev] [PATCH v3 00/10] devargs cleanup Thomas Monjalon
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 " Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 01/10] devargs: introduce iterator Gaetan Rivet
2018-04-23 23:54 ` Stephen Hemminger
2018-04-24 10:22 ` Gaëtan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 02/10] devargs: introduce foreach macro Gaetan Rivet
2018-04-23 23:56 ` Stephen Hemminger
2018-04-24 10:26 ` Gaëtan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 03/10] bus/vdev: do not reference devargs list Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 04/10] bus/pci: " Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 05/10] net/vdev_netvsc: " Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 06/10] test: remove devargs unit tests Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 07/10] devargs: make devargs list private Gaetan Rivet
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 08/10] devargs: make parsing variadic Gaetan Rivet
2018-04-23 22:41 ` Gaetan Rivet [this message]
2018-04-23 22:41 ` [dpdk-dev] [PATCH v4 10/10] devargs: rename legacy API Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 00/10] devargs cleanup Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 01/10] devargs: introduce iterator Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 02/10] bus/vdev: do not reference devargs list Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 03/10] bus/pci: " Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 04/10] net/vdev_netvsc: " Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 05/10] test: remove devargs unit tests Gaetan Rivet
2018-04-25 0:45 ` Thomas Monjalon
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 06/10] devargs: make devargs list private Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 07/10] devargs: make parsing variadic Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 08/10] devargs: update devargs add documentation Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 09/10] devargs: use proper namespace prefix Gaetan Rivet
2018-04-23 23:54 ` [dpdk-dev] [PATCH v5 10/10] devargs: rename legacy API Gaetan Rivet
2018-04-25 1:51 ` Thomas Monjalon
2018-04-25 1:57 ` [dpdk-dev] [PATCH v5 00/10] devargs cleanup Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e531df113cd9d4a6ac97dcbd040758c2e8b9e4c.1524522515.git.gaetan.rivet@6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).