From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A67B4A0613 for ; Mon, 23 Sep 2019 18:33:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D8F11BEDD; Mon, 23 Sep 2019 18:33:28 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C40D01BEDB for ; Mon, 23 Sep 2019 18:33:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 09:33:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,541,1559545200"; d="scan'208";a="363682167" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga005.jf.intel.com with ESMTP; 23 Sep 2019 09:33:22 -0700 To: Rasesh Mody , dev@dpdk.org Cc: jerinj@marvell.com, GR-Everest-DPDK-Dev@marvell.com References: <20190906072548.12304-1-rmody@marvell.com> <20190919211157.1668-1-rmody@marvell.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <2e5610a0-0654-83c0-4d22-cb926fc3f4f7@intel.com> Date: Mon, 23 Sep 2019 17:33:22 +0100 MIME-Version: 1.0 In-Reply-To: <20190919211157.1668-1-rmody@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/19/2019 10:11 PM, Rasesh Mody wrote: > Hi, > > Currently, BNX2X PMD uses a very old firmware 7.2.51. > This patch series updated the base driver to use to latest > firmware 7.13.11. The latest firmware comprises of enhancements > and fixes. > > v2: > - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" > - Addressed most of checkpatch issues > > Thanks! > -Rasesh > > Rasesh Mody (4): > net/bnx2x: update and reorganize HW registers > net/bnx2x: update HSI code > net/bnx2x: update to latest FW 7.13.11 > doc: cleanup SPDX license id usage in bnx2x guide > I am getting build errors with this patchset [1], since it is merged into next-net-mrvl, I only pulled the doc patch, 4/4, but not others, can you please check the patchset? [1] In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22, from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8: .../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for ‘uint64_t’ 25 | #define __le64 uint64_t | ^~~~~~~~ In file included from /usr/include/stdint.h:37, from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12, from .../dpdk/drivers/net/bnx2x/bnx2x.h:17, from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8: /usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’ was here 27 | typedef __uint64_t uint64_t; | ^~~~~~~~ In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33, from .../dpdk/drivers/net/bnx2x/bnx2x.h:23, from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function ‘rte_eth_linkstatus_set’: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error: passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type [-Werror=incompatible-pointer-types] 176 | orig.val64 = rte_atomic64_exchange(dev_link, | ^~~~~~~~ | | | volatile uint64_t * {aka volatile long long unsigned int *} In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263, from .../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18, from .../dpdk/drivers/net/bnx2x/bnx2x.h:18, from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note: expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’} 48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val) | ~~~~~~~~~~~~~~~~~~~^~~ cc1: all warnings being treated as errors In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22, from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8: .../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for ‘uint64_t’ 25 | #define __le64 uint64_t | ^~~~~~~~ In file included from /usr/include/stdint.h:37, from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12, from .../dpdk/drivers/net/bnx2x/bnx2x.h:17, from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8: /usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’ was here 27 | typedef __uint64_t uint64_t; | ^~~~~~~~ In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33, from .../dpdk/drivers/net/bnx2x/bnx2x.h:23, from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function ‘rte_eth_linkstatus_set’: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error: passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type [-Werror=incompatible-pointer-types] 176 | orig.val64 = rte_atomic64_exchange(dev_link, | ^~~~~~~~ | | | volatile uint64_t * {aka volatile long long unsigned int *} In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263, from .../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18, from .../dpdk/drivers/net/bnx2x/bnx2x.h:18, from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note: expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’} 48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val) | ~~~~~~~~~~~~~~~~~~~^~~ cc1: all warnings being treated as errors make[7]: *** [.../dpdk/mk/internal/rte.compile-pre.mk:116: ecore_sp.o] Error 1 In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22, from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8: .../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for ‘uint64_t’ 25 | #define __le64 uint64_t | ^~~~~~~~ In file included from /usr/include/stdint.h:37, from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12, from .../dpdk/drivers/net/bnx2x/bnx2x.h:17, from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8: /usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’ was here 27 | typedef __uint64_t uint64_t; | ^~~~~~~~ In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33, from .../dpdk/drivers/net/bnx2x/bnx2x.h:23, from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function ‘rte_eth_linkstatus_set’: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error: passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type [-Werror=incompatible-pointer-types] 176 | orig.val64 = rte_atomic64_exchange(dev_link, | ^~~~~~~~ | | | volatile uint64_t * {aka volatile long long unsigned int *} In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263, from .../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13, from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18, from .../dpdk/drivers/net/bnx2x/bnx2x.h:18, from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note: expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’} 48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val) | ~~~~~~~~~~~~~~~~~~~^~~ cc1: all warnings being treated as errors In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:40, from .../dpdk/drivers/net/bnx2x/bnx2x.h:23, from .../dpdk/drivers/net/bnx2x/bnx2x.c:16: .../dpdk/drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_dma_alloc’: .../dpdk/drivers/net/bnx2x/bnx2x_logs.h:21:3: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 9 has type ‘rte_iova_t’ {aka ‘long long unsigned int’} [-Werror=format=] 21 | "[%s:%d(%s)] " fmt, __func__, __LINE__, \ | ^~~~~~~~~~~~~~ .../dpdk/drivers/net/bnx2x/bnx2x_logs.h:25:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ 25 | PMD_DRV_LOG_RAW(level, sc, fmt "\n", ## args) | ^~~~~~~~~~~~~~~ .../dpdk/drivers/net/bnx2x/bnx2x.c:190:2: note: in expansion of macro ‘PMD_DRV_LOG’ 190 | PMD_DRV_LOG(DEBUG, sc, | ^~~~~~~~~~~ In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_bus_pci.h:25, from .../dpdk/drivers/net/bnx2x/bnx2x.h:19, from .../dpdk/drivers/net/bnx2x/bnx2x.c:16: /usr/include/inttypes.h:121:34: note: format string is defined here 121 | # define PRIx64 __PRI64_PREFIX "x" In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:40, from .../dpdk/drivers/net/bnx2x/bnx2x.h:23, from .../dpdk/drivers/net/bnx2x/bnx2x.c:16: .../dpdk/drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_load_firmware’: .../dpdk/drivers/net/bnx2x/bnx2x_logs.h:21:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=] 21 | "[%s:%d(%s)] " fmt, __func__, __LINE__, \ | ^~~~~~~~~~~~~~ .../dpdk/drivers/net/bnx2x/bnx2x_logs.h:25:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ 25 | PMD_DRV_LOG_RAW(level, sc, fmt "\n", ## args) | ^~~~~~~~~~~~~~~ .../dpdk/drivers/net/bnx2x/bnx2x.c:9672:3: note: in expansion of macro ‘PMD_DRV_LOG’ 9672 | PMD_DRV_LOG(NOTICE, sc, | ^~~~~~~~~~~