From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B740C2BB1 for ; Fri, 14 Apr 2017 15:10:37 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2017 06:10:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,198,1488873600"; d="scan'208";a="1155902313" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga002.fm.intel.com with ESMTP; 14 Apr 2017 06:10:33 -0700 To: Thomas Monjalon , Olivier Matz Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, mb@smartsharesystems.com, andrey.chilikin@intel.com, jblunck@infradead.org, nelio.laranjeiro@6wind.com, arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com> <20170404162807.20157-1-olivier.matz@6wind.com> <2948467.vjfs1XSdfO@xps13> From: Ferruh Yigit Message-ID: <2ead9890-5759-5c31-1805-588967c7cbf2@intel.com> Date: Fri, 14 Apr 2017 14:10:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <2948467.vjfs1XSdfO@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 13:10:38 -0000 On 4/5/2017 10:37 AM, Thomas Monjalon wrote: > 2017-04-04 18:27, Olivier Matz: >> Based on discussions done in [1] and in this thread, this patchset reorganizes >> the mbuf. >> >> The main changes are: >> - reorder structure to increase vector performance on some non-ia >> platforms. >> - add a 64bits timestamp field in the 1st cache line. This timestamp >> is not normalized, i.e. no unit or time reference is enforced. A >> library may be added to do this job in the future. >> - m->next, m->nb_segs, and m->refcnt are always initialized for mbufs >> in the pool, avoiding the need of setting m->next (located in the >> 2nd cache line) in the Rx path for mono-segment packets. >> - change port and nb_segs to 16 bits >> - move seqn in the 2nd cache line > > Applied, thanks for the long work > <...> >> Once this patchset is pushed, the Rx path of drivers could be optimized a bit, >> by removing writes to m->next, m->nb_segs and m->refcnt. The patch 4/8 gives an >> idea of what could be done. Hi Olivier, Some driver patches already received for this update, but not all yet. Can you please describe what changes are required in PMDs after this patch? And what will be effect of doing changes or not? Later we can circulate this information through the PMD maintainers to be sure proper updates done. Thanks, ferruh > > Yes drivers patches are welcome :) > Please target RC2 for these changes. >