From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0069.outbound.protection.outlook.com [104.47.34.69]) by dpdk.org (Postfix) with ESMTP id 9EBCB1E2F for ; Tue, 10 Jan 2017 05:05:42 +0100 (CET) Received: from CY1PR03CA0028.namprd03.prod.outlook.com (10.174.128.38) by BN6PR03MB2465.namprd03.prod.outlook.com (10.168.223.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Tue, 10 Jan 2017 04:05:41 +0000 Received: from BY2FFO11FD022.protection.gbl (2a01:111:f400:7c0c::101) by CY1PR03CA0028.outlook.office365.com (2603:10b6:600::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7 via Frontend Transport; Tue, 10 Jan 2017 04:05:41 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD022.mail.protection.outlook.com (10.1.15.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Tue, 10 Jan 2017 04:05:38 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v0A45Zpk024031; Mon, 9 Jan 2017 21:05:36 -0700 To: Ferruh Yigit , References: <1482756644-13726-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-12-git-send-email-shreyansh.jain@nxp.com> <8484fc57-baa7-0f84-bc05-49d7f4ca79ad@intel.com> <03401dd4-5d78-6ad2-e199-c076495e186d@intel.com> CC: , From: Shreyansh Jain Message-ID: <2ec485c9-c4b1-727c-28cb-46b270708ca8@nxp.com> Date: Tue, 10 Jan 2017 09:39:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <03401dd4-5d78-6ad2-e199-c076495e186d@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131284947398774954; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39840400002)(39450400003)(39380400002)(39850400002)(39860400002)(39400400002)(39410400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(199003)(24454002)(189002)(377454003)(8676002)(65826007)(65956001)(65806001)(33646002)(36756003)(93886004)(47776003)(189998001)(64126003)(4001350100001)(23746002)(97736004)(5001770100001)(15395725005)(38730400001)(77096006)(50466002)(68736007)(8936002)(229853002)(230700001)(50986999)(81156014)(81166006)(76176999)(4326007)(54356999)(83506001)(6306002)(69596002)(85426001)(54906002)(626004)(31696002)(106466001)(6666003)(86362001)(5660300001)(2950100002)(105606002)(305945005)(356003)(92566002)(31686004)(104016004)(2906002)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2465; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD022; 1:tBPleKkvBZ7XgHaObI2kpIaO8LBmyDNOrJ0cHSL93LQQpKdFTiM8hWeWcbSKPJADi33sKzqk+pnoI2dovPaFegemN8OSra3Ke5x+EAOFwjXmzJqu0q4xrxJ2tZDs6DjA7s7LIR6w886xViw+cmHcg0Rp1Nby7KP2hwKzw/jlY5iAhmHhQp6/7r0gAxthvdIP6Nf31GCDNbaNB/CKAwLsRd8m46lgIh4VlukEp1RhSpOwEdpZIQGtRu3ckffQ4WXXb2NxEFBp1mPAAF9eFEEYGRwbuHMGhAFUI+bKQIuwBNorMJgPr1T+DQ+aYfB5hwk1Nc0xwsY8H7tqJqzU59TyqheEGA3EjMJsx9f6rPZBw2XW2wV5wYcd+hB0rL0i5dk6ghbKZwC9Wz7Rci7gX/knjl/jMHGWDvUY7yafU/Cl/JR4Riq/D3DGNkQyNhCJmYFL2fKX3yE6fyxVSFCrmuHKn08qVSWs7uVeIptewicHuIY5s0JpfDHdNDo1VwB00vfrCTDoGS0G/nz32NzFfkzguDvtHWVPcoQgTbtHqf8lHPNKPOivQmys+UT3colT1Qf5y414GmhNOv/jeIbj5khwT2HHeZMWe5TtyQhu0cBWFj1AA7abwDgVYA6fbpWBY0Kl X-MS-Office365-Filtering-Correlation-Id: 9b234cb2-bcbd-4f04-e45c-08d4390df070 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2465; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2465; 3:ROhrBjSxQi3M0NrSjgpWfWSS7KWnh7DbswyTATmKcl6sNQfU0aKtQwqEtTuvo/aNFYAvZjzsLPwsMHkyBiR2MpPLSVCDAOoK9m69GNOyt0Gskl4wxo0SJJq03uCKf8sdayIglMuVCy3R5s04MNmBwNS0wWLvb5vfuedDYOF3be95NMvHsKXz6mQzFQPQRbgCNFSC0l3mJvda5qaC5qklTRaNzPd51PfWcSl+VtQzS9/E7vlVjNUMMIU5JuqqkkUEvu1qEO2A1KFmbB5F+FlOlVI/oI20NIBJp6aO8e6BOsxuARAuaGQcezZMVZA3tvok7bi8UsAlYxyQ6XIFr+nkSlBMrEjG2J6kf4rvRstYlF/YWmwar2WuNQm/B0C9qJjc; 25:peww/iaHic46AIZfX7AI9AQz+Kg6Vzc5+mdheByE5Yh/yOYBTELQb+bOxnt4Hy8n5jcgW9wuvQxPHcRI6s9oZKKedrKQvDqHL67x3M2FR05ETkdDbwcJT/tKiFoePVZOq53B4050qAEbGECzD+vX4Q+1IDejgZEu8tgXtAAsyJXI2z1tXuJJ6KmKOFRO6conbAwiEHhxeKzhZpR+qqxFiHS1C3lQTlIiyIe26JND8dpjNWJ29tgQHzXyYKdEhT5mFXkHDE7JGmfZOgWTNl9WGrMyQfmDPutFu2Q4HZk8IrjcMH2pJDlOpVDwmX6uO3UQunYOxEwPMSgCnMy7VfwHWgq7k97CCqxV5QVHcl1/pxhdFQ8vhoW4QQNKFkf+2e8AQWD2lWfkF6sd7hPUNFXNFwNozcASDGJXnPcbtxoCW0mbUlyqCnLCw9EoIrmMZs7Sr3cuRz9756oUsZvoYAKDXg== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2465; 31:m9eXGwPFXHbo0jjXhmymab4i15S247Jj6rsijC5SqaGjsTVSQ+2Lxu+PHgxAXrJBifcIGDZ0v64vcPq1g0+R7pMGZl41iW3Yw5a4sdeesgVaaJ3XL+Af4YJqfp/gE4+BiytxTiqdwDiXZllB9XGvu6FM8byupIxkKEZ1p2dRcBn8T7Fd6etp7l5cXkiqXU5Eq/E1zLarEs2xA0rFp/tLsYhg5dio9jzl/vnAjWX0y13sfPv1kqSVsCJ2/YI7yAN5omWaL32mKSV/bP23bBw8hw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(13017025)(13015025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:BN6PR03MB2465; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2465; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2465; 4:KNflTAxo4vkrT3biZaFB2X8RKE7CLSHxV2j+iO9N6Z9D20ykLevtT4+PF3iTCrezTQ0N7bBtk3FHJfoE62mq42c+cJwM0k+1Yspm0HrHiD81wGJ1Cguc2sMI4sTa2o+IavhYsn36GDsh+uo2fuTExeLVuekEggfDJXI3LNwpPGJLTVxt1NkYgT8Q5rCLpaLZimnk8NxY2FerFf+kBVczDBf28pYuupgw3QoEe7Xnhf01wiAorwcxQnNCp0wzpfZSrw0YYxKPJ95Zct95XhdfcRx/wPsaJJpaKEfqn7+pswwi5D44CToD6Jd8YqsNrkCM70bqr0TzMmPn2O0d3JBNCTgtTz/eY3s5VMZCstGpmxEeoPAHhl0XiXhOdPcK9W1U287LmP+hnX8F4Vqqg+5zCiXw5U85DwxSMSUSLVkuFj8Kgif3yUtjuBqzsSjwLAG90fF8e5P2bgnEA9ARi49Bj6gAOimaIDZXXvgos/4z8wVhVn54Rwa5Weh7DbcRsiaWC+DOV2gWBCvbrusNa3T6BiuUkHUiNuvTWr+MPvixjrljV3udIdEVwHSLTKn1KJd6kYZTPT47j6yVTT67Y0yXszwtG7LmV+PVop8pEf3OTkb5qkFZ1eTpDG8wUNeD76m4WspYrhoXOtywXnafyf5qciZBanIVUHYrv6nj52ysyaMko3Kp/YdlBiwD0jCcDq3OE+o2TZPh73Jrc/b3LMfyJD4vsLsPpD7snYyBGn3d9qf7XTvJfjgrI3qSCL32WrBi X-Forefront-PRVS: 01834E39B7 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2465; 23:xSozqXG2DkX5MC+o0aR7+daiT8yLiYd5av6gm?= =?Windows-1252?Q?1S3xaB9o/rPYCOvbCIx4YeDo6SSDDjP8PFDCviAaPz+5j1CfdzBZggwq?= =?Windows-1252?Q?2KgCMECRcBXZnvTSvJeQV66WwqUarLnB2izPPZl31/1dFivwFs+KgJ8Q?= =?Windows-1252?Q?XHJmWr6J7jcHxEATZyuTHINx813dT5JuOQQgubi459wykGLpKXxpvxcN?= =?Windows-1252?Q?xRqVm6jl72KI1yn29u4TNFemc5aQsRu+o9Ha2hHQlL5fn7yYEw/46fBs?= =?Windows-1252?Q?1vB7wiH8Iun7JUad8SROdDa7nghoh0yMHohlA/JAxQ59Krlpkkt2Olh/?= =?Windows-1252?Q?7gj70C09Wc0I5R2F5JckuUCBN2wUOv/XoHq02yx8cc4M3Z0P7/f+kRUO?= =?Windows-1252?Q?DSofkz+BoloLyGBJFXevHTFNBaawHTlKu2d8RaLR5ERAeyjwhbv83wpu?= =?Windows-1252?Q?+bozrXNfB0HOuicsi0rvRn+6GpDSMGwjLhtGXYxjSXGkMB4mmNLUDaNC?= =?Windows-1252?Q?zqFDx0WrU4oHOEFKKrNTDqYfvQfEFzm7h4ve8hjy6BCVzufx86dx3kEE?= =?Windows-1252?Q?EDZm8wuCKcQ0dzqIaA5IUg55HjlfR3M+OczCgZEK8mwZ60vCxFbKgDlI?= =?Windows-1252?Q?UDUWUgFeMACcTO7t/YrtwPQS8FRKz6ZO/nK5xmNrB/DQEAg9cnAmhPJD?= =?Windows-1252?Q?VYXI48ugnhyjorHG10eIvUwYaR+1Tu4d1AYwCDaK4ZdI/kKPkKzOoW/d?= =?Windows-1252?Q?lI3p8nKBZCTAlRjMXOpfrFqvAfXLB0rIOT7s3T2e11zi4nxaBA+M6i5s?= =?Windows-1252?Q?GwQ3CRbLsC3RoyMmpc3ghLWhPq6/pNUx8vqjDvyRnKitAf8QFASFaB0/?= =?Windows-1252?Q?sMlkQbfQqyHZOW67wl8jus9VzO4Omx5ViVZeYLb2hUd8KJjaUX/njqDZ?= =?Windows-1252?Q?bfQRraEO1u3bl9OLew0V6y1YzkEC3MY+V0u3cBJm4JKX94koxNRPBYCh?= =?Windows-1252?Q?J44EbggXM5wGRUmVdqo88k4f9Fz+8c+RF2J1tueTpIhNLyFkbxTEFjX7?= =?Windows-1252?Q?ELfskt9uZ6SpK4EU6mvgTrkus7fKwrjCJNu/ZJMkBQlvmZ0yRubt6EFV?= =?Windows-1252?Q?DJNJgN/yCCHLY0Ac/6NxCk5c0YCjaXbDNTx0Ee2hHnu0tDTgx0uWyVPA?= =?Windows-1252?Q?WkkXjlBoyy8j0mKEyHKbm8aWzMf4L06RDV/p/7Mo7gFYYtAcNR866QQT?= =?Windows-1252?Q?5SzQazs/yf2r223topAkd4aWhXun4j5ujibv1H8wQ8fPBMw9OPnn6cAA?= =?Windows-1252?Q?s1W9ksFs2c3xJHwNvk6l5Z4F60KXaFRtINcluqKiQB0nfrGfJPV6gNgn?= =?Windows-1252?Q?9DUA7kpclNdnajfS8aOewoAUdTt88auvOuNNMcKRElJtlA3nnY2tLurP?= =?Windows-1252?Q?abHEBdmK7x0YTKKDpWeE6rrOkZ8PpQ39zBSVI7s5FkPBLj9+szX9NbK1?= =?Windows-1252?Q?j4PhSjzkEy/5KR+ucUZSBiI2pROSpSyyCpu6k4FKMWLMP+T8tPk6EA7w?= =?Windows-1252?Q?0YEpInhRUWMDxVi/OzkW0LL2xj2qaXUY3xqBn6IjipCfrKCRpX1VwflQ?= =?Windows-1252?Q?xaH0uO1VPoJB0KP8qald1xgQcaU3jMkeYgJ91UXQ/sCxjnqzCsmXBVtJ?= =?Windows-1252?Q?fllHnza+Og3gmHK8n3gM4v+DzGmT7FpmfZBRwJ7UnnJLmdZxW97hJXlv?= =?Windows-1252?Q?vTWFVJXcydEgzD+ng=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2465; 6:Z083QnDWYO7MBqOaZrVTtYFLtZaiJ8byOOb5jORe+iFFsQOWA2Jx0+DSyFZky7+CLYjBu+xr+jInzrvg1nDY920UfpvU7Xy6pkASu3EwHMxTSORgIuik803EPwxTOE9YuiVE4cktQLtwZGzuK6VtA3MIDK/MNwdAi8jY+7YhlRSwAeYetjLdP3UpwR7zMjCRcWN/1RtoyzMVgY05Rx7wtq9BWBfcaA2COI+L6ofzGn+I6XyreaKWrGAQCP44Y986qgUtDnwoblTXhlBnBdhGAy3a8E4XY1PHWmWhaADU+s4SOnJeU7rhjf/FEDEvewuGFOekjX+ftlKphEWM2qolVSOk30NTjfsTx92mfXHs2ga1lh8qsYDajAUqO3asK2OM0JSyEKXcIVRZ13mKu26VAheALwfFedj1DupayS++ZFpLX2PatXo1xkKSWvunYi8L; 5:Stz5SNSTv2SN5U2NfcOib0cpxYq77fZqOsmHSNtj5cf3QwXppa2YfYQaTxPP+tLl0RhbEjOJMpeZn5TdocXKGy52FNMHCfI3nqjoYrnBQEdq0Y0+r6fQnMfgbnditoPu7s5YleIYEHwCmqoWyvUY2eJY5zPThInF77kZ2QM3W8yvKo4s95kXgIhXZhNVzIPY; 24:ErxSA6DVpCrr5vJJcupe6MMCoWvuB+BME/Y4NsfDTBd1X1JWJ00wcu7cTdBddFW6z1gNqPsGog2QtI3GX4EoqINgf+oC4g0TbdJkI2DIvHQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2465; 7:agBVBE0qxtRaOA8sn9oJmHX35LTJvYrFz5elwbJ7xP1RX/t5v5POgyQMZVsfickZoXKdU5J0K+XPiGBJQ0p54xKXxsqldFN5Sk41Irg7U1wOAmA8pwgykbY5J3TIYMx+uj6pjZ8l8gInPplh6G8DMg/nvyDnjojtKcVzg2gFgDNuIszDio8/iAlKDveoDiNmdpfmlKA+lJBLDmYGW5iAj8uiy+U54fULKiuiwrcGfxdTlPP488TCMaaP0jMtXz1xLDZMl8NT9pQ8sX73Z/rAuY/D9CgzLkY+biE1h9UuLznfGnxrEwTyCQihluoEDHSv/ahxSJqpmPX0Yg/VVbyUz27v63+xHGMeX/5GvY0uVEgeUYgkMiI0x3w11iLYNROVbPOC9pweZJb4KDUN6BwKmzdvz8M6zVPJq8dIycxxoi4Ef8BdHtoL0sa7QGTaUqXvDe2EphG+xgTjcfhKT8XquA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2017 04:05:38.2395 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2465 Subject: Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 04:05:43 -0000 On Monday 09 January 2017 09:48 PM, Ferruh Yigit wrote: > On 1/9/2017 3:19 PM, Ferruh Yigit wrote: >> On 12/26/2016 1:24 PM, Shreyansh Jain wrote: >>> These callbacks now act as first layer of PCI interfaces from the Bus. >>> Bus probe would enter the PMDs through the rte_driver->probe/remove >>> callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the >>> drivers are rte_pci_driver). >>> >>> This patch also changes QAT which is the only crypto PMD based on PCI. >>> All others would be changed in a separate patch focused on VDEV. >>> >>> Signed-off-by: Shreyansh Jain >>> --- > <...> >>> >>> diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c >>> index 1e7ee61..bc1a9c6 100644 >>> --- a/drivers/crypto/qat/rte_qat_cryptodev.c >>> +++ b/drivers/crypto/qat/rte_qat_cryptodev.c >>> @@ -120,6 +120,10 @@ crypto_qat_dev_init(__attribute__((unused)) struct rte_cryptodev_driver *crypto_ >>> >>> static struct rte_cryptodev_driver rte_qat_pmd = { >>> .pci_drv = { >>> + .driver = { >>> + .probe = rte_eal_pci_probe, >>> + .remove = rte_eal_pci_remove, >>> + }, >> >> Since this part is common for all PCI drivers, why not make this part of >> RTE_PMD_REGISTER_PCI macro? >> > > I have seen your comment [1] which looks like better idea. Thanks. And, actually, it is mostly Thomas's idea :) > > providing a rte_bus->probe(), > > and rte_eal_bus_probe() calls rte_bus->probe() > > for pci devices, rte_bus->probe = rte_eal_pci_probe .. > > > [1] > http://dpdk.org/ml/archives/dev/2017-January/054125.html > > Thanks, > ferruh >