From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66D13A0350; Fri, 21 Jan 2022 15:39:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBCDA42762; Fri, 21 Jan 2022 15:39:42 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6DD9540042 for ; Fri, 21 Jan 2022 15:39:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642775980; x=1674311980; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=XNfxgyM+UcAQTIawA4yW98chw7Y+K6hd2bBMXGShVsI=; b=gHEOc2Tjqi8777xjS3fLdy4njuJ4B/tdc8T3DmBz/KZdndQBw37Jy2XJ aLroHNaNlJpK/3iZJCYDM3I3Zls21qf0LMLqwullMhH2ykDr3u2ljPOxq G4FAvsxuCctb4f0KSZachADU1ASzqrlStSqNJ5eZx3Wv3sI2ovc+1bEhZ avkIpWdmCv/TldHWgll3r6mTX44SnZT3Vq1cqyuGPzN0Bm9iDJL0e3iOV R9KUy4M4HnKyxWERYyQR6OYX4GCrOwFSLZU7fPX0xlXSzeWaKLcwEnURE 2Gv1syOPvCiqPg0Og/5pd6sxP/5RVhMQdEqeWxDSRr1NnQa0ZT+JvIbKm A==; X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="245611335" X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="245611335" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2022 06:39:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="626751663" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 21 Jan 2022 06:39:39 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 21 Jan 2022 06:39:38 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 21 Jan 2022 06:39:38 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 21 Jan 2022 06:39:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+J49EvFjx7RTKPgY6IqZgO7E9AN7gQC90cYBc2fHLMci1NH8PF1XaUmzLbYmXdMjl9x56CuyEb3M1uViW4lHMWYGQEZGyoq1TRdd/VAE8OhvftsNwG1gUsIhtEQO2lG9geaYZXuSiBeKKwrgfWxgexQSQGlXYropTwGBOgX3Iqz7GbmpMSHwjvLtTrWhijxoQRI4k3rKLYPaXxCi2whpTaEJjbGcPRWLZnj0a8xakcmBT7oDOhmy/3AF/1Lyy6fNFC2edrw83A5Si/i9C38lapfJSGEquj4N/5YczYQSAZ0lpeqwejR63iCatykl7DsZ5zIRy44d5Gd4rp7+HQmlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QIdzSBYTlxNa4ZeWhN1UDLvVtMQ2UUliQCaNUPNlRgQ=; b=PeVuc1tPPD8TmbMN2GLBSOVfE12Lfc+A/rW5speY3QAZlLd+pV95RbwKt0lokm3ZURtp51z17xlXjZ00HY09xqFUimOhsXuLZutZtFhwMAGFBCUpZnyzyAvZ/ANM1eqSUEbdIKmHTqSOvG/FmcsZz2wmTywqM/6R0DkCGsTliqVXFEciU5Us4SqDUvSwaxgxp/d1Kc0bDWhFTgL/60pDRAuLBwhcBThYuJS2edEdd7Qq2Kr0sQ64BlnrMrxpR1mRi/wFSSN81L+ZCD2hRdMT1UJtJw1xVPZcbvr97SU6qfic8VpNqCcRzrprATmLNM9nptm0f0cBuYMm4TV6v+lszA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.12; Fri, 21 Jan 2022 14:39:37 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.010; Fri, 21 Jan 2022 14:39:37 +0000 Message-ID: <2ef45d11-68e5-e178-70f4-3b09f51f86a4@intel.com> Date: Fri, 21 Jan 2022 14:39:31 +0000 Content-Language: en-US To: Kevin Traynor , Maxime Gouin , CC: Heinrich Kuhn , Alejandro Lucero , Olivier Matz References: <20220105103203.7166-1-maxime.gouin@6wind.com> <20220105103203.7166-2-maxime.gouin@6wind.com> From: Ferruh Yigit Subject: Re: [PATCH 2/2] net/nfp: remove useless range checks X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0143.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99bebfed-1afe-4d8f-f14f-08d9dcebd944 X-MS-TrafficTypeDiagnostic: BYAPR11MB2901:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lh3zymclx/HCNGbyPV1TrGG98ugA/s6tUdAnaPDTCi+9TfYaiwHpIAga3gEIQIxSqAMFdD/x9grVzmSbfZilYBQuCdLPQtCRa2GTVbNTfUL50JpCUIzUeNykU2Qi43qQwnWJ2e4qNmx8RxsGhGGqGdOqENUXS91TdB58vTJKi8Q/MTltkjBqZVa8Cmsz7AqTHKcigKppB0/2lKSQX3zrZj5Ltbqr7gQ1f03kNN/srslDgMC2qCdu7L9c/6AMQlZ3S4IKHXBTDY298tjaiGDrHZlpFGIWuLEzq7RVyIeEXK4+7La31LzNoOeyIjwVZO7iZKR2+j3rdxf+6uhrJ/4z8BaGFu3LSKZcRHbj5k6jaGtuOwCMkeS6iFdyeGzIBEgucgyXVum27ni/BHjV8SMi/sE5L0RVJP+l4LqIRiG4xJpc3Je2d+BjQQWm9njsCmNGROwl3S9z3TpKCH++sMTNI29ccY/84gWEXXwndM66LlrI0VJ9z7B1g+xOp9RbZy5GJMsCz9JiH9iPbtxZyXKS8zdsRSoJGJCg01KfKj6jgF293OqEvdZ0JzCl1bbtOcT+M73UYKzDsUt6UovdGpFm36WkAGQK9EOznWj1+NsCGeMdeyvHkkTqD0yj6B/FgleX6C8LDYOX2S4GeWWB8nkYsxzydgY1YeBiIKQCOXi6oS0IyMUPWHBgCcDK6iSrEaX+bvab3e3QTwrqSW1MhTMtEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(26005)(8936002)(110136005)(8676002)(186003)(2616005)(6512007)(86362001)(2906002)(31696002)(54906003)(31686004)(6486002)(316002)(82960400001)(38100700002)(4326008)(36756003)(66946007)(66556008)(66476007)(6666004)(53546011)(5660300002)(508600001)(6506007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SllwQllVejVKM0xIQ2JOYzRYN0RYbHpUN1BNTEFYY2pOSG5MTUNEV2tqTnBR?= =?utf-8?B?c2cyZkliVHF0ZWxYeWxhOUpsN3hXTlRIQnRmRGpBQi9ob2YxaG1aa296bTdS?= =?utf-8?B?eHVwWUlFM3M0bTA4cVgwZEdDc1BpZmVEWlRWSnVuZTczYUI2SjZOQ0ZhaHY5?= =?utf-8?B?RThOci9GL0pDQW1CS0lSRm5IZmp6OUVtTE1aNHNaeTg2cGYxcDFqV0kyMzhZ?= =?utf-8?B?emN0UVhGKy9Xc0dTQ0k1aFlMMGcwSTRkRXFNMXQ3RGV2a2dHSU90ZkJwMzg2?= =?utf-8?B?NHcvTSs0NzV2ZHpZdytUa092M1A0VmpKRFlPRytkWUFoVUs5SnZUbS9JSmhC?= =?utf-8?B?MVI3Z1ZveVNKWlRscHhrQVY2VThNT29IUWlHdXNMWmhIRkM3Z1BJUE90WG16?= =?utf-8?B?TnZrQUVheFlEM21VY3FXbWIwYjQxQWhwN08vcTVwTk9nQ1F5SkpIaHpoSW54?= =?utf-8?B?c3BGbHArUlRqRWpTU25Odm03NldqVUFzYXhNVWpibGcwemE3bmltTGM3OFhU?= =?utf-8?B?bEtFdG05Q0hhVmUvMi80L3BRU2pFeW1BZVNiaGdobmdrSW9nWm8rR0ttSHhr?= =?utf-8?B?MitscEIrWFZIcC9GdWdGajk2NW52TjB6aktnUTQraTczTUpqNjFiNEFNQWFM?= =?utf-8?B?T08vUUN3dmwxR2diT0t1RXNWSjUxVWZJT1B1Znl5N1A1S3Q0VkkxMFRETVZ4?= =?utf-8?B?Q2VSeG8vUkRZbnQ5dTlFUnJXekxqdzEzb2hLUzRZdE9UU3NEZU1oZEh5Q1o2?= =?utf-8?B?cisvbTZnTXNkcmxMM21kSWIzT2xlcnl4R0kzU1BEL3JWM1J6Nm0zTWpwYmNK?= =?utf-8?B?Qzd2b285TFhxdFJtWDhDbzdMcy8rd1hwVmFWbUJyZ2NwY2FwNUliU2RkTHhl?= =?utf-8?B?d1hISGF5U2h4UEI3cnZON25IbXFZaXR2NEIyaFN4THdSUkFEUTZBZGI4SUdY?= =?utf-8?B?Q0duZzZwOHRpVVk5SnNvSGVhc3FmU0Z6ZWxXZWdUS0JnVzJQS1JNOVp0emRB?= =?utf-8?B?UVFBWDJxOUx3K2NkaTQ4N0QrRjNIanE4QkZBc2FUbjI0TkpYcFlLWmpGUzNU?= =?utf-8?B?NXMxZkU3SmI0bWdpTDVHVWF0bDNQNzU0aUtsY0JyQUJvRkJkWFhnVHVJVjRr?= =?utf-8?B?ZnZoSW9JR2t4SVBWWlNGSTVmemFJV1lRai9JY3BEamRFSk0wWG40R1F6bVJF?= =?utf-8?B?Z2tydXEvUkxoRDhPdlVTejBVcE0zd0duL0duclgrWjdQemc3aGVzZ09HUi96?= =?utf-8?B?ZFdqdTVOTno1a2syS0h2ZmdsSE9mcys0MGc0THlGTkdPNk1pRXFENmgwakhB?= =?utf-8?B?TzJrUU1RZERlWFlMbTRrWnU3OVBUNWVOTFlvNG1hMkR2YUZyYVdESml6UWVp?= =?utf-8?B?cFhOMzVDSzUyQWdTTjhiKzYvZnVsZE1DYjB4cWRmSTFVVlJFSERyQmtrLytL?= =?utf-8?B?dEptM3FreUpVTFBna3pJWHA4am9Jdm5rTzRRQjJqL1poOWxYN09UV051Vlkv?= =?utf-8?B?RUJ2T1dDU2I0OXFRVmQrb3F2RWFKMW5LLy80Qy90UXJQYktPTXF2aktOdXJC?= =?utf-8?B?eXpnVWUrMjVpcnJJZ2FkbXFEVWdtNGg2ZTNwamwxY3RsV1RvRmFzRzlYUE9l?= =?utf-8?B?MDJYb3BGZVgyODlZMTcvVS9uaklzVWNuRFU0TkNTTC9vZHRkOCt2OHZPc29O?= =?utf-8?B?MHAwK2ZQbXd5UXJOQkNMdDNQRDNJalVaNlhVOFBERXE1cXA0ditjZzN3bmt0?= =?utf-8?B?YmFXNDlUNmlyWFV3V2d5ZXc4RDQxeGNoajNqbkxlaXl2Y2lpMGREUFVURkhJ?= =?utf-8?B?aEFXdHJ4MzhFaGI1Zmx1Yjd4N3ZNVVJjYW9talptRm52ZytVRkowUDRhM25Z?= =?utf-8?B?WStYb2Z1TzB6czJ6NlpnTXM0Q0xNbStuR2ZGTy9jN1FxZmNoZFVRQWZiamhC?= =?utf-8?B?dEx1RWE0K3JDbDNVN0tZRjhSamNPeTZQRzJVbkxxbEpIZ0pQN1o2OEx3d01a?= =?utf-8?B?WnNCczRXNFhyOVhWTjJlcjFyeEtrempjZ0lXMTgxSytyTWdFaGlTUmhYWUJa?= =?utf-8?B?Rm14dExOdmliengwZDFpQ05LbnJaK0NBRDF3bDNWT2tGVTZSNDY1QnRDR2ht?= =?utf-8?B?aHlsV01pUU8reTBwTVFIR2haMUNRSDBGYTA4cFZBR0syL2JEdll0Slora2cr?= =?utf-8?Q?/7N8nIQ3I8fSB8RjrAs1Q3g=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 99bebfed-1afe-4d8f-f14f-08d9dcebd944 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 14:39:37.2734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3MwczKozGuKBzln/otBzV2+jm39mj8J2sQViy+UK0US7PzXlnUDMFq7rgdSlptV+ohgRoZ+G18H8KUuQ66ppmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2901 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/11/2022 2:54 PM, Kevin Traynor wrote: > On 05/01/2022 10:32, Maxime Gouin wrote: >> reported by code analysis tool C++test (version 10.4): >> Hi Maxime, Can you please give some information on this tool? Thanks, ferruh >>> /build/dpdk-20.11/drivers/net/nfp/nfpcore/nfp_target.h >>> 375   Condition "island < 1" is always evaluated to false >>> 415   Condition "island < 1" is always evaluated to false >>> 547   Condition "target < 0" is always evaluated to false >> >> All of these conditions have the same error. They call >> NFP_CPP_ID_ISLAND_of or NFP_CPP_ID_TARGET_of which return a uint8_t and >> put the result in "island" or "target" which are integers. These variables >> can only contain values between 0 and 255. >> >> Fixes: c7e9729da6b5 ("net/nfp: support CPP") >> > > Cc: stable@dpdk.org > >> Signed-off-by: Maxime Gouin >> Reviewed-by: Olivier Matz >> --- > > Acked-by: Kevin Traynor > For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.