Re: [dpdk-dev] [PATCH 1/2] net/hns3: support SVE Rx

[oulijun <oulijun@huawei.com>]

在 2020/10/26 0:18, David Marchand 写道:
> Hello Wei Hu,
> 
>> diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build
>> index bf69ad4..ca0f21a 100644
>> --- a/drivers/net/hns3/meson.build
>> +++ b/drivers/net/hns3/meson.build
>> @@ -31,4 +31,9 @@ deps += ['hash']
>>
>>   if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
>>          sources += files('hns3_rxtx_vec.c')
>> +       if (dpdk_conf.has('RTE_MACHINE_CPUFLAG_SVE'))
>> +               dpdk_conf.set('RTE_LIBRTE_HNS3_INC_VECTOR_SVE', 1)
>> +               cflags = ['-DCC_SVE_SUPPORT']
>> +               sources += files('hns3_rxtx_vec_sve.c')
>> +       endif
>>   endif
> 
> This patch is already merged in main, but RTE_MACHINE_CPUFLAG_* have
> been removed, see https://git.dpdk.org/dpdk/commit/?id=84fb33fec1
> I guess SVE support is not working because of this.
> 
> Please use compiler flags to check for support.
> If you need an example on how to do this, you can probably look at
> what has been done for Intel vector stuff.
> 
> Besides, RTE_LIBRTE_HNS3_INC_VECTOR_SVE is not used anywhere and can be removed.
> 
Hi，David Marchand
   I have checked. I will send a fix patch for enabling.

Thanks
Lijun Ou
>