From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 6E5301BB9F for ; Fri, 11 May 2018 03:37:29 +0200 (CEST) From: Andy Green To: Stephen Hemminger Cc: Jerin Jacob , dev@dpdk.org References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> <20180510061731.GB12718@jerin> <20180510091147.GA26838@jerin> <20180510115759.GA8776@jerin> <20180510080142.0c49116f@xeon-e3> Message-ID: <2f1c5b59-1622-5895-f2a2-a5cc035d5bde@warmcat.com> Date: Fri, 11 May 2018 09:37:09 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 01:37:29 -0000 On 05/11/2018 08:29 AM, Andy Green wrote: > > > On 05/10/2018 11:01 PM, Stephen Hemminger wrote: >> On Thu, 10 May 2018 20:13:31 +0800 >> Andy Green wrote: >> >>> I appreciate the reply. >>> >>> But why bother having a subject line at all if it is going to be >>> mechanically enforced that nothing in it is allowed to be "useful"? >>> That really doesn't make sense does it. >> >> >> It was done because there were lots of clueless patches showing >> up on the driver development list which had useless subject >> lines. > > The "cure" is worse than the disease... > >  - I can mention, eg, that something changed to an int.  But a size_t > or my_type_t?  I am not allowed to mention it even if that is the whole > reason for the patch. > >  - I can mention most libc apis, but not those that happen to have an > underscore, eg, timerfd_create(), even if that was the focus of the patch. > >  - Any kind of manifest constant like MY_CONSTANT: illegal to mention, > even if the patch's job is change MY_CONSTANT to, say, 5.  What should I > entitle that patch?  "lib: change something to 5"?  "lib: change > MY.CONSTANT to 5"? > >  - I can mention most filenames or paths, eg, down /proc, or myfile.c. > But not if the filepath happens to contain an underscore.  Even if the > effect of the patch is to migrate stuff from myfile.c to my_files/ > > The results are arbitrary... please consider removing this now it has > been in place a while and made its original point. Having now used check-git-log.sh, also 1) It reports every patch has "Wrong headline uppercase" on Fedora 28, even, eg, "net/nfp: solve buffer overflow". Googling around https://stackoverflow.com/questions/11166825/grep-case-sensitive-a-z I checked a patch on the patch checker to make it use [[:upper:]] and it works OK. So there is another patch in the series adapting this. 2) It claims "app/test-pmd" is a "Wrong headline label". "app/proc-info" and "app/test-bbdev" are accepted. It's because it does this, but app/test-pmd is a real directory: # check headline label for common typos bad=$(echo "$headlines" | grep --color=always \ -e '^example[:/]' \ -e '^apps/' \ -e '^testpmd' \ -e 'test-pmd' \ -e '^bond:' \ | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong headline label:\n$bad\n" I just left that and told it app:. They all pass the thing now. -Andy > -Andy