From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2D5C1A0032;
Thu, 12 May 2022 02:20:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id CF30F410EF;
Thu, 12 May 2022 02:20:39 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by mails.dpdk.org (Postfix) with ESMTP id 45AA540E64
for <dev@dpdk.org>; Thu, 12 May 2022 02:20:36 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1652314837; x=1683850837;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:content-transfer-encoding:mime-version;
bh=ta9oju8IUvrWRVcm+wgpTSbTJuXMg57Kdaw+pML1M9o=;
b=NLePKI4glEFFK3aALpJsiLZ2Dqr8pmCeZTQpgRuT2sgj3HAOIzudFcLM
esuMU+tWnbKdRxKHgnthQIlnE/aGuefqL8IqRQKG7sytzKDePoiHWo6Zg
G4cYWO1oG7ppArNlq6VkCG0vsHG+pIIUOin/2LHzQLe5cMRFtgTwYG/tZ
a6kb+n3q/t6VLdGG8cLl6dexDsESZmT5rG69gjF5Xtjbi85ass8YIdxm5
1yLoRAf7QD/N5QY1yAwS8SsyVMtjmXmtE0KKjNTHsnxVxjWLKAb+ENRjn
/2qxTN0TUgHntzXatLmpqUbptaGf+IBrAXTCItt4UrBbyvipy9eSfP5xl Q==;
X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="332885718"
X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="332885718"
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
11 May 2022 17:20:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="697800488"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by orsmga004.jf.intel.com with ESMTP; 11 May 2022 17:20:34 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.27; Wed, 11 May 2022 17:20:34 -0700
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.27; Wed, 11 May 2022 17:20:33 -0700
Received: from fmsmsx612.amr.corp.intel.com ([10.18.126.92]) by
fmsmsx612.amr.corp.intel.com ([10.18.126.92]) with mapi id 15.01.2308.027;
Wed, 11 May 2022 17:20:33 -0700
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Wu, Wenjun1" <wenjun1.wu@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: RE: [PATCH v1] net/iavf: fix resource leak issue
Thread-Topic: [PATCH v1] net/iavf: fix resource leak issue
Thread-Index: AQHYZAuwVaVdh/pZMk2oX19VCKhiva0ZkVRQgACpV4D//5UiAIAA1mAA//+8rIA=
Date: Thu, 12 May 2022 00:20:33 +0000
Message-ID: <2f3663f9e4bf4c4d9c3993cabe57bcc5@intel.com>
References: <20220510005425.1648591-1-wenjun1.wu@intel.com>
<2551212.tIAgqjz4sF@thomas> <cf23d2d95ff24ecfa224e1a4d2a7d081@intel.com>
<4349564.Wku2Vz74k6@thomas>
In-Reply-To: <4349564.Wku2Vz74k6@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-reaction: no-action
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
x-originating-ip: [10.239.127.36]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, May 12, 2022 5:17 AM
> To: Wu, Wenjun1 <wenjun1.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com=
>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: Re: [PATCH v1] net/iavf: fix resource leak issue
>=20
> 11/05/2022 17:31, Zhang, Qi Z:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 11/05/2022 13:46, Zhang, Qi Z:
> > > > From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> > > > >
> > > > > This patch fixes resource leak issue reported by coverity.
> > > > >
> > > > > Coverity issue: 378017
> > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration=
")
> > > > >
> > > > > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> > > >
> > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > > >
> > > > Applied to dpdk-next-net-intel.
> > >
> > > In the title, the word "issue" is useless.
> > > It would be more interesting to precise where is the leak.
> > >
> >
> > Added below into commit log in dpdk-next-net-intel.
> >
> > kvlist should be freed before return an error due to invalid quanta siz=
e.
>=20
> It does not explain what is the scenario. What is the impacted feature?
I think the scenario has been explained as
"kvlist should be freed before return an error due to invalid quanta size"
the impact has been mentioned as "resource leak" I guess this is how Coveri=
ty describe the issue
i agree "memory leak" would be better.
>=20